Hi julien2412,
On Sunday, 2015-02-15 04:07:56 -0700, julien2412 wrote:
Anyway, I pushed the patch, see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=836481e35999c3722f1c4fdef8c86c8c098a2492
Yup, the only use was eliminated with
On 02/14/2015 05:49 PM, julien2412 wrote:
I noticed CalendarWrapper::getDSTOffsetInMillis() const and
CalendarWrapper::getZoneOffsetInMillis() const in unusedcode.easy
I wanted to remove them but saw that they were in class UNOTOOLS_DLLPUBLIC
CalendarWrapper
Does it mean these can't be removed
the stable public API perspective
:-)
Anyway, I pushed the patch, see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=836481e35999c3722f1c4fdef8c86c8c098a2492
Julien
--
View this message in context:
http://nabble.documentfoundation.org/unused-easy-code-getZoneOffsetInMillis-unotools
Thank you Miklos for your feedback so I won't remove them since it would
change public API.
Julien
--
View this message in context:
http://nabble.documentfoundation.org/unused-easy-code-getZoneOffsetInMillis-unotools-tp4140095p4140140.html
Sent from the Dev mailing list archive at Nabble.com
Hi Julien,
On Sun, Feb 15, 2015 at 01:05:36AM -0700, julien2412 serval2...@yahoo.fr
wrote:
Thank you Miklos for your feedback so I won't remove them since it would
change public API.
You got it wrong, my suggestion was that it's *not* part of the public
API, even if it has public in the macro
could
use them?
Julien
--
View this message in context:
http://nabble.documentfoundation.org/unused-easy-code-getZoneOffsetInMillis-unotools-tp4140095.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice
Hi Julien,
On Sat, Feb 14, 2015 at 09:49:35AM -0700, julien2412 serval2...@yahoo.fr
wrote:
I noticed CalendarWrapper::getDSTOffsetInMillis() const and
CalendarWrapper::getZoneOffsetInMillis() const in unusedcode.easy
I wanted to remove them but saw that they were in class UNOTOOLS_DLLPUBLIC
