I think, I'll add a how to prepare and send patches section to the
wiki, as that causes lots of confusion. Is there consensus by committers
whether we want to have patches attached to a mail or sent inline with
git send-email? Depending on the outcome, I'll write up the
recommendation accordingly.
On Fri, 2010-11-05 at 18:13 -0700, John LeMoyne Castle wrote:
Hi all,
[...]
Still new to git but I am sure I saw and built and ran the old txtedt.cxx
and still no LSQEW. Feelin' a bit lost ... I can think of some other
options for trying to find what fixed the LSQEW but I feel like I'm
On Fri, 2010-11-05 at 15:30 +0100, Giuseppe Castagno wrote:
Hi all,
I tried to install the LibO-SDK as generated in my build from master,
and I noted that has some link/mingling with OOo.
Looks good, pushed to head and I cherrypicked it for Libo 3.3 as well
C.
On Sun, 2010-11-07 at 12:33 -0600, Norbert Thiebaud wrote:
On Sun, Nov 7, 2010 at 7:00 AM, julien serval2...@yahoo.fr wrote:
the if() can only be true if that value is not 0 so here you have a false
positive.
Julien, could you log a bug against cppcheck itself with this example,
including the
On Sat, 2010-11-06 at 10:13 -0500, Norbert Thiebaud wrote:
There is some improvement on the smoketest front
It run pass many more tests.. but still do not finish:
The smoketest passes every time for me. FWIW
# A fatal error has been detected by the Java Runtime Environment:
#
# SIGSEGV
On Fri, 2010-11-05 at 20:19 +0530, surensp...@gmail.com wrote:
Updated the second patch and tested it.
Looks good to me, pushed this now. Thanks for this.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
Selon Caolán McNamara caol...@redhat.com:
Hmm, one of the + 129 is FN_NEW_PAGE_STYLE and appears (according to
opengrok) unused the FN_PAGE_STYLE_SET_LR_MARGIN and
FN_PAGE_STYLE_SET_UL_MARGIN i.e. one version of the + 130 and + 131 are
only mentioned in basesh.cxx as false not implemented.
On Sun, 2010-11-07 at 14:16 +0100, julien wrote:
Hello,
I can't test this patch since this part of code is for Windows but i
think it's a true positive
Yes, I agree, its a potential memory leak
Is this ok or am I wrong ?
Yeah, this is ok, and I've pushed this fix, thanks :-)
Though, if
On Mon, 2010-11-08 at 19:22 +0900, Takeshi Abe wrote:
Hi,
translating lo-build.pot to the Japanese .po, I found a typo in libs-core
which affects a msgid (numbered as 277) in the .pot.
It would be nice if we can apply the attached patch before the string freeze.
Excellent! The change looks
On Sun, 2010-11-07 at 19:53 +0100, Robert Nagy wrote:
The diff makes i18npool/source/paper/makefile.mk define
LIBTARGET=NO just like other makefiles in the i18npool/source/ directory.
Without this patch I always get:
dmake:
On Mon, 2010-11-08 at 00:59 -0500, Kevin Hunter wrote:
Hullo List,
Some accessibility tabbar RTL_CONST conversion goodness.
Looks good, pushed. Thanks for this.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
On Mon, 2010-11-08 at 02:42 -0500, Kevin Hunter wrote:
Hullo Committers,
One more RTL easy hack commit against:
Also looks good, pushed now as well, thanks.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
On Sat, 2010-11-06 at 19:50 +0100, Robert Nagy wrote:
Hey
I don't really care which one goes in. I think gzip -d might
be a better idea then. Any other comments?
I say go ahead with gzip -d, should be fine for everyone.
C.
___
LibreOffice mailing
On Mon, 2010-11-08 at 00:53 +0200, Ricardo Moreno wrote:
here is more commented code removal.
Reviewed and applied the part against the 'sc' module. Thanks a lot!
I removed everything except for the one in sc/inc/compiler.hxx (below).
@@ -101,13 +101,6 @@ class ScTokenArray;
On Mon, 08 Nov 2010 14:59:37 +0100, Sebastian Spaeth wrote:
There was #ifdef'd test code depending on WITH_CORE being defined (which
is never set in our build system). It is described as test code that
will core dump for sure. So let's remove this and write proper cppunit
tests instead. All
Sebastian Spaeth wrote:
What would be super-nice, would be if we could have a patch a little
like the Help-License info one - cf. sfx2/source/appl/appserv.cxx -
that would load a nice ODF document containing the output of your work -
so that we cna ship that with the binaries, and make it
On Mon, 2010-11-08 at 10:57 -0500, Norbert Thiebaud wrote:
On 11/8/10, Noel Power nopo...@novell.com wrote:
returns true if it was able to successfully extract the value from the
'theAny' into 'something' so there is a possibility of a runtime divide
by zero ( and probably should be
On Sun, 2010-11-07 at 20:42 +0100, Robert Nagy wrote:
If the internal hyphen library is used which does not
build a shared object, then link to $(SOLARLIBDIR)/libhyphen.a,
instead of using -lhyphen on UNX + GCC.
How come, the -L options should place solarlibdir before the system
ones, so
On Mon, 2010-11-08 at 00:53 +0200, Ricardo Moreno wrote:
here is more commented code removal.
Reviewed and pushed the part against the 'base' module. Thanks a lot!
One thing to note: you added a blank line between the else if blocks,
but I didn't add that change, as I consider that to be
On (2010-11-08 16:29), Caolán McNamara wrote:
On Sun, 2010-11-07 at 20:42 +0100, Robert Nagy wrote:
If the internal hyphen library is used which does not
build a shared object, then link to $(SOLARLIBDIR)/libhyphen.a,
instead of using -lhyphen on UNX + GCC.
How come, the -L options
On Mon, 2010-11-08 at 15:18 +0100, Gert Faller wrote:
yes, I checked that too.
Do you think that can be left untouched ?
They can probably be left untouched without much harm at first glance,
but removing the three duplicated and apparently dead ones is probably
the right thing to do if you
On Sun, 2010-11-07 at 23:53 -0500, Kevin Hunter wrote:
Hullo Committers,
A simple patch set to remove some unnecessary comments. As always, LGPLv3.
Hum, the comments like...
// XServiceInfo
// XAccessible
are being used to indicate in this multiply inherited class for which
parent class
On Mon, 2010-11-08 at 00:53 +0200, Ricardo Moreno wrote:
here is more commented code removal.
Ok. Just pushed the remaining chart2 part of the patch. All looks good.
Thanks much. :-)
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hi Christoph,
On 2010-11-03 at 00:29 +0100, Christoph Noack wrote:
I'm answering here since - if there is some dev interest - there are
some more ideas on different lists that might be worth considering. Even
Easy / Medium Hacks that turn out to be very visible ...
Oh - it seems it works
On Mon, 2010-11-08 at 09:57 -0500, Kohei Yoshida wrote:
On Mon, 2010-11-08 at 19:22 +0900, Takeshi Abe wrote:
Hi,
translating lo-build.pot to the Japanese .po, I found a typo in libs-core
which affects a msgid (numbered as 277) in the .pot.
It would be nice if we can apply the attached
Hello List,
Here's another set of patches. Caolán, I think I've done a little
better on the comments this time, but probably not yet perfect.
accessibility/
Cheers,
Kevin
comment_removals.tbz
Description: application/bzip-compressed-tar
___
Hi Peter,
On 2010-11-02 at 21:19 -0300, Peter Burtt wrote:
The cygwin SETUP.EXE accepts a comma-delimited list of packages to
install. To install cygwin and the packages listed as prerequisites on
Hullo List,
Another RTL_CONST patch, also against accessibility/ .
Cheers,
Kevin
0001-EasyHack-createAsciiFrom-RTL_CONST.patch.bz2
Description: application/bzip
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
Hi List,
A patch to remove large blocks of already commented code.
basic/
Cheers,
Kevin
basic_commented_removed.tgz
Description: application/compressed-tar
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
On Mon, 2010-11-08 at 20:51 +0100, René Kjellerup wrote:
hi',
cleaned some coments
and killed an unused function
Looks good. Pushed.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
Le 08/11/2010 14:33, Caolán McNamara a écrit :
On Sun, 2010-11-07 at 12:33 -0600, Norbert Thiebaud wrote:
On Sun, Nov 7, 2010 at 7:00 AM, julienserval2...@yahoo.fr wrote:
the if() can only be true if that value is not 0 so here you have a false
positive.
Julien, could you
Hi Kohei,
On Mon, 08 Nov 2010 12:40:03 -0500, Kohei Yoshida kyosh...@novell.com wrote:
(snip)
Excellent! The change looks good, and I build-tested on master.
Before cherry-picking this to libreoffice-3-3 branch, let me ask Andre
to make sure if we are still before the string freeze..
On Mon, 2010-11-08 at 01:11 -0500, Kevin Hunter wrote:
Hullo Committers,
A patch set against directory:
accessibility/source/helper
RTL_foo macro looks good, thanks for this :-) and I added in the comment
stuff as well while I was at it.
C.
On Mon, 2010-11-08 at 01:33 -0500, Kevin Hunter wrote:
Hullo Committers,
Another patch set, this time against
accessibility/source/standard/
I pushed all the RTL_macro foo, all good, thanks.
I only pushed a few hunks of the comment removal stuff though. I'm no
fan of the line
On Mon, 2010-11-08 at 02:36 -0500, Kevin Hunter wrote:
At 2:17am -0500 Mon, 08 Nov 2010, Kevin Hunter wrote:
Subject says it all. Patch against three files under
automation/source/
Pushed the substantial hacking out of the commented-out code in
automation. Thanks. I'm holding back on the
On Mon, 2010-11-08 at 17:42 +0100, Robert Nagy wrote:
Making:libhyphen.so
Ah, this is in lingucomponent/source/hyphenator/altlinuxhyph/hyphen
right ? Then this is a duplicate of the other problem you had with the
build breakage in i18npool. It should be making
libhyphen$(DLLPOSTFIX).so and
At 4:23pm -0500 Mon, 08 Nov 2010, Caolán McNamara wrote:
Pushed the substantial hacking out of the commented-out code in
automation. Thanks. I'm holding back on the end of line whitespace
stuff because all of our files have it, at least in line 4 :-). Maybe
we can resolve all of those in one
Hullo again,
Some more easy hack RTL code.
bridges/
Kevin
bridges_rtl_easy_hack.tbz
Description: application/bzip-compressed-tar
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
I am not a perl expert, but I have figured out this command:
perl -i.bak -wpl -e 's/ +$//g;' *.cxx
The original files are save as *.bak and can be removed if the revoval of
taling spaces was correct.
Joost
2010/11/8 Caolán McNamara caol...@redhat.com
On Mon, 2010-11-08 at 02:36 -0500, Kevin
Hello again list,
My last contribution of the day, with two RTL patches for canvas/ and
chart2/ .
Cheers,
Kevin
canvas_rtl_easy_hack.tbz
Description: application/bzip-compressed-tar
chart2_rtl_easy_hack.tbz
Description: application/bzip-compressed-tar
Hi,
Following the hints of Michael Meeks in :
'https://bugs.freedesktop.org/show_bug.cgi?id=30944', here a first try in
writer.
It's 'raw code' : just wondering if it satisfies the required functionality.
Regards.
export_4.patch
Description: Binary data
Contact Prowol or Unsubscribe?
聯絡我們 或 不要收到 本電子報？
保證低價，投影機、布幕、音響、影音工程設計規劃
5000流明投影機出租，租金超便宜，(福音用途每小時500元「以實
際使用小時收費，自取價」)。歡迎來電洽詢!
+++我們是一家以協助教會、廣傳福音、幫助大家、省時省金為宗旨的基督徒公司+++
普洛瓦創意資訊有限公司
Tel
Contact Prowol or Unsubscribe?
聯絡我們 或 不要收到 本電子報？
Infrared Sensor Auto Hand-Washer
+++我們是一家以協助教會、廣傳福音、幫助大家、省時省金為宗旨的基督徒公司+++
普洛瓦創意資訊有限公司Prowol Co., Ltd.
Tel : 886-2-87706959
Fax :
Minor cleanup item I saw when preparing my last patches.
LGPLv3+/MPL
Jordan Ayers
From c2c5af35636a6f1bfd9f69b39e9baddc7da2f894 Mon Sep 17 00:00:00 2001
From: Jordan Ayers jordan.ay...@gmail.com
Date: Mon, 8 Nov 2010 19:56:49 -0600
Subject: [PATCH] Remove unused global from perl installer
Per
Miscellaneous cleanup to build.pl. Mostly removal of dead code, with
a few spelling / German-English fixes.
LGPLv3+/MPL
Jordan Ayers
From bcebd3c5cf9c62aa3321dca253a7d61bded6cde9 Mon Sep 17 00:00:00 2001
From: Jordan Ayers jordan.ay...@gmail.com
Date: Wed, 3 Nov 2010 23:35:04 -0500
Subject:
TIPOGRAFIA e STAMPA DIGITALE
www.tipoprint.com
Tel: 02 89 92 67 50
Gentile Cliente,
Crediamo sia cosa gradita farvi pervenire questa nostra offerta relativa ai
nostri stampati. E' una occasione da non perdere anche perche' potrete
sfruttare questa offerta per tutto il 2010 a sola condizione che
On Mon, 8 Nov 2010 22:23:07 -0600, Jordan Ayers jordan.ay...@gmail.com wrote:
Some more cleanup for the perl installer.
Thanks, pushed as 4e7555bf001050752e7380c54dd804fa9566d7ad
Removing nearly 500 lines of commented out code. I just left one hunk
that seemed remotely usefull for future
On Mon, 8 Nov 2010 17:20:25 +0100, Thorsten Behrens wrote:
Ah sorry, my backlog is building up - I actually added that feature
- now we only need a nice credits .odt. ;)
Mmh, I tried to import the .html into LibreOffice, but it looks pretty
crappy. If someone can come up with a nice template
49 matches
Mail list logo
