[Libreoffice] scripts in bin may need tweaking due to git conversion

2011-08-07 Thread Norbert Thiebaud
Petr, I did not patch most of the script in bin/. some of them still have references to /clone and/or 'bootstrap' so it is very likely that they will need tweaking. Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[Libreoffice] existing clones using old system

2011-08-07 Thread Jonathan Aquilina
Just out of curiosity those of us that have clones using the old build system will need to re clone correct? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] existing clones using old system

2011-08-07 Thread Eike Rathke
Hi Jonathan, On Sunday, 2011-08-07 08:38:10 +0200, Jonathan Aquilina wrote: Just out of curiosity those of us that have clones using the old build system will need to re clone correct? Yes. Eike -- PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication. Key ID:

Re: [Libreoffice] [PATCH] Replace SvULongs with vector and code clean up part 1

2011-08-07 Thread Eike Rathke
Hi Maciej, On Saturday, 2011-08-06 19:59:40 +0200, Maciej Rumianowski wrote: DBG_ASSERT( bFound, Key not found ); -aDelList.Remove( nAt ); +aDelList.erase( nAt ); Hmm.. I'd say the original code was wrong, when nAddKey was not found in

Re: [Libreoffice] [PATCH] compiling libreoffice-3-4 sal module with dbglevel=2: init test fails

2011-08-07 Thread Lionel Elie Mamane
On Fri, Aug 05, 2011 at 04:19:49PM +0100, Caolán McNamara wrote: On Thu, 2011-08-04 at 12:07 +0200, Lionel Elie Mamane wrote: A two-day-old clone of branch libreoffice-3-4 fails to build module sal with dblevel=2, unittest fails: osl_old_test_file.cxx assertion #failure 1.1: the failure is

Re: [Libreoffice] [PUSHED] DbgAssert error: HeaderBar::InsertItem(): ItemId already exists

2011-08-07 Thread Lionel Elie Mamane
On Fri, Aug 05, 2011 at 03:59:36PM +0100, Caolán McNamara wrote: On Fri, 2011-08-05 at 16:47 +0200, Lionel Elie Mamane wrote: I generated it against libreoffice-3-4, but it should apply cleanly against master, too. Looks sane to me, pushed. Confirm patch is under LGPLv3+/MPL1.1 ?, can do a

[Libreoffice] Build with --enable-werror

2011-08-07 Thread Eike Rathke
Hi, I'm trying to build with --enable-werror, in svtools I get /lo/core/svtools/source/misc/templatefoldercache.cxx: In member function ‘bool svt::TemplateContentEqual::operator()(const rtl::Referencesvt::TemplateContent, const rtl::Referencesvt::TemplateContent)’:

[Libreoffice] Handling EasyHacks in general (was: Re: [Libreoffice-ux-advise] Fwd: [PATCH] Bug 39167)

2011-08-07 Thread Christoph Noack
Hi Gerald, hi all! Am Samstag, den 06.08.2011, 19:04 +0200 schrieb Gerald Leppert: Hi Friedrich, hi all, does anyone here have a less rigid opinion on that matter than the one expressed by Friedrich? I really don't care whether you want LibreOffice to be a developers AND users community

Re: [Libreoffice] Build with --enable-werror

2011-08-07 Thread Eike Rathke
Hi, On Sunday, 2011-08-07 14:23:20 +0200, Eike Rathke wrote: I'm trying to build with --enable-werror Seems I'm hit by http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40146 Ok, I'll skip that file, wait for my new machine and install Debian wheezy that has gcc 4.6.1 Eike -- PGP/OpenPGP/GnuPG

Re: [Libreoffice] [PATCH] Replace SvULongs with vector and code clean up part 1

2011-08-07 Thread Maciej Rumianowski
Hi Eike, Dnia 2011-08-07, nie o godzinie 11:17 +0200, Eike Rathke pisze: You're right, the code is suboptimal ... in fact IsRemoved_Impl() and IsAdded_Impl() could also return the index of the element found so it wouldn't be needed to be searched again. Want to take care of it? Yes :) My

Re: [Libreoffice] [Libreoffice-ux-advise] Fwd: [PATCH] Bug 39167

2011-08-07 Thread Christian Lohmaier
Hi Gerald, *, On Sat, Aug 6, 2011 at 7:04 PM, Gerald Leppert glepp...@gmx.de wrote: [...] I only would like to know how users are allowed / should / can contribute to the EasyHacks-system. Sure they are, everyone is welcome to *suggest* easyhacks, but the actual flagging as such should not be

[Libreoffice] two assertions raised and a failed database query

2011-08-07 Thread Terrence Enger
Greetings, I am asking here about a couple of raised assertions and a failed database query. Maybe there is a connection, but maybe not. My system is ubuntu-natty (11.04), and I did a build with configuration parameters --disable-mozilla --enable-symbols --enable-dbgutil

Re: [Libreoffice] [REVIEW] fix for fdo#39678: don't write table:protection-key-digest-algorithm to odf 1.1 or odf 1.0

2011-08-07 Thread Markus Mohrhard
changed it and pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=8b8f6835e60e179de616117f59af64d6f2c34b0a 2011/8/6 Kohei Yoshida kohei.yosh...@suse.com Hi Markus, On Fri, 2011-08-05 at 22:01 +0200, Markus Mohrhard wrote: Hello, this patch should ensure that we

Re: [Libreoffice] One Git Conversion Done. new repos online

2011-08-07 Thread Kohei Yoshida
Hi Norbert, On Sat, Aug 6, 2011 at 4:38 PM, Norbert Thiebaud nthieb...@gmail.com wrote: The One Git conversion is done. Just want to make sure I understand our plan correctly. The core repository is for the master branch and future releases, while the 3.4 releases and older will still be done

Re: [Libreoffice] One Git Conversion Done. new repos online

2011-08-07 Thread Norbert Thiebaud
On Sun, Aug 7, 2011 at 12:33 PM, Kohei Yoshida kohei.yosh...@gmail.com wrote: Hi Norbert, On Sat, Aug 6, 2011 at 4:38 PM, Norbert Thiebaud nthieb...@gmail.com wrote: The One Git conversion is done. Just want to make sure I understand our plan correctly.  The core repository is for the

[Libreoffice] new feature/gbuild branch

2011-08-07 Thread Matúš Kukan
Hi all, I have been working on salhelper, so we could use gbuid. There were some issues with versions of library, so I have pushed my work to feature/gbuild branch in new core repo and Bjoern will do there some hacking. I hope it's just for a while. It would be nice if you won't do changes in

Re: [Libreoffice] [PATCH] Replace SvULongs with vector and code clean up part 1

2011-08-07 Thread Eike Rathke
Hi Maciej, On Sunday, 2011-08-07 17:04:49 +0200, Maciej Rumianowski wrote: You're right, the code is suboptimal ... in fact IsRemoved_Impl() and IsAdded_Impl() could also return the index of the element found so it wouldn't be needed to be searched again. Want to take care of it? Yes

Re: [Libreoffice] [PATCH] Replace SvULongs with vector and code clean up part 1

2011-08-07 Thread Maciej Rumianowski
Dnia 2011-08-07, nie o godzinie 21:31 +0200, Eike Rathke pisze: I suggest ::std::vectorsal_uInt32::iterator GetAdded_Impl( size_t nKey ); with logically the content of IsAdded_Impl() but using ::std::find() instead of the awkward loop and returning the position's iterator that can be used

Re: [Libreoffice] [Libreoffice-ux-advise] Fwd: [PATCH] Bug 39167

2011-08-07 Thread Bjoern Michaelsen
Hi Gerald, Hi all, On Fri, 05 Aug 2011 22:51:55 +0200 Gerald Leppert glepp...@gmx.de wrote: 1. The whiteboard tag ProposedEasyHack does not seem to have any effect. So far, I have not seen any bug tagged as ProposedEasyHack which was touched by a developer

[Libreoffice] (no subject)

2011-08-07 Thread Tommaso Bartalena
This message was sent using IMP, the Internet Messaging Program. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] Handling EasyHacks in general (was: Re: [Libreoffice-ux-advise] Fwd: [PATCH] Bug 39167)

2011-08-07 Thread Bjoern Michaelsen
Hi Christoph, all, On Sun, 07 Aug 2011 14:32:08 +0200 Christoph Noack christ...@dogmatux.com wrote: Whenever I've intended to add an Easy Hack (means: before or after adding it to the issue tracker), I've asked a developer to have a look at it, because: I feel confident with regard to UX

Re: [Libreoffice] Reviewing EasyHacks (was: Re: [Libreoffice-ux-advise] Fwd: [PATCH] Bug 39167)

2011-08-07 Thread Bjoern Michaelsen
Hi Christoph, Hi all, On Sat, 06 Aug 2011 00:02:36 +0200 Christoph Noack christ...@dogmatux.com wrote: My question is who should review the Easy Hacks before publishing - when looking from the Design Team perspective, it would be good to at least add a UX (User Experience) statement whether

[Libreoffice] ccache support

2011-08-07 Thread Norbert Thiebaud
I've pushed http://cgit.freedesktop.org/libreoffice/core/commit/?id=57cf026739a3d707378ca38f59518b018fccca8f This try to automatically use ccache when present, unless CC= or CXX= was specified by the user or --disable-ccache was passed to autogen This also detect if CC or CXX is already an alias

Re: [Libreoffice] ccache support

2011-08-07 Thread Christian Lohmaier
On Mon, Aug 8, 2011 at 1:21 AM, Norbert Thiebaud nthieb...@gmail.com wrote: I've pushed http://cgit.freedesktop.org/libreoffice/core/commit/?id=57cf026739a3d707378ca38f59518b018fccca8f Note on the Mac-OSX case: The previous check was not to completely disable ccache, but only to check whether

Re: [Libreoffice] ccache support

2011-08-07 Thread Norbert Thiebaud
On Sun, Aug 7, 2011 at 6:55 PM, Christian Lohmaier lohmaier+libreoff...@googlemail.com wrote: On Mon, Aug 8, 2011 at 1:21 AM, Norbert Thiebaud nthieb...@gmail.com wrote: I've pushed http://cgit.freedesktop.org/libreoffice/core/commit/?id=57cf026739a3d707378ca38f59518b018fccca8f Note on the

Re: [Libreoffice] ccache support

2011-08-07 Thread Christian Lohmaier
Hi *, On Mon, Aug 8, 2011 at 2:08 AM, Norbert Thiebaud nthieb...@gmail.com wrote: On Sun, Aug 7, 2011 at 6:55 PM, Christian Lohmaier lohmaier+libreoff...@googlemail.com wrote: On Mon, Aug 8, 2011 at 1:21 AM, Norbert Thiebaud nthieb...@gmail.com wrote: I've pushed

Re: [Libreoffice] ccache support

2011-08-07 Thread Norbert Thiebaud
On Sun, Aug 7, 2011 at 7:21 PM, Christian Lohmaier lohmaier+libreoff...@googlemail.com wrote: Hi *, That's not the point is it is if it's already an alias for ccache, it won't be prefixed with an additional ccace And that's not the case. CC is checked for ccache and possibly altered, then

Re: [Libreoffice] One Git Conversion Done. new repos online

2011-08-07 Thread Marc-André Laverdière
Hi everyone, If you are behind a firewall like me and you previously have corkscrew set up, you can use this URL: git clone ssh://git.freedesktop.org/git/libreoffice/core.git Of course, that one requires you to have commit access. -- Marc-André Laverdière Software Security Scientist