Re: [Libreoffice] Question about Possible null pointer dereference in SpellDialog.cxx (cui one)

2011-10-18 Thread Eike Rathke
Hi, On Friday, 2011-09-16 16:29:57 -0700, julien2412 wrote: cppcheck detected this on core/cui/source/dialogs/SpellDialog.cxx 1534 nullPointer error Possible null pointer dereference: pNewError 1538 nullPointer error Possible null pointer dereference: pNewError 1555

Re: [Libreoffice] memory leak or tricky LO foo?

2011-10-19 Thread Eike Rathke
Hi Kevin, On Wednesday, 2011-10-05 02:01:24 -0400, Kevin Hunter wrote: In idly reading LO code (trying yet again to spend time wrapping my head around anything in the code base), Great :) I'm puzzled by this snippet (with minor format alteration for email) from

Re: [Libreoffice] [PORTERS HEADS-UP] feature/kill-set_soenv

2011-10-19 Thread Eike Rathke
Hi Bjoern, On Monday, 2011-09-19 20:09:44 +0200, Bjoern Michaelsen wrote: All of this is a sure fire way to drive a newcomer (and even oldtimers) insane. IMHO the final goal has to be that the above process gets as simple as: - calling a perl-script called autogen.sh, to: - call autoconf

Re: [Libreoffice] make check fails in ScFiltersTest

2011-10-24 Thread Eike Rathke
Hi, On Thursday, 2011-10-20 23:53:39 +0200, Markus Mohrhard wrote: Kohei, Eike: Any ideas why our xls import of these cells goes wrong in a windows build. It seems that none of our Linux or mac builds has a problem with this cell import. I'm looking if perhaps my mingw build shows the same

Re: [Libreoffice] [PATCH] Frac function in calc/BASIC

2011-10-24 Thread Eike Rathke
Hi Regina, On Friday, 2011-10-21 13:20:42 +0200, Regina Henschel wrote: For CALC there are some problems. A function FRAC is not defined in ODF1.2 [1]. Markus already gave a hint why we wouldn't even need a FRAC function in Calc as MOD(x,1) does it. However, the naming question remains for

Re: [Libreoffice] IDL hyper / Java long

2011-10-24 Thread Eike Rathke
Hi, On Friday, 2011-10-21 18:37:34 +0200, Stephan Bergmann wrote: As I wrote at https://bugs.freedesktop.org/show_bug.cgi?id=42005#c1, Calc add-ins do not support functions that take or return UNO type hyper. So I think that explains why an add-in using hyper in the .idl file does not

Re: [Libreoffice] IDL hyper / Java long

2011-10-24 Thread Eike Rathke
Hi MarcinGutman, On Saturday, 2011-10-22 00:42:32 +0200, MarcinGutman wrote: Calc add-ins do not support functions that take or return UNO type hyper. .. however, it should work if the .idl file instead uses unsigned hyper ... You omitted some words that slightly change the meaning of

Re: [Libreoffice] [PATCH] Frac function in calc/BASIC

2011-10-25 Thread Eike Rathke
Hi Michael, On Tuesday, 2011-10-25 14:32:14 +0100, Michael Meeks wrote: On Mon, 2011-10-24 at 20:38 +0200, Eike Rathke wrote: However, the naming question remains for future functions not (yet) defined by ODF. Quite. Certainly it should not be ORG.OPENOFFICE.FOO, IMHO it should

Re: [Libreoffice] bug 32826 - Printing in Preview mode causes all sheets to be printed

2011-10-25 Thread Eike Rathke
Hi Kohei, On Tuesday, 2011-10-25 10:55:33 -0400, Kohei Yoshida wrote: However, this one is a bit complex, as we would need to move the flags that tell you which sheets are selected, from ScMarkData to ScDocument (or most likely ScTable) in order for the mentioned code to access this

Re: [Libreoffice] [PATCH] Frac function in calc/BASIC

2011-10-26 Thread Eike Rathke
Hi Thorsten, On Wednesday, 2011-10-26 11:38:21 +0200, Thorsten Behrens wrote: http://wiki.documentfoundation.org/Development/ODF_Implementer_Notes#LibreOffice_ODFF_extensions - would you want to fill in the blanks? Done. As, naturally, there is no OASIS reference for functions not

Re: [Libreoffice] semantics of ScBaseCell* lclCloneCell

2011-10-27 Thread Eike Rathke
Hi Stephan, On Thursday, 2011-10-27 08:49:19 +0200, Stephan Bergmann wrote: On 10/27/2011 07:10 AM, Kevin Hunter wrote: I'm nosing around ScBaseCell in sc/source/core/data/cell.cxx, and I'm curious about the semantics of the function lclCloneCell. Not an sc expert Perfect analysis

Re: [Libreoffice] [REVIEW] fix for fdo#41807 crash with ROW() or COLUMN() in matrix formulas

2011-11-02 Thread Eike Rathke
Hi Markus, On Tuesday, 2011-11-01 22:45:57 +0100, Markus Mohrhard wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?id=cf0dd2113527ba0a601c5c59de7f7f44da161d21 fixes a crash that happens if you use ROW() or COLUMN() in a matrix function. We try to get an entry from an empty mdds

Re: [Libreoffice] Extension dependencies

2011-11-04 Thread Eike Rathke
Hi, On Friday, 2011-11-04 13:02:02 +0100, Thorsten Behrens wrote: I'd tend to give the fine-grained dependencies a try. That won't work in practice, unless those can be (semi-)automatically generated. Experience shows that all programmers are lazy, and seldomly go extra miles. Seconded,

Re: [Libreoffice] [PATCH] make STR_MERGE_NOTEMPTY more understandable

2011-11-09 Thread Eike Rathke
Hi Maxime, On Monday, 2011-11-07 10:58:13 +0100, Maxime de Roucy wrote: I think the STR_MERGE_NOTEMPTY (in sc/source/ui/src/globstr.src ; used in Calc when merging cells) is not very understandable for common users : Should the contents of the hidden cells be moved into the first cell? I

Re: [Libreoffice] [PATCH] make STR_MERGE_NOTEMPTY more understandable

2011-11-10 Thread Eike Rathke
Hi, On Wednesday, 2011-11-09 15:15:33 -0500, Kohei Yoshida wrote: Isn't Should the contents of all cells be concatenated and moved into the merged cell? better ? I like the following better: Do you want to merge the contents of the selected cells into one cell? Clicking 'No' will only

Re: [Libreoffice] [PUSHED][PATCH] Removed some SvStringsSortDtor

2011-11-10 Thread Eike Rathke
Hi Caolán, On Tuesday, 2011-11-08 15:01:53 +, Caolán McNamara wrote: Looking at htmlexp.cxx:1320, pSrcArr is used to lookup for an index of a string, and then the index is applied to pDstArr. In my understanding indices of two arrays are unrelated, because arrays are sorted by their

Re: [Libreoffice] [PUSHED][REVIEW 3-4] Fixing keyboard navigation of range selection in reference mode

2011-11-11 Thread Eike Rathke
Hi Kohei, On Tuesday, 2011-11-08 21:25:39 -0500, Kohei Yoshida wrote: There isn't a formally filed bug for this (either that or there is and I don't know about it), but this one is pretty bad I want this fixed in the stable version. The fix is

Re: [Libreoffice] [PUSHED][PATCH] Re: Easy hack regex compile infinite loop ( bug 41738 )

2011-11-11 Thread Eike Rathke
Hi Karl, On Thursday, 2011-11-10 21:44:33 -0800, Karl Koehler wrote: investigating further I have come to the conclusion that the attached ( and previously inlined ) patch is correct, in the sense that regular expressions of the failing type are now handled correctly. e.g. A[\[:\]]

Re: [Libreoffice] [Libreoffice-commits] .: sc/inc sc/source

2011-11-11 Thread Eike Rathke
Hi Kohei, On Thursday, 2011-11-10 12:49:29 -0800, Kohei Yoshida wrote: commit eaea417bfdf8d06df2b7f2e42c904c32ce77e871 Author: Kohei Yoshida kohei.yosh...@suse.com Date: Thu Nov 10 15:45:53 2011 -0500 Removing the mixed comparison flag, which is no longer needed. This flag

Re: [Libreoffice] [Libreoffice-commits] .: sc/inc sc/source

2011-11-14 Thread Eike Rathke
Hi Kohei, On Friday, 2011-11-11 12:17:21 -0500, Kohei Yoshida wrote: commit eaea417bfdf8d06df2b7f2e42c904c32ce77e871 Removing the mixed comparison flag, which is no longer needed. Isn't that needed for MATCH and ([HV])LOOKUP with mixed data such as 1,2,3,b,c,d when queried for a

Re: [Libreoffice] [PATCH][PLEASE REVIEW] Remove String::Fill() usage

2011-11-14 Thread Eike Rathke
Hi Markus, On Saturday, 2011-11-12 16:11:09 +0100, Markus Mohrhard wrote: This part might be worng: if ( bValue ) -aString.AssignAscii( ### ); -aString.Erase( nLen ); +aString = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( ### )); It is. The ### was

Re: [Libreoffice] Issues important for Japanese users

2011-11-18 Thread Eike Rathke
Hi Fridrich, On Thursday, 2011-11-17 16:49:57 +0100, Fridrich Strba wrote: - Furigana Excel has a Phonetic function that returns transliteration of kanji characters into hiragana. Some kanji characters can have ambiguous transliteration and the default function is returning the most

[Libreoffice] [ANNOUNCE] added possessive genitive case month names, HEADS UP localizers ; -)

2011-11-19 Thread Eike Rathke
Hi, some Slavic languages and Russian and Greek (afaik) use possessive genitive case month names when used in conjunction with the day of month. For this I added support in the i18n framework and number formatter. There's a new optional element GenitiveMonths within the Calendar element of the

[Libreoffice] MinGW cross-compilation fails in i18npool, why?

2011-11-19 Thread Eike Rathke
Hi, Apparently since I added a dependency on the saxparser executable to i18npool/source/localedata/Makefile in localedata_%_invis.cxx : $(realpath $(SRC_ROOT)/i18npool/source/localedata/data)/%.xml saxparser.rdb \ $(OUTDIR_FOR_BUILD)/bin/saxparser$(gb_Executable_EXT) (it was OUTDIR

Re: [Libreoffice] MinGW cross-compilation fails in i18npool, why?

2011-11-20 Thread Eike Rathke
Hi, On Sunday, 2011-11-20 01:41:16 +0100, Eike Rathke wrote: localedata_%_invis.cxx : $(realpath $(SRC_ROOT)/i18npool/source/localedata/data)/%.xml saxparser.rdb \ $(OUTDIR_FOR_BUILD)/bin/saxparser$(gb_Executable_EXT) For the records, gb_Executable_EXT_for_build does it. Thanks

Re: [Libreoffice] [libreoffice-l10n] [ANNOUNCE] added possessive genitive case month names, HEADS UP localizers ; -)

2011-11-21 Thread Eike Rathke
Hi Yury, On Saturday, 2011-11-19 21:19:43 +0200, Yury Tarasievich wrote: Now, where do we get a template for the new format of locale? Um.. what template? There are the i18npool/source/localedata/data/*.xml files (see also

Re: [Libreoffice] .: bin/get-bugzilla-attachments-by-mimetype

2011-11-21 Thread Eike Rathke
Hi Markus, On Monday, 2011-11-21 12:40:11 +0100, Markus Mohrhard wrote: Not every document is crash free. We have 15 documents that either froze during the import or crashed calc. I have sent the list to Eike and Kohei and have already fixed two crashs. If anyone else is interested in the

Re: [Libreoffice] .: bin/get-bugzilla-attachments-by-mimetype

2011-11-21 Thread Eike Rathke
Hi Markus, On Monday, 2011-11-21 13:14:27 +0100, Markus Mohrhard wrote: If everyone is fine with the idea of putting the informatio in bugzilla I'll do that later today. Of course, yes, that's fine, thanks. Eike -- LibreOffice Calc developer. Number formatter stricken i18n

Re: [Libreoffice] [libreoffice-l10n] [ANNOUNCE] added possessive genitive case month names, HEADS UP localizers ; -)

2011-11-21 Thread Eike Rathke
Hi Sérgio, On Monday, 2011-11-21 14:56:18 +, Sérgio Marques wrote: I need to change case from months name due to new Portuguese settlement for spellcheck. Can I get file mentioned, change case and send it to You for commit? Yes, that's fine, just be sure you use the /plain/ file for

Re: [Libreoffice] Assertions and Logging

2011-11-21 Thread Eike Rathke
Hi Stephan, On Monday, 2011-11-21 17:53:42 +0100, Stephan Bergmann wrote: On 11/21/2011 04:42 PM, Caolán McNamara wrote: On Mon, 2011-11-21 at 14:30 +0100, Stephan Bergmann wrote: SAL_INFO/WARN just go to stderr for now. What should work to see them even for a gui soffice.exe is to add

Re: [Libreoffice] [PATCH] i18n corrections for pt-PT

2011-11-22 Thread Eike Rathke
Hi Olivier, On Tuesday, 2011-11-22 11:29:11 -0200, Olivier Hallot wrote: Patch to correct month names (case) and Era for pt-PT. The patch is broken, it shredded the utf-8 encoding and all non-ascii character are question marks. Either your editor didn't save that properly or your mailer

Re: [Libreoffice] [PUSHED][PATCH] remove NfShCurrencyEntries and NfShCurrencyEntryPtr types

2011-11-22 Thread Eike Rathke
Hi Daniel, On Monday, 2011-11-21 23:20:02 +0100, Daniel Di Marco wrote: attached is a simple patch to remove 2 obsolete datatypes. Thanks, good one. Pushed to master http://cgit.freedesktop.org/libreoffice/core/commit/?id=33a8ac0750d4ee7800b9faccdee3fffb850a04b1 I didn't find your license

Re: [Libreoffice] Newbie question: i18n numeric formats

2011-11-22 Thread Eike Rathke
Hi Olivier, On Tuesday, 2011-11-22 16:23:50 -0200, Olivier Hallot wrote: I found that the number of pre-defined numeric formats could be improved to handle telephone number, postal codes, social security numbers, and other locale numeric formats. My question is: is it OK that I patch the

Re: [Libreoffice] [PUSHED][PATCH] i18n corrections for pt-PT

2011-11-23 Thread Eike Rathke
Hi Olivier, On Tuesday, 2011-11-22 14:29:56 -0200, Olivier Hallot wrote: I will provide anothe patch. Please wait. Not necessary anymore. I resolved that by changing the attachment's Conten-Type charset to utf-8 before saving, in fact the data was correct, but declared wrong. However, these

Re: [Libreoffice] [PUSHED][PATCH] remove NfShCurrencyEntries and NfShCurrencyEntryPtr types

2011-11-23 Thread Eike Rathke
Hi Daniel, On Wednesday, 2011-11-23 13:58:56 +0100, Daniel Di Marco wrote: thanks. All my patches are contributed under LGPLv3+ and MPL 1.1 licenses. Great, would you like to add yourself to https://wiki.documentfoundation.org/Development/Developers and for the license reference use

Re: [Libreoffice] [PUSHED][PATCH] i18n corrections for pt-PT

2011-11-23 Thread Eike Rathke
Hi Olivier, On Wednesday, 2011-11-23 12:39:32 -0200, Olivier Hallot wrote: You must have received a file from Sergio Marques, of Portugal. Yes, I did. I was in touch with him and the correct data is in the file he sent you. Can you revert my patch and apply his? I should had read your

Re: [Libreoffice] [PATCH] fdo#42286, do not shrink the selected area

2011-11-25 Thread Eike Rathke
Hi Pierre-André, On Thursday, 2011-11-24 22:47:56 +0100, Pierre-André Jacquod wrote: here attached an new patch (hopefully wiser) to solve the mentioned bug. This ensure that the call to ExtendDataArea does as commented in the code sc/source/core/tool/dbdata.cxx : // Extend the DB area to

Re: [Libreoffice] WaE on vcl because of qt4 module

2011-11-25 Thread Eike Rathke
Hi julien2412, On Friday, 2011-11-25 10:56:42 -0800, julien2412 wrote: By compiling vcl module (Debian testing x86-32, WaE, debug and symbols enabled), I've got this : In file included from /usr/include/qt4/QtCore/qdatastream.h:45:0, from /usr/include/qt4/QtCore/qpair.h:45,

[Libreoffice] solenv/bin/create-ids without outpaths

2011-11-25 Thread Eike Rathke
Hi, I should mention that I changed solenv/bin/create-ids such that it doesn't include */$INPATH/inc anymore, which also affects solver/$INPATH/inc, as usually one is interested in the real source and not also duplicated built and delivered stuff. If you want the old behavior back then use the

[Libreoffice] [PUSHED] ru-RU genitive case month names (was: [libreoffice-l10n] [ANNOUNCE] added possessive genitive case month names, HEADS UP localizers ; -))

2011-11-28 Thread Eike Rathke
Hi Serg, On Monday, 2011-11-28 13:45:11 +0400, Serg Bormant wrote: Here is Russian GenitiveMonths patch. Thanks, pushed to master http://cgit.freedesktop.org/libreoffice/core/commit/?id=c01ce861aced958302087117a5c5019d420b9d52 Cc-ed to e-mail. Only received in personal mail, list strips

Re: [Libreoffice] [PATCH] fdo#42286, do not shrink the selected area

2011-11-28 Thread Eike Rathke
Hi Pierre-André, On Sunday, 2011-11-27 20:23:33 +0100, Pierre-André Jacquod wrote: I wouldn't say it's wrong unless I checked the original intention behind that code when GetDataArea() is called with bIncludeOld=false, maybe it's just the call in ExtendDataArea() that should pass true

Re: [Libreoffice] numbers auto format as date

2011-11-28 Thread Eike Rathke
Hi Lior, On Sunday, 2011-11-27 11:32:47 +0200, Lior Kaplan wrote: I'd like to inquire about a group of related bugs which are all due to calc's auto format of numbers to date, which in some cases also changes the number itself. Do we target these for the 3.5 life time ? No, but I'm about to

Re: [Libreoffice] I need some advice to fix fdo#40363

2011-11-28 Thread Eike Rathke
Hi Jean-Baptiste, On Monday, 2011-11-28 13:43:51 +0100, Jean-Baptiste Faure wrote: The bug described in fdo#40363 may occur if you make a typo when type some dates in Calc. Thanks for investigating, I'll dig into that. If I modify Date::IsValid so that only dates strictly between 1582-10-05

Re: [Libreoffice] [PATCH] Fix for dialog Manage Breakpoints crash

2011-11-28 Thread Eike Rathke
Hi Niklas, On Monday, 2011-11-28 12:27:16 +0100, Niklas Johansson wrote: In worst case it makes the program crash. This fix, stores the values. I'm not that experienced with C++ so could someone have a second look at this there might very well be a cleaner way of writing it. Good find! I

Re: [Libreoffice] [PUSHED] Translation of German comments in /svx/source/svdraw

2011-11-29 Thread Eike Rathke
Hi Stefan, On Tuesday, 2011-11-29 18:17:44 +0100, Stefan Knorr (Astron) wrote: comments, but the original author seems to have used symbols to illustrate his explanations. The meaning of the symbols, however, has seemingly been completely lost (using search and replace they all seem to come

Re: [Libreoffice] I need some advice to fix fdo#40363

2011-11-30 Thread Eike Rathke
Hi Jean-Baptiste, On Tuesday, 2011-11-29 00:35:46 +0100, Eike Rathke wrote: I do not understand why every dates before 1582-10-15 should not be valid when only dates from 1582-10-05 to 1582-10-14 do not exist due to the switch from julian calendar to gregorian calendar. Well, the Date

Re: [Libreoffice] [PUSHED] ru-RU genitive case month names

2011-11-30 Thread Eike Rathke
Hi Serg, On Wednesday, 2011-11-30 16:16:04 +0400, Serg Bormant wrote: Surely, I confirm my this and further contributions to LibreOffice project are under LGPLv3+ and MPL 1.1. Great, thanks! Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key

Re: [Libreoffice] [PUSHED][PATCH] Fix for dialog Manage Breakpoints crash

2011-11-30 Thread Eike Rathke
Hi Niklas, On Tuesday, 2011-11-29 09:50:26 +0100, Niklas Johansson wrote: - rList.reset(); + rList.clear(); Please check if that fixes the problem. That fixes the problem, and definitely looks like a cleaner solution. Do you create the patch or should I create a new one? I

Re: [Libreoffice] I need some advice to fix fdo#40363

2011-12-01 Thread Eike Rathke
Hi Michael, On Wednesday, 2011-11-30 18:45:31 +0100, Michael Stahl wrote: On 30/11/11 12:10, Eike Rathke wrote: Also fixed the misrepresentation of years1000 with less than 4 digits we did that? oops. i didn't know that... Yup.. which made we wonder why we have two implementations

Re: [Libreoffice] minutes of tech. steering call ...

2011-12-01 Thread Eike Rathke
Hi Michael, On Thursday, 2011-12-01 16:21:09 +, Michael Meeks wrote: * DateTime default constructor fix (Eike) + looses ~500 places to call gettimeofday by mistake umm.. would be nice, but.. seems that didn't come across correctly. There are about 100 places out of 400, I'll come up

Re: [Libreoffice] [PATCH 01/11] Replace ScChangeTrackMsgStack with std::stack ScChangeTrackMsgInfo*

2011-12-01 Thread Eike Rathke
Hi Marcel, On Thursday, 2011-12-01 11:08:40 +0100, Marcel Metz wrote: this is my first patch series to the lo project. Wow, large and great one :-) I'll inspect details later or tomorrow, from a first glance it looks good. In the mean time, as this is your first contribution to the code base,

Re: [Libreoffice] product-name in title bar of the office ?

2011-12-01 Thread Eike Rathke
Hi, On Wednesday, 2011-11-30 23:23:11 +0100, Regina Henschel wrote: Up until recently I could change the product-name in the title bar of the window via this file: share/registry/brand.xcd prop oooname It is in share/registry/main.xcd component-data oor:name=Setup node oor:name=Product

[Libreoffice] [ANNOUNCE] Date, Time and DateTime default ctors are gone

2011-12-01 Thread Eike Rathke
Hi, To get rid of unnecessary calls to quite expensive system's get localtime due to the mad implementation of the Date,Time,DateTime default ctors that call localtime_r() (*ix,Linux) or GetLocalTime() (Windows) each I reworked the entire code base. Date,Time,DateTime default ctors are now dead.

Re: [Libreoffice] [PATCH 01/11] Replace ScChangeTrackMsgStack with std::stack ScChangeTrackMsgInfo*

2011-12-01 Thread Eike Rathke
Hi Marcel, On Thursday, 2011-12-01 21:21:28 +0100, Marcel Metz wrote: I provide this and all future contributions to the libreoffice project under the terms of the LGPLv3+ and MPL 1.1 license. Great, thanks. Eike -- LibreOffice Calc developer. Number formatter stricken i18n

Re: [Libreoffice] I need some advice to fix fdo#40363

2011-12-01 Thread Eike Rathke
Hi Michael, On Thursday, 2011-12-01 21:12:48 +0100, Michael Stahl wrote: I don't insist on keeping the ^+ thing in, maybe it's better to remove that part and check for W3C compliance. I'm unbiased there. hmm... even ODF 1.0 referred to XMLSchema; i've taken a quick look at the OOoXML

Re: [Libreoffice] [PATCH] fdo#42286, do not shrink the selected area (2)

2011-12-05 Thread Eike Rathke
Hi Pierre-André, On Sunday, 2011-12-04 22:25:51 +0100, Pierre-André Jacquod wrote: The first one is my favorite: 0001-fdo42286-strict-use-of-GetDataArea-and-strict-extens.patch it extends the area down. It takes into account the cells strictly below the already selected area. It never

Re: [Libreoffice] [PATCH 01/11] Replace ScChangeTrackMsgStack with std::stack ScChangeTrackMsgInfo*

2011-12-05 Thread Eike Rathke
Hi Marcel, On Thursday, 2011-12-01 11:08:40 +0100, Marcel Metz wrote: this is my first patch series to the lo project. It replaces the use of the tools Stack class and corresponding macros with the std::stack as suggested in in bug #39445 [1] (an easy hack). As already mentioned on IRC on

Re: [Libreoffice] [PATCH 01/11] Replace ScChangeTrackMsgStack with std::stack ScChangeTrackMsgInfo*

2011-12-05 Thread Eike Rathke
Hi Michael, On Monday, 2011-12-05 19:07:35 +0100, Michael Stahl wrote: Would be great if you could complete the work on binfilter. clarifying remark: please don't refactor binfilter, it is not worth the effort! don't replace Stack with std::stack in binfilter, but instead just move the

Re: [Libreoffice] [PATCH 01/11] Replace ScChangeTrackMsgStack with std::stack ScChangeTrackMsgInfo*

2011-12-05 Thread Eike Rathke
Hi Marcel, On Thursday, 2011-12-01 11:08:40 +0100, Marcel Metz wrote: this is my first patch series to the lo project. It replaces the use of the tools Stack class and corresponding macros with the std::stack as suggested in in bug #39445 [1] (an easy hack). Yay! class Stack is gone from

Re: [Libreoffice] [PUSHED][PATCH 01/11] Replace ScChangeTrackMsgStack with std::stack ScChangeTrackMsgInfo*

2011-12-05 Thread Eike Rathke
Hi, On Monday, 2011-12-05 23:05:33 +0100, Eike Rathke wrote: Good stuff, pushed to master with only a few corrections: And now also marked as [PUSHED] in the subject ... Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60

Re: [Libreoffice] [PUSHED][PATCH] Removed unnessecary tools/table.hxx includes.

2011-12-06 Thread Eike Rathke
Hi Marcel, On Tuesday, 2011-12-06 15:25:35 +0100, Marcel Metz wrote: As the subject already mentions this patch removes unnessecary header includes for the tools table implementation. Thanks, pushed to master

Re: [Libreoffice] [PUSHED][PATCH] Removed unnessecary tools/table.hxx includes.

2011-12-06 Thread Eike Rathke
Hi Marcel, On Tuesday, 2011-12-06 17:19:05 +0100, Eike Rathke wrote: I recommend to install GNU id-utils Just added to the wiki: http://wiki.documentfoundation.org/Development/GNU_ID-utils http://wiki.documentfoundation.org/Development/Vim#GNU_ID-utils Eike -- LibreOffice Calc developer

Re: [Libreoffice] [PATCH 05/11] Replace SmNodeStack with std::stack SmNode*

2011-12-07 Thread Eike Rathke
Hi, On Wednesday, 2011-12-07 00:28:11 +0100, Stephan Bergmann wrote: i.e., at SmNode *pNode = m_aNodeStack.top() in SmParser::Expression(), where m_aNodeStack is empty. It *looks* to me that the following happens: The stack is rightfully empty, but the old implementation of tools' stack

Re: [Libreoffice] [PATCH 05/11] Replace SmNodeStack with std::stack SmNode*

2011-12-07 Thread Eike Rathke
Hi, On Wednesday, 2011-12-07 14:34:02 +0100, Eike Rathke wrote: who knows which other code depended on this magnificent misfeature of the old stack implementation, too... I'm inspecting that and will fix. http://cgit.freedesktop.org/libreoffice/core/commit/?id

Re: [Libreoffice] 3.6 features page ...

2011-12-09 Thread Eike Rathke
Hi, On Thursday, 2011-12-08 10:27:24 +, Michael Meeks wrote: On Wed, 2011-12-07 at 22:07 -0500, August Sodora wrote: I have removed the testtool and am listing the relevant commits here (http://wiki.documentfoundation.org/User:Augsod) for future reference. Nice :-) which

Re: [Libreoffice] What is bibisect? And what is it doing in my office?

2011-12-09 Thread Eike Rathke
Hi Bjoern, On Friday, 2011-12-09 14:59:53 +0100, Bjoern Michaelsen wrote: bibisect stands for binary bisect Way cool! Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD

Re: [Libreoffice] End of the line for 3.3 family and regressions

2011-12-09 Thread Eike Rathke
Hi Pedro, On Friday, 2011-12-09 20:34:34 +, Pedro Lino wrote: I urge everybody to make sure that EVERY regression detected from 3.3.x to 3.4.x is fixed/added to the 3.4 branch E.g. A bug fix such as this https://bugs.freedesktop.org/show_bug.cgi?id=42958 needs to be cherry picked to

Re: [Libreoffice] [PATCH] fix for crash in math.cxx for std::numeric_limitsint::min

2011-12-13 Thread Eike Rathke
Hi Markus, On Tuesday, 2011-12-13 00:15:08 +0100, Markus Mohrhard wrote: the attached patch fixes a crash in our rtl::math lib. For std::numeric_limitsint::min() -nExp is the same as nExp and therefore we would be in the first case and try to access a non existing element. Good catch. As

[Libreoffice] Dangling symlinks (was: make dev-install hangs)

2011-12-14 Thread Eike Rathke
Hi, On Wednesday, 2011-12-14 11:53:44 +0100, Miklos Vajna wrote: ctags: Warning: cannot open source file test/user-template/user/config/images_tango.zip : No such file or directory ctags: Warning: cannot open source file test/user-template/user/config/images_oxygen.zip : No such file or

Re: [Libreoffice] libicudata ICU data info

2011-12-16 Thread Eike Rathke
Hi, On Friday, 2011-12-16 12:07:53 +, Caolán McNamara wrote: Anyway, point is that savings are worthwhile for universal Linux builds too I guess. Yeah, right. Mike, are you willing to invest some time and effort in this? Eike -- LibreOffice Calc developer. Number formatter stricken

Re: [Libreoffice] Notifications between different SfxObjectShells

2011-12-19 Thread Eike Rathke
Hi Markus, On Monday, 2011-12-19 03:53:57 +0100, Markus Mohrhard wrote: I'm trying to improve calc's copy behavior but I'm a bit stuck with the last step. I need to get a notification if another document is being saved because I may need to adjust the reference to this document. I found

Re: [Libreoffice] [PATCH] Fix fdo#42783 get rid of CPU define/build system variable

2011-12-21 Thread Eike Rathke
Hi, On Tuesday, 2011-12-20 17:46:22 -0600, Norbert Thiebaud wrote: IMHO (other might disagree), we should get rid of these opaque names in the long run anyway. INPATH and OUTPATH should only be build or host. Sure, but then stuff like rm -fr */$INPATH may end-up having unexpected

Re: [Libreoffice] [PATCH] fdo#38832 Replace ScChangeActionTable with std::map.

2011-12-21 Thread Eike Rathke
Hi Marcel, On Wednesday, 2011-12-21 16:18:46 +0100, Marcel Metz wrote: I've tested the patch with 'make check', but would like to point out that the reviewer should take special care of the change in 'sc/source/core/tool/chgtrack.cxx:3140-3160'. From my understanding of the code the tools

Re: [Libreoffice] [PUSHED] Re: [PATCH] fdo#38832 Replace ScChangeActionTable with std::map.

2011-12-21 Thread Eike Rathke
Hi Michael, On Wednesday, 2011-12-21 20:27:21 +0100, Michael Stahl wrote: and in ScChangeTrack::Reject, the old code iterated from end to start (dunno if that is important there, but why not use a reverse_iterator) Yes, rejections must happen in reverse order there, thanks for catching.

Re: [Libreoffice] [PATCH] fdo#38832 Replace ScChangeActionTable with std::map.

2011-12-21 Thread Eike Rathke
Hi Marcel, On Wednesday, 2011-12-21 21:25:19 +0100, Marcel Metz wrote: Btw, did you check if Calc changetracking and accepting/rejecting actions still works? Well, I assumed that this was cached by the `make check` tests but If you're asking like that I think this isn't sufficient,

Re: [Libreoffice] [PUSHED][PATCH] c1db721 ScChangeActionTable conversion: Yet another correction.

2011-12-22 Thread Eike Rathke
Hi Marcel, On Thursday, 2011-12-22 18:52:02 +0100, Marcel Metz wrote: after testing the change tracking feature in calc I've found yet another bug in the UI. The attached patch fixes the bug in question. Muchas gracias ... pushed to master

Re: [Libreoffice] product-name in title bar of the office ?

2012-01-02 Thread Eike Rathke
Hi Cor, On Wednesday, 2011-12-28 17:18:02 +0100, Cor Nouws wrote: Up until recently I could change the product-name in the title bar of the window via this file: share/registry/brand.xcd prop oooname It is in share/registry/main.xcd component-data oor:name=Setup node oor:name=Product

Re: [Libreoffice] [PATCH] Easyhack fdo#38831 - Convert some SvStrings to std::vector

2012-01-02 Thread Eike Rathke
Hi Brad, On Wednesday, 2011-12-28 16:47:17 +1300, Brad Sowden wrote: Any comments on the size_t changes/best practice welcomed. diff --git a/sw/source/ui/dochdl/gloshdl.cxx b/sw/source/ui/dochdl/gloshdl.cxx @@ -138,13 +136,13 @@ void SwGlossaryHdl::SetCurGroup(const String rGrp, sal_Bool

Re: [Libreoffice] [PATCH] Replace ByteString with rtl::OString

2012-01-02 Thread Eike Rathke
Hi Chr., On Monday, 2012-01-02 22:05:15 +0100, Chr. Rossmanith wrote: could someone please review this small patch and give feed back. Sure. diff --git a/vcl/generic/print/genprnpsp.cxx b/vcl/generic/print/genprnpsp.cxx [...] -static String getPdfDir( const PrinterInfo rInfo ) +static

Re: [Libreoffice] [REVIEW] quick patch for extensions ole part

2012-01-03 Thread Eike Rathke
Hi julien2412, On Thursday, 2011-12-29 08:38:31 -0800, julien2412 wrote: Another Same expression on both sides of '||' detected by cppcheck. I supposed this patch but I made a research of INVOKE_PROPERTYPUT on the file, either it's not the only location where INVOKE_PROPERTYPUTREF should

Re: [Libreoffice] [REVIEW] Patch for Same expression on both sides of '' in basegfx module

2012-01-03 Thread Eike Rathke
Hi julien2412, On Wednesday, 2011-12-28 13:13:43 -0800, julien2412 wrote: On cppcheck report, there were 2 Same expression on both sides of '' on b2dpolypolygoncutter.cxx I don't know how this part works so I recognize it's just guessing. diff --git

Re: [Libreoffice] Build Failure: Error in module icu

2012-01-03 Thread Eike Rathke
Hi Ashwini, On Monday, 2012-01-02 22:37:04 +0530, Ashwini Oruganti wrote: My LibreOffice build is failing repeatedly and the error seems to be in the module icu. Strange.. log for /media/Ash/zcodes/zzlibre-office/git/libo/icu /media/... makes me wonder what medium Ash is and the file

Re: [Libreoffice] [REVIEW] Easy patch on l10ntools

2012-01-03 Thread Eike Rathke
Hi Andras, On Tuesday, 2012-01-03 20:09:42 +0100, Andras Timar wrote: diff --git a/l10ntools/source/export.cxx b/l10ntools/source/export.cxx @@ -1475,7 +1475,7 @@ void Export::InsertListEntry( const ByteString rText, const ByteString rLine )              (*pCurEntry)[ SOURCE_LANGUAGE

Re: [Libreoffice] What are the criteria to nominate bugs as most annoying bug?

2012-01-04 Thread Eike Rathke
Hi Winfried, On Wednesday, 2012-01-04 11:44:25 +0100, Winfried Donkers wrote: https://bugs.freedesktop.org/show_bug.cgi?id=37987 https://bugs.freedesktop.org/show_bug.cgi?id=44383 See my comments there. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.

Re: [Libreoffice] [Patch] [Review 3.5 - Late Feature] Improved copying between different calc documents

2012-01-04 Thread Eike Rathke
Hi Markus, On Wednesday, 2012-01-04 17:04:48 +0100, Markus Mohrhard wrote: I propose this patch as a late feature. We talked about that before Christmas (actually I thought that would be already in 3-5 now), and yes, this feature makes sense when copying between documents. So, approval from

Re: [Libreoffice] Introducing Grande Latte

2012-01-04 Thread Eike Rathke
Hi Bjoern, On Wednesday, 2012-01-04 19:38:53 +0100, Bjoern Michaelsen wrote: Grande Latte is a small and standalone ... nominated for the best l10n-troll of the year 2012. Also: We should have codenames for our LibreOffice releases. Such as Latte Plus ? ;-) Eike -- LibreOffice Calc

Re: [Libreoffice] [REVIEWED] [PUSHED 3-4] fix for fdo#44442, crash in ScInterpreter::GetDBParam with specific document

2012-01-09 Thread Eike Rathke
Hi Markus, On Sunday, 2012-01-08 21:19:13 +0100, Markus Mohrhard wrote: In case this needs to go to the -3-4-5 branch, we'll need 2 more sign-off's. I think that 3-4-5 is through and it is not a high priority patch. I think it only happens in rare circumstances. However, in case we wanted

Re: [Libreoffice] embedded nulls in SvStream::ReadLine

2012-01-16 Thread Eike Rathke
Hi Caolán, On Monday, 2012-01-16 10:45:40 +, Caolán McNamara wrote: caolanm-erack:, from erAck 26.02.01: Old behavior was no special treatment of '\0'... I presume you noticed this weirdness ages ago as well in converting it from += to Append. What do you think, worth syncing ReadLine

Re: [Libreoffice] [REVIEW][3-4] date change regression fdo#44385

2012-01-16 Thread Eike Rathke
Hi Noel, On Friday, 2012-01-13 09:51:33 +, Noel Power wrote: this change ( the variant ) is what is on master, here the intention is as Andrew pointed out ( in a previous mail discussing the regression ) to allow operations on date types return dates ( regardless of the operation )

Re: [Libreoffice] [PUSHED][REVIEW] pls add this to 3.4.6 Re: [Bug 39118] Charts with anchor to cell do not update automatically

2012-01-16 Thread Eike Rathke
Hi, On Friday, 2012-01-13 23:39:43 +0100, Cor Nouws wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?id=681e8b1e43c1949871463934fa92396c00110270 Pushed to 3-4 with my sign-off: 99484e05a48f6253e1ff4fd2e8cc80cdbe5d Eike -- LibreOffice Calc developer. Number formatter

Re: [Libreoffice] [LibreOffice] [PATCH] DateAcceptancePattern and PartitiveMonths for Czech language

2012-01-16 Thread Eike Rathke
Hi Da'angh, On Sunday, 2012-01-15 11:02:20 +0100, Da'angh Khagaroth wrote: Attached patch adds DateAcceptancePatterns and PartitiveMonths for Czech language. Thanks, pushed to master http://cgit.freedesktop.org/libreoffice/core/commit/?id=2955fc0c3ef3c15b5fdad43969402503ed439336 and the

Re: [Libreoffice] [LibreOffice] [PUSHED][PATCH] DateAcceptancePattern and PartitiveMonths for Czech language

2012-01-16 Thread Eike Rathke
forgot PUSHED in subject -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpRLtRda6TeH.pgp Description: PGP signature ___ LibreOffice mailing

Re: [Libreoffice] [REVIEW][3-4] date change regression fdo#44385

2012-01-16 Thread Eike Rathke
Hi Noel, On Monday, 2012-01-16 16:11:14 +, Noel Power wrote: Not every operation on date types should return a date, I have to admit I was swayed by Andrew's point that letting the operations just return Dates seems more consistent.Also it would seem to me subtraction should at least

Re: [Libreoffice] [PUSHED] Re: [PATCH] Replaced SAL_INFO with SAL_WARN. Was: [PATCH] Replaced DBG_ERRORFILE with SAL_INFO.

2012-01-18 Thread Eike Rathke
Hi Michael, On Tuesday, 2012-01-17 23:34:22 +0100, Michael Stahl wrote: thanks for the patches, pushed the whole lot. You were faster than me building over night ... just one nitpick, it's i18n not l18n ;-)

Re: [Libreoffice] Icons in Specialized class ListBox

2012-01-18 Thread Eike Rathke
Hi Julien, On Wednesday, 2012-01-18 16:17:32 +0100, Julien Levesy wrote: I'm working on the file picker dialog. I would like to add a list of places as those we can see on most common file pickers (bookmarks on the left of the dialog). In order to display these places, I use specialization

Re: [Libreoffice] [PUSHED][PATCH] Removed formula::FormulaCompiler::IsMatrixFunction() const listed in unusedcode.easy

2012-01-19 Thread Eike Rathke
Hi Mariusz, On Thursday, 2012-01-19 00:15:07 +0100, Mariusz Dykierek wrote: Code is contributed under the LGPLv3+ / MPL Thanks, seen pushed with http://cgit.freedesktop.org/libreoffice/core/commit/?id=d93536e52943c910936504e531956f04d9c0503f But please add the [PATCH] tag to the subject of

Re: [Libreoffice] [PUSHED][PATCH] Removed Window::GetFullscreenSpriteCanvas listed in unusedcode.easy

2012-01-19 Thread Eike Rathke
Hi Mariusz, Found already pushed with http://cgit.freedesktop.org/libreoffice/core/commit/?id=105546f7f11ccee50f8066bfb7c753fabb177fc8 Thanks Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073

Re: [Libreoffice] [PATCH] Remove unused code

2012-01-20 Thread Eike Rathke
Hi Michael, On Friday, 2012-01-20 21:57:25 +0100, Michael Stahl wrote: -VclEventListeners2::~VclEventListeners2() -{ -} i'm not sure this is right; if a destructor of a class is unused, but its other methods are used, then that usually indicates a memory leak: the destructor is never

Re: [Libreoffice] [PUSHED][PATCH] Remove unused code

2012-01-20 Thread Eike Rathke
Hi, On Friday, 2012-01-20 21:53:57 +0100, Michael Stahl wrote: thanks Santiago for the patch, pushed: Marking thread [PUSHED] Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD

[Libreoffice] [REVIEW 3-4] resolve fdo#43725 crash

2012-01-20 Thread Eike Rathke
Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD From: Eike Rathke er...@redhat.com Subject: [PATCH] Resolves fdo#43725 crash on saving a file Date: Sat, 21 Jan 2012 01:15:02 +0100

  1   2   3   4   5   6   7   8   9   10   >