[Libreoffice] [Patch] allow one anonymous db range per sheet in calc

2011-03-21 Thread Markus Mohrhard
Hi, this patch allows one anonymous db range per sheet instead of one per document. There are still some places the old anonymous db range is used, but I#m not quite sure whether i should change these. Additionally it allows one autofilter per sheet. I'd appreciate a better solution for generati

Re: [Libreoffice] [Patch] allow one anonymous db range per sheet in calc

2011-03-21 Thread Markus Mohrhard
Ok, thanks for your advice. I will rework it but suggest that the static method will be placed in ScDBCollection. But there is then there is the question whether an Undo should undo the last change in the active sheet or undo the last change in any sheet. Note that ,as I see it, this will only af

Re: [Libreoffice] [Patch] allow one anonymous db range per sheet in calc

2011-03-22 Thread Markus Mohrhard
Hello, so I have reworked it. I haven't reworked the import and export as these affect some areas I don't fully understand. Patch is under LGPLv3+/MPL. Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/m

Re: [Libreoffice] [Patch] allow one anonymous db range per sheet in calc

2011-03-22 Thread Markus Mohrhard
This time with the patch. Sry. 2011/3/22 Markus Mohrhard > Hello, > > so I have reworked it. I haven't reworked the import and export as these > affect some areas I don't fully understand. > > Patch is under LGPLv3+/MPL. > > Markus > 0002-support-for

Re: [Libreoffice] [Patch] allow one anonymous db range per sheet in calc

2011-03-24 Thread Markus Mohrhard
oint 2011/3/22 Kohei Yoshida > On Tue, 2011-03-22 at 19:59 +0100, Markus Mohrhard wrote: > > This time with the patch. Sry. > > > > 2011/3/22 Markus Mohrhard > > Hello, > > > > > > > > so I have reworked it. I haven't rework

Re: [Libreoffice] Patch for supporting one autofilter per sheet

2011-03-30 Thread Markus Mohrhard
2011/3/30 Kohei Yoshida > > I also would like to confirm that he is submitting this patch under > LGPLv3+/MPL dual license. Markus, could you give us a quick > confirmation? > > Yes the patch is of course under LGPLv3+/MPL. Markus ___ LibreOffice mai

[Libreoffice] EasyHack: VBA support add support for Worksheets.Copy

2011-04-05 Thread Markus Mohrhard
Hello, I'm currently working on this EasyHack, too. And after some talk to Noel it seems it isn't a good point start as we have some problems at the moment with the uno api there. The ScVbaWorkbook, ScVbaWorksheets and ScVbaWorksheet need some rework before one can and the support for the copy me

Re: [Libreoffice] EasyHack: VBA support add support for Worksheets.Copy

2011-04-05 Thread Markus Mohrhard
No it's ok. And i think I got a clue what I must do. My mail was a response to another mail, where someone wanted to start developing Libo with this EasyHack because I forgot to notice it in the wiki that I work on it. Markus 2011/4/5 Noel Power > On 05/04/11 14:18, Michael Meeks wrote: > >> H

[Libreoffice] [Patch] Removed old conversions, Changed to XUnoTunnel

2011-04-07 Thread Markus Mohrhard
Hello, a patch for a bug in the calc vba support. Several methods used an old conversion that crashed LibO when being used. Patch is under LGPLv3+/MPL. In might be necessary to run a make in the top level directory. Sc,vbahelper, basic and oovbaapi were not enough for me. It fails to convert to

[Libreoffice] [Patch]Add method Copy to ScVbaWorksheets

2011-04-07 Thread Markus Mohrhard
Hello, here the patch for the EasyHack: http://wiki.documentfoundation.org/Development/Easy_Hacks#VBA_support_add_support_for_Worksheets.Copy or Bug: https://bugs.freedesktop.org/show_bug.cgi?id=34763 . It needs the patch from this afternoon to work correctly. Patch is under LGPLv3+/MPL. Rega

Re: [Libreoffice] [Patch]Add method Copy to ScVbaWorksheets

2011-04-08 Thread Markus Mohrhard
Hello Noel, > starting with a workbook with the following sheets 'sheet1', 'sheet2' and > 'sheet3' > and trying a macro like: > > sub test >worksheets.copy after:=worksheets(2) > end sub > > results in the following sheets in the workbook 'sheet1', 'sheet2', > 'sheet1_2', 'sheet2_2', 'sheet1_

Re: [Libreoffice] How to create get an XWorksheet from a XSpreadsheet?

2011-04-14 Thread Markus Mohrhard
e the problem. If you can give me any hints why this won't work I will try again on the conversion 2011/4/14 Noel Power > Hi Markus > > On 14/04/11 00:49, Markus Mohrhard wrote: > >> Hello, >> >> I have reworked most of the Code but have now the problem t

Re: [Libreoffice] How to create get an XWorksheet from a XSpreadsheet?

2011-04-14 Thread Markus Mohrhard
And again with the patches. 2011/4/15 Markus Mohrhard > Hi Noel, > > here is the patch without the conversion from XSpreadsheet to XWorksheet. > > I found some nice Code in ScVbaWorkbook::getActiveSheet() where nearly the > same thing was done. But the following attempt didn&#

Re: [Libreoffice] [PUSHED] How to create get an XWorksheet from a XSpreadsheet?

2011-04-16 Thread Markus Mohrhard
Hello Noel, I have found the reason why setUpDocumentModules won't work correctly with the new method. It seems that the method will only work when the name and the code name of a ScTable are the same. I have worked with a document where this is not the case and then XNamedAccess->getByName(String

[Libreoffice] [Patch] Make ScVbaWorksheet work with sheet local DBRanges

2011-04-21 Thread Markus Mohrhard
Hello, here a short patch that reworks the ScVbaWorksheet::getAutoFilterMode/setAutoFilterMode methods. It now works with the new sheet local DB ranges, which are no longer available through UNO API. Additionally I changed those methods that they my no longer manipulate named DB ranges because Ex

Re: [Libreoffice] [Patch] Make ScVbaWorksheet work with sheet local DBRanges

2011-04-22 Thread Markus Mohrhard
his check. Only the check if(pDBData) is important in this context. Regards, Markus 2011/4/22 Kohei Yoshida > On Thu, 2011-04-21 at 22:34 +0200, Markus Mohrhard wrote: > > Hello, > > > > here a short patch that reworks the > > ScVbaWorksheet::getAutoFilterMode/setAutoFil

[Libreoffice] [Patch] Excel Import of unnamed DB Data

2011-04-25 Thread Markus Mohrhard
Hello, this patch makes the excel binary import work with the unnamed db data. Patch is under LGPLv3+/MPL. Regards, Markus 0001-make-excel-binary-import-use-anonymous-db-data.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lis

[Libreoffice] [Patch] Support export of sheet local anonymous db data to excel binary

2011-04-25 Thread Markus Mohrhard
Hello, this patch allows to export the sheet local anonymous db data to excel binary. Patch is under LGPLv3+/MPL. Regards, Markus 0001-support-export-of-sheet-local-anonymous-db-data-to-e.patch Description: Binary data ___ LibreOffice mailing list Li

[Libreoffice] [Patch] Support export of anonymous db data to OOXML

2011-04-28 Thread Markus Mohrhard
Hello, this patch allows to export the sheet local anonymous db data to OOXML. The export of named db data is no longer supported with this patch because Excel only supports the concept of one sheet local anonymous db data(named ranges are still supported). Additionally this patch fixes several i

Re: [Libreoffice] [Patch] [PUSHED] Support export of anonymous db data to OOXML

2011-04-29 Thread Markus Mohrhard
2011/4/29 Kohei Yoshida > On Fri, 2011-04-29 at 01:46 +0200, Markus Mohrhard wrote: > > Hello, > > > > > > > > this patch allows to export the sheet local anonymous db data to > > OOXML. The export of named db data is no longer supported with this &g

[Libreoffice] [Patch] New Uno Interface for sheet local anonymous db data

2011-05-04 Thread Markus Mohrhard
Hello, for the import of the sheet local anonymous db data from excel I had to create a new UNO interface that supports calc's new sheet local db data. I attached my first version that compiles without any errors. But I'm open to any suggestion about better concepts or renaming of the interface.

Re: [Libreoffice] [Patch] New Uno Interface for sheet local anonymous db data

2011-05-04 Thread Markus Mohrhard
I'm fine with nearly everything. And your suggestion looks even a bit better than mine, except for the setByTable method. I was thinking about adding the table index too, but stumbled over the case when the table index does not match the table the db data refers to. We have a similar problem in ou

Re: [Libreoffice] [Patch] New Uno Interface for sheet local anonymous db data

2011-05-04 Thread Markus Mohrhard
2011/5/4 Kohei Yoshida > On Wed, 2011-05-04 at 18:23 +0200, Markus Mohrhard wrote: > > I'm fine with nearly everything. And your suggestion looks even a bit > > better than mine, except for the setByTable method. > > > > I was thinking about adding the table

Re: [Libreoffice] [Patch] New Uno Interface for sheet local anonymous db data

2011-05-04 Thread Markus Mohrhard
So all your suggestions are included into the new patch. I'll try now to get the import use this new interface. Regards, Markus 2011/5/4 Kohei Yoshida > On Wed, 2011-05-04 at 18:55 +0200, Markus Mohrhard wrote: > > > > At the moment there is no case where this happe

Re: [Libreoffice] [Patch][Pushed] New Uno Interface for sheet local anonymous db data

2011-05-04 Thread Markus Mohrhard
Pushed to master. 2011/5/4 Kohei Yoshida > On Wed, 2011-05-04 at 20:20 +0200, Markus Mohrhard wrote: > > So all your suggestions are included into the new patch. > > Looks lovely. Please commit to master (I assume you've been granted git > access?) > > One thing

[Libreoffice] [Patch] Use sheet local db data in ScVbaRange::Autofilter

2011-05-05 Thread Markus Mohrhard
Hello, here is a patch that allows the new sheet local db data being used by vba. This patch fixes some problems with XDatabaseRange in combination with the sheet local db data. I tested this with a test document I got from Noel and all seven test succeeded. The patch needs the last two patches

Re: [Libreoffice] [Patch] Use sheet local db data in ScVbaRange::Autofilter

2011-05-05 Thread Markus Mohrhard
I forgot to add one file to git, so here is the correct patch. Only difference is that in docuno.cxx 3 lines are added. Rest is the same as in the old version. 2011/5/5 Markus Mohrhard > Hello, > > here is a patch that allows the new sheet local db data being used by vba. > This

[Libreoffice] [Patch] make the OOXML import filter use sheet local db data

2011-05-05 Thread Markus Mohrhard
Hello, I hope that this is the last patch regarding the new sheet local db data. This patch allows the OOXML import use the sheet local db data. This patch needs my previous patch for the Vba autofilter. If anyone knows another place where autofilter or unnamed db data is used, please write me a

Re: [Libreoffice] [Patch][Pushed] Use sheet local db data in ScVbaRange::Autofilter

2011-05-08 Thread Markus Mohrhard
pushed to master 2011/5/6 Kohei Yoshida > On Thu, 2011-05-05 at 18:03 +0200, Markus Mohrhard wrote: > > I forgot to add one file to git, so here is the correct patch. > > > > > > > > Only difference is that in docuno.cxx 3 lines are added. Rest is the >

Re: [Libreoffice] [Patch][Pushed] make the OOXML import filter use sheet local db data

2011-05-08 Thread Markus Mohrhard
e the git access now, could > you please push it to master? > Also, for the export part - if you haven't already done, i.e. - could > you check it with office-o-tron once? > > Thanks again, > Muthu Subramanian > > On 05/06/2011 08:33 PM, Kohei Yoshida wrote: > &g

[Libreoffice-commits] core.git: sc/source

2013-03-09 Thread Markus Mohrhard
sc/source/filter/oox/worksheethelper.cxx | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) New commits: commit e1c281c6c1a2bd55d99e1af2023444c960cf02a3 Author: Markus Mohrhard Date: Sat Mar 9 14:21:16 2013 +0100 use direct calls to set row height, fdo#61721

[Libreoffice-commits] core.git: sc/source

2013-03-09 Thread Markus Mohrhard
sc/source/filter/oox/worksheethelper.cxx | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) New commits: commit 6a7ab93ad08fb000bbc5898929e89fd0532894a9 Author: Markus Mohrhard Date: Sat Mar 9 15:17:21 2013 +0100 use direct calls for column width import from

[Libreoffice-commits] core.git: 6 commits - basic/source framework/source rsc/source sc/source sd/source

2013-03-09 Thread Markus Mohrhard
insertions(+), 16 deletions(-) New commits: commit 5f606b0a5bcf71e7584403c9582188f1f564c67c Author: Markus Mohrhard Date: Sat Mar 9 17:19:01 2013 +0100 coverity#705676: fix memory leak Change-Id: Ibae1a0d073249ecfbfee0f73473d66bbf2602aff diff --git a/rsc/source/parser/rscyacc.y b/rsc

[Libreoffice-commits] core.git: 2 commits - sc/source svx/source

2013-03-09 Thread Markus Mohrhard
d2157548221e28d8f702cc81991f7aef198b523e Author: Markus Mohrhard Date: Sat Mar 9 20:32:25 2013 +0100 fix fdo#61025, Revert "fdo#55430 switches off text mode when ... This reverts commit e80a8b6f14fac6bb6cc7ea55b118f95472d5b654. Change-Id: I30305abb212907690933ff27899b0ad7b6793360 diff --git a/sc/sour

Re: minutes of ESC call ...

2013-03-09 Thread Markus Mohrhard
> * Hard Hacks: > + http://wiki.documentfoundation.org/HardHacks > + pending updates tomorrow. > + plan to have 2 writer, 1 spread, 1 draw/impress etc. > fdo#61025 - Crash when adding a comment on a cell (Markus) Fixed in master now. I reverted the commit introducin

[Libreoffice-commits] core.git: sc/source

2013-03-09 Thread Markus Mohrhard
sc/source/filter/xml/XMLExportIterator.cxx | 40 ++--- sc/source/filter/xml/xmlexprt.cxx | 15 ++ 2 files changed, 23 insertions(+), 32 deletions(-) New commits: commit c7937e2a38501266ed658553c19db5b4a2237864 Author: Markus Mohrhard Date: Sun Mar

Re: Missing service SvgWriter - forgotten when rebasing with AOO

2013-03-10 Thread Markus Mohrhard
> What good will it be to get a volunteer to build a mysql connector for > 4.0 if the connector can not be build? There are problems on OS X and LInux > because of changes made in autogen.sh. This needs to be fixed first before > finding a volunteer. > Until recently, this is used to conf

[Libreoffice-commits] core.git: 2 commits - sc/source

2013-03-10 Thread Markus Mohrhard
sc/source/ui/drawfunc/fusel.cxx | 28 sc/source/ui/drawfunc/futext.cxx | 37 ++--- 2 files changed, 50 insertions(+), 15 deletions(-) New commits: commit ecfe151546e3c0bcea71c949b9fa35a327d71969 Author: Markus Mohrhard Date

[Libreoffice-commits] core.git: sc/source

2013-03-10 Thread Markus Mohrhard
sc/source/filter/xml/XMLExportIterator.cxx | 19 --- 1 file changed, 19 deletions(-) New commits: commit 89331b3b4f3798d44ac8bfcf129b24ab8714a8dd Author: Markus Mohrhard Date: Sun Mar 10 15:27:31 2013 +0100 this method is now unused Change-Id

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - sc/source

2013-03-11 Thread Markus Mohrhard
sc/source/filter/xml/XMLExportIterator.cxx | 40 ++--- sc/source/filter/xml/xmlexprt.cxx | 15 ++ 2 files changed, 23 insertions(+), 32 deletions(-) New commits: commit 4428c7e9d73fd6a9722b262f2aab36c6fb8fd859 Author: Markus Mohrhard Date: Sun Mar

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - sc/source

2013-03-11 Thread Markus Mohrhard
sc/source/filter/oox/worksheethelper.cxx | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) New commits: commit 146352a3dcb65c99ec1b1b83f7be04231a32b21d Author: Markus Mohrhard Date: Sat Mar 9 14:21:16 2013 +0100 use direct calls to set row height, fdo#61721

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - sc/source

2013-03-11 Thread Markus Mohrhard
sc/source/core/data/table2.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a7eb431731761e72a343c29276cfbbea0e6f01ec Author: Markus Mohrhard Date: Tue Feb 19 20:11:28 2013 +0100 respect nDelFlags, fdo#57661 Change-Id

[Libreoffice-commits] core.git: 9 commits - filter/source officecfg/registry sc/inc sc/Library_sc.mk sc/sdi sc/source sc/uiconfig sfx2/inc sfx2/source svx/inc svx/sdi

2013-03-14 Thread Markus Mohrhard
: Markus Mohrhard Date: Thu Mar 14 23:25:31 2013 +0100 remove some unnecessary lines Change-Id: I0a83769f19a38fd5c0421ba6117603517cded17b diff --git a/sc/source/ui/drawfunc/fuins2.cxx b/sc/source/ui/drawfunc/fuins2.cxx index f5a8aeb..95e589d 100644 --- a/sc/source/ui/drawfunc/fuins2

[Libreoffice-commits] core.git: sc/source

2013-03-14 Thread Markus Mohrhard
sc/source/filter/chart/chart_imp.cxx | 42 +++ 1 file changed, 42 insertions(+) New commits: commit fbaad98be26889bd0e278093f95a14bdb13786b6 Author: Markus Mohrhard Date: Fri Mar 15 01:35:45 2013 +0100 forgot the file Change-Id

[Libreoffice-commits] core.git: 6 commits - officecfg/registry sc/source sc/uiconfig xmloff/source

2013-03-17 Thread Markus Mohrhard
ies2Context::CreateChildContext( nPrefix, rLocalName, msAutoStyleName, mrStyleList, m_xSeries, SchXMLStatisticsObjectContext::CONTEXT_TYPE_ERROR_INDICATOR, -maChartSize ); +maChartSize, mrLSequencesPerIndex );

Re: Re: Re: fdo#61135 New feature in Calc: Stepped Lines graphs - first part of code submitted

2013-03-18 Thread Markus Mohrhard
2013/3/16 Eric Seynaeve : > I have (finally) created a mock with the new features added. There was a > mistake in it first which cause me to loose quite some time in a wild > goose-chase :-( I attach it so this mail and place it under MPL/LGPLv3. > > > > On Friday 08 March

[Libreoffice-commits] core.git: 2 commits - chart2/source offapi/com sc/Module_sc.mk sc/qa xmloff/inc xmloff/source

2013-03-18 Thread Markus Mohrhard
7e18e657c1ae33c35c8046676b1da195b0d3f493 Author: Markus Mohrhard Date: Tue Mar 19 02:15:25 2013 +0100 let us keep the gnumeric value handling in xmloff Change-Id: I51c7ca53ec8b023dc06b43ec9cb1052d135d14d5 diff --git a/chart2/source/controller/chartapiwrapper/WrappedSplineProperties.cxx b/chart2/source

[Libreoffice-commits] core.git: sc/Module_sc.mk sc/qa

2013-03-18 Thread Markus Mohrhard
sc/Module_sc.mk |2 ++ sc/qa/unit/ucalc.cxx |2 +- 2 files changed, 3 insertions(+), 1 deletion(-) New commits: commit 60ab9a0bc8af439a7b7d0f57ea6b5215dc8aa9fa Author: Markus Mohrhard Date: Tue Mar 19 02:42:42 2013 +0100 that should not have been in the patch diff --git a

Re: Re: fdo#61135 New feature in Calc: Stepped Lines graphs - first part of code submitted

2013-03-18 Thread Markus Mohrhard
Hey Eric, I pused your patch to master and the test file to the test-file repository. I only moved in a follow-up patch the handling for gnumeric values from chart2 into xmloff. IMO the handling of file format issues should be kept in the filter code and not be moved to the chart core code. Than

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - xmloff/source

2013-03-19 Thread Markus Mohrhard
xmloff/source/chart/SchXMLPlotAreaContext.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 4bdfeabe6e65f865d5cec16b31cda524eb8b9b90 Author: Markus Mohrhard Date: Sat Mar 16 01:04:44 2013 +0100 use the right range representation, fdo#52159

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - sc/source

2013-03-19 Thread Markus Mohrhard
sc/source/ui/view/drawvie4.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 7b73ff9932f4bd8ab428855ea4fe34898fe74527 Author: Markus Mohrhard Date: Sun Mar 17 01:46:05 2013 +0100 for internal data providers this makes no sense Change-Id

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - sc/source

2013-03-19 Thread Markus Mohrhard
sc/source/ui/view/drawvie4.cxx | 87 - 1 file changed, 70 insertions(+), 17 deletions(-) New commits: commit 875a8fb01238e998fc6e64fbf7a4e51c18973e61 Author: Markus Mohrhard Date: Sun Mar 17 02:53:02 2013 +0100 error bar range is also part of

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - xmloff/source

2013-03-19 Thread Markus Mohrhard
bdfaf33419a9720d2afb48238a110a3cf8238aec Author: Markus Mohrhard Date: Mon Mar 18 01:57:03 2013 +0100 we need to register data sequences during import, fdo#52159 Change-Id: I203be719a6ee19c87ed232218f7700d875c2871f (cherry picked from commit 094bab7f9097fba62800d3dd578bd42640d8c6e2) Reviewed-on: https

[Libreoffice-commits] core.git: 9 commits - sc/qa sc/source

2013-03-22 Thread Markus Mohrhard
/formula.cxx |8 - 6 files changed, 80 insertions(+), 117 deletions(-) New commits: commit 33b0684dd721c4ee5c24d2c9b3b77974db882046 Author: Markus Mohrhard Date: Fri Mar 22 06:58:27 2013 +0100 update the test files Change-Id: I0285e9d6739e7f2a9882fd19f03524482128e2d2 diff

[Libreoffice-commits] core.git: 5 commits - sc/qa

2013-03-22 Thread Markus Mohrhard
/subsequent_export-test.cxx | 68 +- sc/qa/unit/subsequent_filters-test.cxx | 88 +- 7 files changed, 248 insertions(+), 64 deletions(-) New commits: commit 317a9b2e9463635b87f1c00fc11755dc9a4129f6 Author: Markus Mohrhard Date: Fri Mar 22 08:52:11 2013 +0100 add databar

[Libreoffice-commits] core.git: 4 commits - sc/inc sc/qa sc/source

2013-03-23 Thread Markus Mohrhard
(-) New commits: commit 73e74680d8c0cbf8baf869cc8bbc58dae432a0ef Author: Markus Mohrhard Date: Sat Mar 23 08:33:22 2013 +0100 add ODS test for above/below cond format rules Change-Id: I6ce6292a490ef39c111aa7f4c0a5ada0d45c16bc diff --git a/sc/qa/unit/data/ods/new_cond_format_test.ods

[Libreoffice-commits] core.git: 7 commits - sc/qa sc/source

2013-03-23 Thread Markus Mohrhard
files changed, 27 insertions(+), 58 deletions(-) New commits: commit 2c3943f43d29bf9173a5c85710a4d2d06b6885ba Author: Markus Mohrhard Date: Sun Mar 24 05:10:39 2013 +0100 we can stop the loop as soon as we found something Change-Id: I43e318e5aa112587775c0982d42e7780408a6b83 diff

[Libreoffice-commits] core.git: 3 commits - sc/qa sc/source

2013-03-23 Thread Markus Mohrhard
stMiscRowHeightExport() commit 6c2acf78ad988c100d4163f369411482e5fd0f44 Author: Markus Mohrhard Date: Sun Mar 24 05:27:03 2013 +0100 remove unused variables Change-Id: I602169d65c77ae71e0d5dd4b3b95837db91fa7da diff --git a/sc/source/core/data/cell2.cxx b/sc/source/core/data/cell2.cxx index 9232772..cacd5e1 100644 --- a

[Libreoffice-commits] core.git: 3 commits - chart2/qa offapi/com

2013-03-23 Thread Markus Mohrhard
d1bc91ea645f490bd3da205c31fe45711d009f29 Author: Markus Mohrhard Date: Sun Mar 24 07:39:45 2013 +0100 add import test for stepped lines Change-Id: I5a11bc65ca82719c0e8de94628ae4958afe57aa4 diff --git a/chart2/qa/extras/chart2import.cxx b/chart2/qa/extras/chart2import.cxx index e30e1a0..7933001 100644

[Libreoffice-commits] core.git: chart2/qa

2013-03-24 Thread Markus Mohrhard
chart2/qa/extras/data/ods/stepped_lines.ods |binary 1 file changed New commits: commit ef61bc2934bb9ae27b366fce6e707533cd73c862 Author: Markus Mohrhard Date: Sun Mar 24 14:16:14 2013 +0100 add missing test file Change-Id: I87e2bdf944a3fdf374f8b1f14e44ebc0fdd83d46 diff --git a

Re: [PATCH][PUSHED] fdo#49704 Split Cells in calc popup menu

2012-11-28 Thread Markus Mohrhard
Hey Laurent, 2012/11/28 Laurent Godard : > Hi all > > referenced as heasyhack > > please find a patch that adds a Split Cells menu entry in the calc popup > menu > > please note that i left the ~ accelarator undefined > Great. Pushed the patch to master. Regards, Markus _

Re: [design] XML filter for templates, how to change default shape colors etc.

2012-11-29 Thread Markus Mohrhard
Hey Alexander, > > sorry for breaking the build :/ Happens to everybody from time to time. Just for the next time it might be good to do a full compile for such changes. > > Stephan Bergmann wasn't sure whether it'd be better to revert the > commit or update the tests. Well actually the right s

reverted FCFGMerge change

2012-11-30 Thread Markus Mohrhard
Hey Michael, I just reverted the switch to Python FCFGMerge. It seems to not work correctly and I think we need the tinderboxes to detect the serious errors until the feature freeze. Please have a look at the tinderbox logs, maybe we can easily fix it. Regards, Markus ___

Re: random number generators for calc

2012-12-01 Thread Markus Mohrhard
On Sat, Dec 01, 2012 at 10:17:31PM +0100, Michael Stahl wrote: > On 01/12/12 12:22, tino wrote: > >> the header is sal/inc/rtl/random.h (which is apparently a C interface). > > > > Exactly, the C++ interface is missing. > > but that isn't really a problem, is it? using it is as simple as: > >

Re: random number generators for calc

2012-12-02 Thread Markus Mohrhard
On Sun, Dec 02, 2012 at 11:47:01AM +, tino wrote: > > > ... looking at random.cxx it appears to use a MD5 hash to generate the > > random bytes; initialization is via seconds/nanoseconds of current time > > and thread-id. since the cryptographic hash implementations in sal/rtl > > don't look

Re: opinions on additional calc functions

2012-12-03 Thread Markus Mohrhard
On Mon, Dec 03, 2012 at 10:37:55PM +, tino wrote: > > I've also got an example/test spreadsheet, but didn't quite know where > to put it. > The right solution is to extend the existing function (import) tests in sc/qa/unit/subsequent_filters-test.cxx with the test file being in sc/qa/unit/da

Re: opinions on additional calc functions

2012-12-04 Thread Markus Mohrhard
On Tue, Dec 04, 2012 at 05:50:25PM +, tino wrote: > > > I've also got an example/test spreadsheet, but didn't quite know where > > > to put it. > > > > The right solution is to extend the existing function (import) tests in > > sc/qa/unit/subsequent_filters-test.cxx with the test file being in

Re: random number generators for calc

2012-12-07 Thread Markus Mohrhard
Hey Tino, 2012/12/6 tino : >> > just happened to reimplement RAND() with a B.A Wichmann >> > and I.D Hill generator.. see >> >> As they are entitled to. No doubt we'll come up with a comprehensive, >> nicely architected and beautiful solution of our own :-) > > Ok, I'll go ahead with a sugge

Re: random number generators for calc

2012-12-07 Thread Markus Mohrhard
Hey 2012/12/7 tino : >> > Small problems: >> > - compiler warnings from within boost >> >> We need to patch them out otherwise the Werror build will fail. It >> seems that these warnings are also fixed upstream. > > This really confuses me. The warnings I'm getting are of the form > > ...boost/r

Re: random number generators for calc

2012-12-07 Thread Markus Mohrhard
Hey tino, > > Attached patch is just a simple wrapper around boost, to be used like > > sc::rng::seed() to replace libc srand() > sc::rng::rand() to replace libc rand() I pushed this part of the patch. > > and a few more distributions. I did not push them. As soon as we have users for them it m

license statement

2012-12-07 Thread Markus Mohrhard
Hey Tino, seems like we have no license statement from you. Could you please send one to the Mailinglist? Something in the form of: All of my past & future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. Thanks, Markus __

Re: liborcus sources website

2012-12-11 Thread Markus Mohrhard
Hey, 2012/12/11 John Smith : > Hi, > > > I see a LibreOffice build has a pre-req for 'liborcus-0.4'. However, > my Fedora system has no packages for that. Does anyone know what the > website of that is, so I can download and install the sources ? I > tried a quick google, but couldnt find it. Or

[REVIEW 3-6] fix for fdo#56742 , ScRangeList::UpdateReference does not handle URM_COPY

2012-12-15 Thread Markus Mohrhard
Hey, [1] fixes [2] which is more or less a problem in ScRangeList::UpdateReference but we can't safely change it as there might be some users that rely on this behavior. So we just map URM_COPY to URM_MOVE which does the right thing in our case too. Regards, Markus [1] http://cgit.freedesktop.o

Re: Question about sc/source/core/data/colorscale.cxx

2012-12-15 Thread Markus Mohrhard
Hey, > I noticed these lines in file sc/source/core/data/colorscale.cxx > (because cppcheck report indicates that bNeedUpdate is reassigned before to > be used line 641) > > 637 void ScDataBarFormat::DataChanged(const ScRange& rRange) > 638 { > 639 bool bNeedUpdate = false; > 6

Re: Question about sc/source/core/data/colorscale.cxx

2012-12-15 Thread Markus Mohrhard
Hey Mat, >> >> >> Implemented a correct version with >> 4f901a2f451a552853c1dd38309dd55b22616fdd. > > > Sorry but what I see in 4f901a2f45 is the same thing as Julien pasted in his > mail. > It rollback the good version: I don't understand your question. I changed the code to use OR in one place

Re: [REVIEW 3-6] fix for fdo#56742 , ScRangeList::UpdateReference does not handle URM_COPY

2012-12-15 Thread Markus Mohrhard
Hey Eike, > >> [1] fixes [2] which is more or less a problem in >> ScRangeList::UpdateReference but we can't safely change it as there >> might be some users that rely on this behavior. So we just map >> URM_COPY to URM_MOVE which does the right thing in our case too. > > Hmm.. sure it doesn't int

Re: Calc sort - missing sort area information

2012-12-17 Thread Markus Mohrhard
Hello Hannu, 2012/12/17 Hannu Puhakka : > Hi > LibreOffice 3.5.4.2 > Build ID: 350m1(Build:2) > > Menu: Data / Sort > Opens a dialog where you can select sorting order and options. > > Problem: User cannot check what is the real area to be sorted. > Should be a field at least to show the area "A1.

Re: storing chart doc on load ?

2012-12-23 Thread Markus Mohrhard
Hey Michael, > > I was surprised to see some similar things happening with VBA streams > on load (or at least things getting written out again). After a bit of > thought, I assumed that one was so we could re-store the identical input > in the output again if it was not changed: so we cou

Re: Same function implemented 6 times in calc tests

2013-01-28 Thread Markus Mohrhard
Hey, 2013/1/28 Marcos Souza : > Hi guys! > > While I was looking at some STRINGPARAM macros in calc, I saw the function > createFileURL is implemented several times: > > http://opengrok.libreoffice.org/search?q=void+createFileURL&project=core&defs=&refs=&path=sc&hist= > > And they are all equal. I

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sc/source

2013-02-01 Thread Markus Mohrhard
sc/source/filter/xml/xmlexprt.cxx | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) New commits: commit e483ea0d8abda0eb5a0e8cef55229f3e8ac06a21 Author: Markus Mohrhard Date: Thu Jan 31 00:19:00 2013 +0100 Hyperlink is an optional property, fdo#58858 Change

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - formula/source

2013-02-01 Thread Markus Mohrhard
formula/source/core/api/FormulaCompiler.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 3305827a24a1b9c66220bb3578fec6a43df4a421 Author: Markus Mohrhard Date: Wed Jan 30 22:02:06 2013 +0100 make it possible to update DDE links after loading, fdo#59032 Change

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sc/source

2013-02-01 Thread Markus Mohrhard
sc/source/core/data/attarray.cxx |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit 7c6b21c31904b2ed007f961e4bf094af1a1981c7 Author: Markus Mohrhard Date: Wed Jan 30 01:34:24 2013 +0100 if no cond format is valid use the existing protection, fdo#58826

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sc/source

2013-02-01 Thread Markus Mohrhard
sc/source/ui/condformat/condformatdlgentry.cxx |4 1 file changed, 4 insertions(+) New commits: commit ca92558fca923cce205bd8e67f906d1d7e03121e Author: Markus Mohrhard Date: Fri Jan 25 23:08:47 2013 +0100 show style when dialog is created with existing cond format, fdo#59778

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sc/source

2013-02-01 Thread Markus Mohrhard
sc/source/filter/xml/xmlcondformat.cxx |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) New commits: commit e39fe8bc29af60e849534b6cb1882dbcec363052 Author: Markus Mohrhard Date: Sun Jan 27 02:34:00 2013 +0100 we need to parse the cell address after import, fdo#59843

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sc/source

2013-02-01 Thread Markus Mohrhard
sc/source/core/data/colorscale.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 008b8c4ca907950af543da91986ba89b0de1ae15 Author: Markus Mohrhard Date: Sat Jan 26 23:32:03 2013 +0100 we need to use SCROW for row numbers, fdo#59894 This caused an

[Libreoffice-commits] core.git: sc/source

2013-02-05 Thread Markus Mohrhard
sc/source/core/data/attarray.cxx | 230 - sc/source/filter/excel/xistyle.cxx |1 2 files changed, 105 insertions(+), 126 deletions(-) New commits: commit 591ef475a3f92613a771a0702e720f4f00c3ff0c Author: Markus Mohrhard Date: Mon Feb 4 18:35:18 2013

Re: Bug #47065

2013-02-06 Thread Markus Mohrhard
Hey, 2013/2/7 José Guilherme Vanz : > Hi > I started work in this bug. I created the first simple source file, just for > test. > My doubt is, is necessary add my source file in some config file? > > In my test I created a object of my thread in the docfile.cxx. Nothing > special... > When I build

[Libreoffice-commits] core.git: sc/source

2013-02-14 Thread Markus Mohrhard
sc/source/core/data/colorscale.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 4dc71bcf6e6a757a8369c46db1c24e98679d1506 Author: Markus Mohrhard Date: Thu Feb 14 15:26:27 2013 +0100 use >= as mentioned in the UI, fdo#60798 Change

[Libreoffice-commits] core.git: 2 commits - sc/source

2013-02-14 Thread Markus Mohrhard
sc/source/core/data/conditio.cxx | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) New commits: commit 71ed03b9ad45e7da8ac454377701d265ce11cca1 Author: Markus Mohrhard Date: Thu Feb 14 15:49:40 2013 +0100 assert if there is a wrong index, a warning is not enough

Re: [PATCH] translation of german comment in file dtrans/source/win32/clipb/WinClipbImpl.cxx

2013-02-14 Thread Markus Mohrhard
Hey, 2013/2/14 Urs Fässler : > Hi, > translation of the (only) german comment in the file > dtrans/source/win32/clipb/WinClipbImpl.cxx > Looks nice and pushed to master. It seems we have no license statement from you. Could you please send one to the mailing list? Regards, Markus ___

[Libreoffice-commits] core.git: 3 commits - sc/source

2013-02-15 Thread Markus Mohrhard
sc/source/core/data/cell.cxx |1 + sc/source/core/data/column3.cxx |3 ++- sc/source/core/data/documen4.cxx |2 +- 3 files changed, 4 insertions(+), 2 deletions(-) New commits: commit b3356f6f772d7d265160927d45f935098784c20e Author: Markus Mohrhard Date: Fri Feb 15 20:56:47

[Libreoffice-commits] core.git: 8 commits - filter/source sc/source

2013-02-15 Thread Markus Mohrhard
: commit 9a73122622bc44e34d9e7c56d1a16de43ed3adae Author: Markus Mohrhard Date: Fri Feb 15 22:19:10 2013 +0100 coverity: prevent use of unitialized variable Change-Id: I17520b15d75467f8233f964ef99a4dd0eea7ed44 diff --git a/sc/source/ui/dbgui/filtdlg.cxx b/sc/source/ui/dbgui/filtdlg.cxx

[Libreoffice-commits] core.git: sc/source

2013-02-15 Thread Markus Mohrhard
sc/source/core/data/documen4.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0df21bf1f487b673f50c9a8b5466465b18e30c7d Author: Markus Mohrhard Date: Fri Feb 15 23:37:29 2013 +0100 Revert "coverity: fix memory leak" This reve

[Libreoffice-commits] core.git: 9 commits - sc/source

2013-02-15 Thread Markus Mohrhard
/view/viewfun2.cxx |3 +++ sc/source/ui/view/viewfun4.cxx |6 ++ sc/source/ui/view/viewutil.cxx |2 ++ 9 files changed, 14 insertions(+), 16 deletions(-) New commits: commit 577d7ecd494b38d673fbb84738f427f18353fcfc Author: Markus Mohrhard Date: Sat Feb 16 00:58:11 2013

[Libreoffice-commits] core.git: 9 commits - sc/source sd/source

2013-02-15 Thread Markus Mohrhard
Author: Markus Mohrhard Date: Sat Feb 16 03:28:53 2013 +0100 coverity: finally fix the memory leak correctly Change-Id: I1cd8978eba9f42aaa3d5e53085cac23f5e6a31ef diff --git a/sc/source/core/data/documen4.cxx b/sc/source/core/data/documen4.cxx index 9356e77..6299578 100644 --- a/sc

[Libreoffice-commits] core.git: 4 commits - sc/source

2013-02-16 Thread Markus Mohrhard
Author: Markus Mohrhard Date: Sat Feb 16 17:24:10 2013 +0100 coverity: variable values is unused Change-Id: Id2cd10aa34d96629915a3258a20f928af441ebcc diff --git a/sc/source/ui/view/viewfun6.cxx b/sc/source/ui/view/viewfun6.cxx index 86b04f6..2a5f693 100644 --- a/sc/source/ui/view

[Libreoffice-commits] core.git: 8 commits - sc/source

2013-02-17 Thread Markus Mohrhard
insertions(+), 20 deletions(-) New commits: commit b3652dae4b4d3f02fc0c02d9e139391ef43d7ba5 Author: Markus Mohrhard Date: Sun Feb 17 19:06:17 2013 +0100 coverity: fix memory leak Change-Id: I2a620971d70c021c7a31dac14ce76f3428324f26 diff --git a/sc/source/core/data/colorscale.cxx b/sc

[Libreoffice-commits] core.git: 2 commits - sdext/source vcl/source

2013-02-17 Thread Markus Mohrhard
commits: commit 07ee72672e6966dafccf21ca3349e428c2a9dd0a Author: Markus Mohrhard Date: Sun Feb 17 19:53:00 2013 +0100 coverity: pass by const reference is more efficient Change-Id: Iec40176a5dd567e667178f07fecd043fe0aa4344 diff --git a/sdext/source/pdfimport/tree

[Libreoffice-commits] core.git: 9 commits - lotuswordpro/source

2013-02-17 Thread Markus Mohrhard
/filter/lwptablelayout.cxx|2 +- 5 files changed, 22 insertions(+), 24 deletions(-) New commits: commit fdf59cc3b5928aa1b4fca62909988c455695cd03 Author: Markus Mohrhard Date: Mon Feb 18 01:40:13 2013 +0100 coverity: fix memory leak Change-Id

New test to automatically importing all bugzilla documents

2013-02-18 Thread Markus Mohrhard
Hey, so after much work the idea to automatically import all bugzilla files was succesful. An initial test run with all docx files in Release configuration showed that it is quite stable and I'm currently rebuilding with dbgutil (to get the safe iterators) and will run an initial test of all Write

<    1   2   3   4   5   6   7   8   9   10   >