___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
.1 license.
Ciao
Matteo
>From f9427c431d2bd7160058ba85ab9cb7b6436a271c Mon Sep 17 00:00:00 2001
From: Matteo Casalin
Date: Sun, 13 Nov 2011 19:19:27 +0100
Subject: [PATCH] Decoview code cleanup
Fixed DrawSymbol color selection
Cleaned up many ImplDrawSymbol cases, reducing number of calls to drawi
Noel Power wrote:
(14/11/2011 16:46)
[...]
> Personally I am not a ui or vcl person so I only pushed the final couple
> of hunks relating to fixing the colour selection.
Thanks for reviewig!
> But you seem to have
> done a great job getting into drawing stuff ( as you can see that code
> ne
n docuview some more :)
Hope to send you the new patch (with picture) ASAP.
Thanks
Matteo
--
Michael Meeks wrote:
(23/11/2011 16:02)
> Hi Matteo,
>
> On Sun, 2011-11-13 at 19:54 +0100, Matteo Casalin wrote:
> > my name's Mat
or whatelse). I did some internet
research about checkmarks in RTL, without results. Unless the original
bug report is found, this issue should/could eventually be clarified
with some RTL people.
Thanks again
Matteo
------
Matteo Casalin wrote:
(2
Hi all,
just a quick reply until I can sit in front of my own pc. As
Michael said, I'm (slowly) cleaning up decoview, and I can see two
points related to this issue:
1) Wrong direction of arrow: actually, the arrow depicted in Lior's
screenshot does not seem to be drawn by decoview's (there's
On 11/29/2011 12:03 PM, Khaled Hosny wrote:
On Tue, Nov 29, 2011 at 11:12:36AM +0100, Matteo Casalin wrote:
2) Mirroring of checkmarks: in decoview there's a strange bug-related
comment which says roughly "don't mirror checkmarks in RTL", following
by code that actua
001
From: Matteo Casalin
Date: Sun, 27 Nov 2011 09:58:48 +0100
Subject: [PATCH 1/4] Removed unused header
---
vcl/source/window/decoview.cxx |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/vcl/source/window/decoview.cxx b/vcl/source/window/decoview.cxx
index e8ed434..9abd
Hi,
please find attached a patch which rewrites the DrawButton function.
The attached patch is contributed under LGPL3+/MPL1.1 license.
Matteo
>From 2c0dde2798b800ee3fb95c4e54fa9b7f693727cb Mon Sep 17 00:00:00 2001
From: Matteo Casalin
Date: Sun, 4 Dec 2011 12:18:49 +0100
Subject: [PATC
.
Matteo
>From d485e0fcd8132ddd503f5acb20dd9c0864f08cc5 Mon Sep 17 00:00:00 2001
From: Matteo Casalin
Date: Sun, 4 Dec 2011 15:25:04 +0100
Subject: [PATCH 3/4] DecoView cleanup - Embed
OutputDevice::ImplDraw2ColorFrame
---
vcl/inc/vcl/outdev.hxx |1 -
vcl/source/gdi/outdev6.
Hi,
please find attached a patch that takes advantage of previous patch
to cleanup the code calling ImplDraw2ColorFrame.
The attached patch is contributed under LGPL3+/MPL1.1 license.
Matteo
>From e0167dc0598f011f22728fb77e5b23be2f273781 Mon Sep 17 00:00:00 2001
From: Matteo Casalin
D
All of my present and future contributions to LibreOffice are available
under the terms of the LGPLv3+/MPL licenses, until further notice.
Matteo Casalin
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org
The attached patch removes from DecorationView some unused (according to
"grep -r BUTTON_DRAW_ *, performed at top level) button styles with the
related code.
Matteo
>From e5097ddf0c1753b44b2a23dcfb51ba761b899adf Mon Sep 17 00:00:00 2001
From: Matteo Casalin
Date: Sun, 4 Dec 2011
account that, according to
RTL people [1], checkmarks are drawn the same in LTR/RTL languages.
Matteo
[1] Lior Kaplan and Khaled Hosny in the thread "Remember the RTL
interface", dated 11/29/2011.
>From b94d39b77efb96d20a94292f4e842bdb87223ae4 Mon Sep 17 00:00:00 2001
From: Matteo Casal
Hi all,
I'm not a reviewer (nor I'm pretending to be), I just want to
highlight a possible issue: this patch also changes
solenv/gbuild/extensions/post_BuildplTargets.mk
(lines from 99 to 111) which has no "menues" in it.
It also changes "menues" occurrences in some comments that are still
Hi Winfried, please find my comments below.
On 12/09/2011 05:10 PM, Winfried Donkers wrote:
Hello all,
I have just got a new computer, which should make LibO much faster than my old
machine does :) .
Unfortunately, I get a make error:
.../core/solver/unxlngi6.pro/bin/cppunit/cppunittester: sym
>From 9ed12c989a64306e1503edf2943e6bd5d60d3140 Mon Sep 17 00:00:00 2001
From: Matteo Casalin
Date: Fri, 9 Dec 2011 21:13:58 +0100
Subject: [PATCH] DecoView cleanup: rework ImplDrawFrame
---
vcl/source/window/decoview.cxx | 398 +++-
1 files changed, 187 in
Hi everybody,
some days ago I stumbled upon vcl Rectangle SvStream >> and <<
operators (gen.cxx). Their implementation handles the case that the
stream is compressed as COMPRESSMODE_FULL (and can surely be improved).
For better understanding I opengrok'ed this COMPRESSMODE_FULL and it
turns
Hi Thorsten
Thorsten Behrens wrote:
(16/12/2011 01:55)
> Matteo Casalin wrote:
> > set:
> > /binfilter/binfilter/bf_svtools/source/filter.vcl/filter/svt_filter.cxx
> > /core/svtools/source/filter/filter.cxx
> >
> Both can go.
>From my understanding, if we
Hi Thorsten,
On 12/16/2011 11:52 AM, Thorsten Behrens wrote:
Matteo Casalin wrote:
From my understanding, if we remove these 2 calls that set te
COMPRESSMODE_FULL flag then there is no reason to keep the code that
depend on that, unless the svstream acquires the flag from the stream
itself or
On 12/16/2011 04:48 PM, Tommy wrote:
On Fri, 16 Dec 2011 00:08:26 +0100, Matteo Casalin
wrote:
Hi, this is off-topic, however since you are the
only italian active code developer of LibO (Italo Vignoli is
not involved into coding but into marketing),
I'm inviting you to join the Italia
ecomes: do that data
really need to be of type long? Rectangle, for example, are widely used,
and type long doubles their size in 64-bit machines.
On 12/19/2011 10:01 PM, Thorsten Behrens wrote:
Matteo Casalin wrote:
Here are the patches for *completely* removing COMPRESSMODE_FULL
support.
Appl
Hi all,
--
Mariusz Dykierek wrote:
(16/02/2012 11:46)
> On 2012-02-16 10:02, Stephan Bergmann wrote:
> > On 02/16/2012 09:35 AM, Riccardo Magliocchetti wrote:
> >> Otherwise you can simplify it even more:
> >>
> >> sal_Bool bLeft = (meAlign == WIND
Hi all,
lately I've been working on ValueSet code, which is used in several
controls (e.g. color selection, color configuration, columns selection
in writer...), doing some cleanups. When the code will be more
manageable I plan to fix some little bugs (selection/focus).
Looking at the (no
Hi all,
lately I've been working on ValueSet code, which is used in several
controls (e.g. color selection, color configuration, columns selection
in writer...), doing some cleanups. When the code will be more
manageable I plan to fix some little bugs (selection/focus).
Looking at the (no
Hi Astron,
On 03/03/2012 04:07 PM, Stefan Knorr (Astron) wrote:
Hi Matteo,
so, took me a while to find the courage to read that :) But good
observations these are.
Yeah, I was quite afraid of the length of my email :) Thanks for reading
it all!
Anyway, ...
Is this behavior the expected/
Hi Astron,
thanks for you feedback.
Before beginning to modify the behavior of key navigation, I'd like to
recap the things that I should do, as from my understanding of our
discussion. Would you mind confirming them (yes/no will suffice)?
* left/right keys should not wrap around from top
d and try to add some
thoughts. Sorry if it is a bit too late.
Matteo Casalin wrote (03-03-12 18:54)
On 03/03/2012 04:07 PM, Stefan Knorr (Astron) wrote:
* left/right motion should not wrap around from first to last (or last
to first) item. Moving through lines is fine (behavior similar to
m
selected by normal key navigation (no special keys).
Next steps: fix the code that handles item selection.
Looking forward to your feedback
Matteo
On 03/24/2012 12:31 AM, Cor Nouws wrote:
Matteo Casalin wrote (23-03-12 21:30)
On 03/21/2012 01:23 PM, Cor Nouws wrote:
One could say, that
Hi all,
just a minor hint from my side: in the original code nBox was
incremented only when "pBox == rBoxes[nBox]", while in the new one it
happens unconditionally. I don't know if this could be an issue or
not.
To preserve the original behaviour a single conditional
if ( nBox < nBoxCnt
7;t know which is the preferred way to proceed for
such short patches.
> - Jesso Clarence
Thanks for you contribution
Matteo Casalin
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hi all,
On 07/11/2012 05:27 PM, Bjoern Michaelsen wrote:
Hi,
On Wed, Jul 11, 2012 at 10:38:42AM +0100, Michael Meeks wrote:
Found pushed; did I miss a gerrit mail mentioning that ?
Thats http://code.google.com/p/gerrit/issues/detail?id=1465 if one pushed
directly to master, gerrit s
cui/source/dialogs/cuigrfflt.cxx |1 -
vcl/source/app/sound.cxx | 12
2 files changed, 4 insertions(+), 9 deletions(-)
New commits:
commit ad6b352bffdba5c45fa0915c7fdf8f5460409fc3
Author: Matteo Casalin
Date: Sat Jul 14 18:46:58 2012 +0200
Cleanup sound.cxx
Hi all,
just my first impressions about gerrit, hoping it could be useful
to improve the developer experience.
* Registration with OpenID: no all providers are accepted: openid.org
(first choice, seen suggested on a mail for initial announce), was
not. It could be useful to add a list o
Hi all,
a possibly silly question, but I'm wondering why new code files
(e.g. sfx2/inc/sfx2/zoomitem.hxx) say:
+ * Copyright 2000, 2010 Oracle and/or its affiliates.
+ *
+ * OpenOffice.org - a multi-platform office productivity suite
+ *
+ * This file is part of OpenOffice.org
Is this expec
On 06/08/2012 05:42 PM, Caolán McNamara wrote:
On Fri, 2012-06-08 at 15:59 +0200, Matteo Casalin wrote:
Hi all,
a possibly silly question, but I'm wondering why new code files
(e.g. sfx2/inc/sfx2/zoomitem.hxx) say:
cause I just moved it from svx, its not a new file, just a moved old
Dear list,
it happens sometimes that gerrit builds fail because of a single
job (e.g. gerrit_windows) failing, with error messages that looks
completely unrelated to the patch being verified. In this case it seems
legitimate to think of a random failure which would likely disappear by
rebu
Thanks Miklos.
Kind regards
Matteo
On 1/14/19 9:15 AM, Miklos Vajna wrote:
Hi Matteo,
On Sun, Jan 13, 2019 at 11:18:55AM +0100, Matteo Casalin
wrote:
executing all of the jobs (gerrit_linux*, gerrit_macos, gerrit_windows)? Up
to know I just rebased the patch, but this looks to me as quite
Dear all,
I stumbled upon this code:
https://opengrok.libreoffice.org/xref/core/sw/source/ui/fldui/fldpage.cxx?r=1a33947a#143
and think that at line 152 token #2 should be obtained instead of token
#1 (which was just obtained a couple of lines before).
I don't know what this code is used fo
Dear all,
I'm working on improving code that calls getToken (e.g. using its
version with index, or using other OUString functions in its place when
possible).
One thing that I noticed is that there are a lot of calls in the form
getToken().toInt# which require memory management just to obta
Hi Stephan,
On 1/30/19 10:40 PM, Stephan Bergmann wrote:
On 30/01/2019 22:17, Matteo Casalin wrote:
I'm working on improving code that calls getToken (e.g. using its
version with index, or using other OUString functions in its place
when possible).
One thing that I noticed is that
sw/source/core/tox/tox.cxx | 33 -
1 file changed, 16 insertions(+), 17 deletions(-)
New commits:
commit c6e8460a5b47fa6fa971dde2a89e80662b6e97ae
Author: Matteo Casalin
Date: Sun Jan 14 19:12:30 2018 +0100
Return correct length for Authority token
sw/source/core/tox/tox.cxx | 33 -
1 file changed, 16 insertions(+), 17 deletions(-)
New commits:
commit df041d902eafb1e273eb360103252994bbd2cde2
Author: Matteo Casalin
Date: Sun Jan 14 19:12:30 2018 +0100
Return correct length for Authority token
getParameter( "location" );
}
BasicManager* pBasMgr = nullptr;
commit e256519a629e88c624c52916f1c38f774cfd445c
Author: Matteo Casalin
Date: Sun Mar 19 12:06:20 2017 +0100
OUString-related simplifications
Change-Id: I2f4099410bcdb9e04583cd37bf63ef86ce81f7e5
diff --git
On 2017-03-20 14:44, Caolán McNamara wrote:
On Fri, 2017-03-17 at 17:39 +0100, Matteo Casalin wrote:
3. Commit
https://cgit.freedesktop.org/libreoffice/core/commit/?id=a8f1ad65612c
0e54969cabc541b183062ae3d905
My guess is that the "if" in the code under consideration can be
remov
7cccb79f541404f6d317da49cee431294b9121c6
Author: Matteo Casalin
Date: Wed Dec 27 13:23:49 2017 +0100
Remove leading _ from some variable names
Change-Id: I640bf41ad073fcf1d5b8fcc55c63558f208db73d
diff --git a/svx/source/svdraw/svdmrkv.cxx b/svx/source/svdraw/svdmrkv.cxx
index 7b990127cd52
deletions(-)
New commits:
commit 20a646aeda7e940340b0ab11f243c0f09887e1b3
Author: Matteo Casalin
Date: Sun Jan 14 19:52:47 2018 +0100
Pointer is always non-null ==> use reference
Change-Id: I9ea6a8233a2f046d2ca56c08b3a2e922cbba2f3b
diff --git a/sw/source/core/tox/tox.cxx b/sw/sou
sfx2/source/dialog/filedlghelper.cxx |6 ++
sfx2/source/dialog/filedlgimpl.hxx |2 --
2 files changed, 2 insertions(+), 6 deletions(-)
New commits:
commit 0ff696769088c2da896130dc722662b39a4416e4
Author: Matteo Casalin
Date: Sun Mar 5 21:39:06 2017 +0100
No need to keep
Hi all,
I stumbled in the following code snippet in
SfxViewFrame::LoadViewIntoFrame_Impl:
OUString sURL( "private:object" );
if ( sURL.isEmpty() )
sURL = i_rDoc.GetFactory().GetFactoryURL();
in which the "if" test is obviously always false. I looked at how code
evolved du
--
11 files changed, 19 insertions(+), 22 deletions(-)
New commits:
commit b93a015f9bbed007a8800ef040ec2b6211d33858
Author: Matteo Casalin
Date: Thu Mar 16 21:21:25 2017 +0100
Use SfxObjectFactory::GetFactoryName/URL
instead of OUString::createFromAscii( GetShortName() ), in one
501 - 600 of 641 matches
Mail list logo
