[PUSHED] boost, orcus: disable bizarre auto link feature for MSVC:

2012-09-10 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/571 Objections: Kohei Yoshida: Do not submit -- To view, visit https://gerrit.libreoffice.org/571 To unsubscribe, visit

[PUSHED] Remove unnecessary #ifndef guards

2012-09-11 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/594 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/594 To unsubscribe,

[PUSHED] Modifying comments to meet doxygen standards

2012-09-11 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/596 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/596 To unsubscribe,

[PATCH] Change in core[libreoffice-3-6]: fdo#42450: fix crash in SwXTextSection::attach:

2012-09-12 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/602 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/02/602/1 fdo#42450: fix crash in SwXTextSection::attach: Inserting the section can fail if the given text range is not

[PATCH] Change in core[libreoffice-3-5]: fdo#42450: fix crash in SwXTextSection::attach:

2012-09-12 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/604 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/04/604/1 fdo#42450: fix crash in SwXTextSection::attach: Inserting the section can fail if the given text range is not

[PATCH] Change in core[libreoffice-3-6-2]: fdo#42450: fix crash in SwXTextSection::attach:

2012-09-13 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/607 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/07/607/1 fdo#42450: fix crash in SwXTextSection::attach: Inserting the section can fail if the given text range is not

[PUSHED] Change in core[libreoffice-3-6]: fdo#37529 clear DataColumns read-only information when we cl...

2012-09-13 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/608 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/608 To unsubscribe,

[PATCH] Change in core[libreoffice-3-6]: fdo#45700: sw ODF export: workaround corrupted table model:

2012-09-14 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/611 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/11/611/1 fdo#45700: sw ODF export: workaround corrupted table model: do not export invalid table:number-columns-spanned=0

[PATCH] Change in core[libreoffice-3-6]: fdo#30711: ODF export: text:name is mandatory on bookmarks...

2012-09-14 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/612 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/612/1 fdo#30711: ODF export: text:name is mandatory on bookmarks: XMLTextParagraphExport: Add a mapping that generates

[PATCH] Change in core[libreoffice-3-5]: fdo#45700: sw ODF export: workaround corrupted table model:

2012-09-14 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/613 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/613/1 fdo#45700: sw ODF export: workaround corrupted table model: do not export invalid table:number-columns-spanned=0

[PATCH] Change in core[libreoffice-3-6]: fdo#49677: ODF export: always add xlink:type attribute

2012-09-14 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/614 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/14/614/1 fdo#49677: ODF export: always add xlink:type attribute The xlink:type was optional on text:a and draw:a elements

[PATCH] Change in core[libreoffice-3-6]: fdo#49678: ODF export: add svg:viewBox to draw:connector

2012-09-14 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/616 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/16/616/1 fdo#49678: ODF export: add svg:viewBox to draw:connector This attribute is mandatory; for the given bugdoc

[PATCH] Change in core[libreoffice-3-5]: fdo#49678: ODF export: add svg:viewBox to draw:connector

2012-09-14 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/618 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/618/1 fdo#49678: ODF export: add svg:viewBox to draw:connector This attribute is mandatory; for the given bugdoc

[PATCH] Change in core[libreoffice-3-5]: fdo#49677: ODF export: always add xlink:type attribute

2012-09-14 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/615 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/615/1 fdo#49677: ODF export: always add xlink:type attribute The xlink:type was optional on text:a and draw:a elements

[PATCH] Change in core[libreoffice-3-5]: fdo#49876: ODF export: do not export font-size=0pt

2012-09-14 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/620 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/620/1 fdo#49876: ODF export: do not export font-size=0pt This is invalid, font size must be positive. Change-Id:

[PATCH] Change in core[libreoffice-3-6]: fdo#49876: ODF export: do not export font-size=0pt

2012-09-14 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/617 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/17/617/1 fdo#49876: ODF export: do not export font-size=0pt This is invalid, font size must be positive. Change-Id:

[PATCH] Change in core[libreoffice-3-6]: fdo#49571: ODF import: ignore text:enable-numbering attrib...

2012-09-14 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/619 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/619/1 fdo#49571: ODF import: ignore text:enable-numbering attribute It has been imported as an alien attribute since

[PATCH] Change in core[libreoffice-3-6]: rhbz#852128: sw: avoid table undo crash:

2012-09-18 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/640 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/640/1 rhbz#852128: sw: avoid table undo crash: SwUndoTblNdsChg::UndoImpl: to prevent access of deleted table box start

[PATCH] Change in core[libreoffice-3-5]: rhbz#852128: sw: avoid table undo crash:

2012-09-18 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/641 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/641/1 rhbz#852128: sw: avoid table undo crash: SwUndoTblNdsChg::UndoImpl: to prevent access of deleted table box start

[PUSHED] be consistent with configure's default and switch wrt gtk3

2012-09-18 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/642 -- To view, visit https://gerrit.libreoffice.org/642 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] mark configure's warning with some color

2012-09-18 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/643 -- To view, visit https://gerrit.libreoffice.org/643 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] Modifying comments to meet doxygen standards

2012-09-18 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/638 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/638 To unsubscribe,

[PATCH] Change in core[libreoffice-3-6]: rhbz#689053: fix crash following delete at last table cell:

2012-09-19 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/652 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/52/652/1 rhbz#689053: fix crash following delete at last table cell: The IsSelOvr() in SwCrsrShell::Combine() detects that

[PUSHED] Change in core[libreoffice-3-6]: Don't access broken service mgr during bootstrap failure

2012-09-20 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/654 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/654 To unsubscribe,

[PUSHED] Change in core[libreoffice-3-6]: Add RPATH to liblangtag

2012-09-20 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/661 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/661 To unsubscribe,

[PUSHED] Change in core[feature/killsdf]: Use po file for merge 1. step

2012-09-20 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/593 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/593 To unsubscribe,

[PATCH] Change in core[libreoffice-3-6]: rhbz#820283: fix crashes in DOCX table import:

2012-09-24 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/691 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/91/691/1 rhbz#820283: fix crashes in DOCX table import: It is apparently possible that writerfilter creates a table with

[PUSHED] Pyfax: Get rid of import * (1)

2012-09-24 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/685 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/685 To unsubscribe,

[PUSHED] pyfax: get rid of import * (2)

2012-09-24 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/686 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/686 To unsubscribe,

[PUSHED] pywizards: remove unused methods

2012-09-24 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/687 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/687 To unsubscribe,

[PATCH] add gb_StaticLibrary_use_static_libraries

2012-09-24 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/692 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/92/692/1 add gb_StaticLibrary_use_static_libraries ... which is probably not needed for LO internal code, but very useful

[PATCH] Change in core[libreoffice-3-6]: rhbz#827695: sw: prevent crashes after incomplete print:

2012-09-26 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/699 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/99/699/1 rhbz#827695: sw: prevent crashes after incomplete print: If the last page is not printed for whatever reason,

[PUSHED] use LibreOffice as the default value of ProductKey for cra...

2012-10-01 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/721 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/721 To unsubscribe,

[PUSHED] configure.in: edit message checking for new GStreamer 1.0

2012-10-01 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/722 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/722 To unsubscribe,

[PUSHED] Change in core[libreoffice-3-6]: fdo#52475 fix import of RTF_CHCBPAT with value 0

2012-10-01 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/740 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/740 To unsubscribe,

[PUSHED] Remove internal usage of rtl/memory.h in sal module

2012-10-01 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/744 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/744 To unsubscribe,

[PUSHED] Remove not used macros from lotusworkpro

2012-10-02 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/749 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/749 To unsubscribe,

[PUSHED] Remove dead code

2012-10-02 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/747 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/747 To unsubscribe,

[PUSHED] gbuildification of rhino

2012-10-02 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/752 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/752 To unsubscribe,

[PUSHED] gbuildification of languagetool

2012-10-03 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/753 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/753 To unsubscribe,

[PUSHED] don't pretend to be 1.4 compatible, when the baseline is 1.5

2012-10-03 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/758 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/758 To unsubscribe,

Change in core[libreoffice-3-6]: rhbz#820283: fix crashes in DOCX table import:

2012-10-04 Thread Michael Stahl (via Code Review)
Michael Stahl has abandoned this change. Change subject: rhbz#820283: fix crashes in DOCX table import: .. Patch Set 2: Abandoned the fix is bogus, thanks Noel for the check. see bug 55462 for details... -- To view, visit

[PATCH] Change in core[libreoffice-3-6]: rhbz#820283, fdo#55462: sw: better fix for DOCX table import...

2012-10-04 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/764 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/64/764/1 rhbz#820283, fdo#55462: sw: better fix for DOCX table import crash: The fix in

[PUSHED] sal_Bool - bool in comphelper

2012-10-04 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/763 -- To view, visit https://gerrit.libreoffice.org/763 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] sal_Bool - bool in comphelper

2012-10-04 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/762 -- To view, visit https://gerrit.libreoffice.org/762 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH] Change in core[libreoffice-3-6]: fdo#54648: WW8 export: test that FlyFrm actually has layout ...

2012-10-09 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/845 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/45/845/1 fdo#54648: WW8 export: test that FlyFrm actually has layout frm The bugdoc has 2 hidden drawing objects that are

[PATCH] Change in core[libreoffice-3-6]: add editeng::ConvertBorderWidthFromWord:

2012-10-09 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/846 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/46/846/1 add editeng::ConvertBorderWidthFromWord: Replace the 2 duplicate implementations of this in ww8 and writerfilter

[PATCH] Change in core[libreoffice-3-6]: fdo#55526: fix import of RTF \brdrhair:

2012-10-09 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/847 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/847/1 fdo#55526: fix import of RTF \brdrhair: This is a hairline border that should be mapped to a non-zero width

[PATCH] Change in core[libreoffice-3-6]: RepositoryExternal: internal libpng requires zlib as well

2012-10-09 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/848 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/48/848/1 RepositoryExternal: internal libpng requires zlib as well (cherry picked from commit

[PUSHED] Add a 'fromIndex' parameter to OUString::replaceAll

2012-10-09 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/768 -- To view, visit https://gerrit.libreoffice.org/768 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] String-OUString in tools::ErrorContext

2012-10-09 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/769 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/769 To unsubscribe,

[PUSHED] String-OUString in svl::SvNumberFormat::GetMappedFormatstri...

2012-10-09 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/770 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/770 To unsubscribe,

[PUSHED] String-OUString in svl::ImpSvNumFor::GetNewCurrencySymbol m...

2012-10-09 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/771 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/771 To unsubscribe,

[PUSHED] String-OUString in SVL::SvNumberFormat calendar methods

2012-10-09 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/772 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/772 To unsubscribe,

[PATCH libreoffice-4-0] fdo#61952: sw: fix left/right-only page styles and first-pag...

2013-03-15 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2764 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/64/2764/1 fdo#61952: sw: fix left/right-only page styles and first-page - remove PD_FIRST and GetFirstFmt: This flag

[PATCH libreoffice-3-6-6] fdo#58071: .dot files sometimes rejected by writer

2013-03-22 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2918 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/2918/1 fdo#58071: .dot files sometimes rejected by writer because CWW8 appears twice, once for normal .doc and once

[PATCH libreoffice-4-0] fdo#61429: Stylist: save selection of Hierarchical entry

2013-03-26 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3056 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/3056/1 fdo#61429: Stylist: save selection of Hierarchical entry This is unfortunately rather ugly because that one is

[PATCH libreoffice-4-0] fdo#60513: SwCrsrShell::Push(): take position from table cur...

2013-03-27 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3100 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/00/3100/1 fdo#60513: SwCrsrShell::Push(): take position from table cursor If there is a table cursor, store its

[PATCH libreoffice-3-6] fdo#61000: writerfilter: filter out unsupported list tab sto...

2013-02-28 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2465 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/2465/1 fdo#61000: writerfilter: filter out unsupported list tab stops Change-Id:

[PATCH libreoffice-4-0] fdo#61016: sw::marks::MarkManager: delay deletion of text fi...

2013-02-28 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2466 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/2466/1 fdo#61016: sw::marks::MarkManager: delay deletion of text fieldmarks There is a STL assertion in deleteMarks

[PATCH libreoffice-4-0] sw: remove CH_TXT_ATR_FORMELEMENT when CheckboxFieldmark is ...

2013-02-28 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2467 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/2467/1 sw: remove CH_TXT_ATR_FORMELEMENT when CheckboxFieldmark is deleted Change-Id:

[PUSHED] Fix typo persistant - persistant

2013-02-28 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2347 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2347 To unsubscribe,

[PATCH libreoffice-4-0] fdo#60886: _SetGetExpFlds: use the custom operator

2013-03-01 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2504 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/04/2504/1 fdo#60886: _SetGetExpFlds: use the custom operator The calls to upper_bound in SwDoc::FldsToExpand and

[PUSHED libreoffice-4-0] Package fonts to the fonts subpackage

2013-03-12 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2683 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2683 To unsubscribe,

[PUSHED libreoffice-4-0] Resolves: #i119658#, some Chinese numbering formats not supp...

2013-03-12 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2682 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2682 To unsubscribe,

[PATCH] Change in core[libreoffice-3-6]: fdo#58142: fix frame selection in SwPageFrm::GetCrsrOfst:

2012-12-13 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1314 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/14/1314/1 fdo#58142: fix frame selection in SwPageFrm::GetCrsrOfst: The function does not handle the case where a

[PUSHED] fdo#58196 Viewing: Reenable mirroring for scaled-down images

2012-12-17 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1332 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1332 To unsubscribe,

[PATCH] fdo#38090: vcl: remove ImplFontCache::maFontNameList:

2012-12-19 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1424 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/24/1424/1 fdo#38090: vcl: remove ImplFontCache::maFontNameList: The font cache in VCL returns different fonts for

[PUSHED] fdo#38090: vcl: remove ImplFontCache::maFontNameList:

2012-12-21 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1424 -- To view, visit https://gerrit.libreoffice.org/1424 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH] Change in core[libreoffice-3-6]: fdo#47553: UniscribeLayout: adjust mnSubStringMin

2012-12-21 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1467 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/1467/1 fdo#47553: UniscribeLayout: adjust mnSubStringMin ... to actual minimum so that the fix for fdo#33090 in

[PATCH] Change in core[libreoffice-3-6]: rhbz#890080: crash in SwXTextDocument::getRendererCount

2013-01-04 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1546 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/46/1546/1 rhbz#890080: crash in SwXTextDocument::getRendererCount No idea how to reproduce it; pSwView is checked before

[PATCH] Change in core[libreoffice-3-6]: rhbz#891082: CMXDocument::isSupported: catch exceptions

2013-01-04 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1547 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/1547/1 rhbz#891082: CMXDocument::isSupported: catch exceptions (cherry picked from commit

[PUSHED] Code enhancement remove duplicate code from presenter consol...

2013-01-07 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1480 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1480 To unsubscribe,

[PUSHED] Cleanup: #include tools/gen.hxx

2013-01-07 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1484 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1484 To unsubscribe,

[PUSHED] Fix calls to SfxPoolItem* Put with a Which-ID of sal_false

2013-01-07 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1499 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1499 To unsubscribe,

[PUSHED] fdo#57203 Unknown option: -Embedding

2013-01-07 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1514 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1514 To unsubscribe,

[PUSHED] Fix wrong bracketing

2013-01-07 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1498 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1498 To unsubscribe,

[PUSHED] fdo#53521 Crash when running BASIC's shell() with a non-ex...

2013-01-07 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1530 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1530 To unsubscribe,

[PUSHED] Bugfix for improper function call, column count was compared...

2013-01-07 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1562 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1562 To unsubscribe,

[PUSHED] typo fix

2013-01-07 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1563 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1563 To unsubscribe,

[PATCH] Change in core[libreoffice-3-6]: fdo#58242: sw: fix more crashes when not on SwTxtNode

2013-01-09 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1615 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/1615/1 fdo#58242: sw: fix more crashes when not on SwTxtNode In getCrsrPropertyValue etc.; also add a unit test for

[PUSHED] Change in core[libreoffice-3-6]: fdo#58933 RTF import: avoid fake pars / cells when having gr...

2013-01-09 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1618 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1618 To unsubscribe,

[PUSHED] Change in core[libreoffice-4-0]: fdo#58933 RTF import: avoid fake pars / cells when having gr...

2013-01-09 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1617 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1617 To unsubscribe,

[PUSHED] Use forward declaration instead of (doubled) #include

2013-01-11 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1642 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1642 To unsubscribe,

[PUSHED] Character conversion: do not destroy sequence while iteratin...

2013-01-11 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1636 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1636 To unsubscribe,

[PUSHED] Remove unused class members

2013-01-11 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1638 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1638 To unsubscribe,

[PATCH] Change in core[libreoffice-4-0]: fdo#59249: mailmerge.py: adapt to changes in smtplib:

2013-01-14 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1669 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/1669/1 fdo#59249: mailmerge.py: adapt to changes in smtplib: Apparently the login() method in Python 3.3 expects str

[PUSHED] Change in core[libreoffice-4-0]: docx export: add missing arg to impl_pageBorders call

2013-01-14 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1672 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1672 To unsubscribe,

[PUSHED] Change in core[libreoffice-4-0]: Resolves: fdo#58324 keep both halves of surrogate pairs if g...

2013-01-14 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1676 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1676 To unsubscribe,

[PATCH] Change in core[libreoffice-3-6]: fdo#59366: Document Conversion wizard: enable StarOffice a...

2013-01-14 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1677 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/77/1677/1 fdo#59366: Document Conversion wizard: enable StarOffice again: The createBF_MigrateFilterIfPossible function

[PUSHED] fdo#40465 solve regression when zooming with cursor not visi...

2013-01-15 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1694 -- To view, visit https://gerrit.libreoffice.org/1694 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH] Change in core[libreoffice-3-6-5]: fdo#40465 solve regression when zooming with cursor not visi...

2013-01-15 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1698 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/98/1698/1 fdo#40465 solve regression when zooming with cursor not visible (cherry picked from commit

[PUSHED] Change in core[libreoffice-4-0]: fix mailmerge output as plain text, explicitly pick correct ...

2013-01-15 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1697 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1697 To unsubscribe,

[PUSHED] Change in core[libreoffice-4-0]: make emailmerge work with python3 and python2 at the same ti...

2013-01-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1713 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1713 To unsubscribe,

[PATCH] Change in core[libreoffice-4-0]: rhbz#818557: fix it differently: SwDocShell::_LoadStyles():

2013-01-16 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1722 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/1722/1 rhbz#818557: fix it differently: SwDocShell::_LoadStyles(): Try to prevent pushing of SfxShells from this

[PATCH] Change in core[libreoffice-4-0]: fdo#58893: Revert Resolves: rhbz#818557 crash with NULL she...

2013-01-16 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1721 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/21/1721/1 fdo#58893: Revert Resolves: rhbz#818557 crash with NULL shell... This reverts commit

[PATCH] Change in core[libreoffice-3-6]: fdo#58893: Revert Resolves: rhbz#818557 crash with NULL she...

2013-01-16 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1723 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/1723/1 fdo#58893: Revert Resolves: rhbz#818557 crash with NULL shell... This reverts commit

[PATCH] Change in core[libreoffice-3-6]: rhbz#818557: fix it differently: SwDocShell::_LoadStyles():

2013-01-16 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1724 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/24/1724/1 rhbz#818557: fix it differently: SwDocShell::_LoadStyles(): Try to prevent pushing of SfxShells from this

[PATCH] Change in core[libreoffice-4-0]: fdo#59428: SwPageDesc::GetUseOn(): mask PD_FIRSTSHARE.

2013-01-17 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1748 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/48/1748/1 fdo#59428: SwPageDesc::GetUseOn(): mask PD_FIRSTSHARE. There is at least one call in SwDoc::ChgPageDesc()

[PATCH] Change in core[libreoffice-4-0]: fdo#59437: SwFmtAnchor::SetAnchor: Anchors may be on StartNo...

2013-01-17 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1747 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/1747/1 fdo#59437: SwFmtAnchor::SetAnchor: Anchors may be on StartNodes Assertion added in

  1   2   3   >