Re: [Libreoffice] [PATCH][PUSHED] Replace ENSURE_OR_* macros with regular code.

2012-01-24 Thread Stephan Bergmann
[This should have gone out last night already, somehow didn't make it off my computer.] On 01/23/2012 11:08 AM, Marcel Metz wrote: I oppose to the macros improve readability argument, these macros don't improve readability, they hide some regular execution from the programmer. You would need

Re: [Libreoffice] [PATCH][PUSHED] Replace ENSURE_OR_* macros with regular code.

2012-01-24 Thread Marcel Metz
Hello Stephan, On 24.01.2012 09:30, Stephan Bergmann wrote: However, I have another question: I notice that, while most occurrences are replaced with SAL_WARN, some were left as OSL_ENSURE (which I changed to SAL_WARN; one missed a comma, anyway) and some are changed to SAL_INFO. Was there