Re: [Libreoffice] prevent the creation of lockfiles during unit tests

2012-01-15 Thread Stephan Bergmann
On 01/13/2012 05:08 AM, Markus Mohrhard wrote: I did not push that patch directly because I'm not sure if we really want to introduce another registry entry for this. After seeing the patch pushed, it occurred to me that we usually use env vars (instead of configuration settings etc.) to

Re: [Libreoffice] prevent the creation of lockfiles during unit tests

2012-01-13 Thread Stephan Bergmann
On 01/13/2012 05:08 AM, Markus Mohrhard wrote: I did not push that patch directly because I'm not sure if we really want to introduce another registry entry for this. No idea about that either (I think Michael Stahl has previously been exposed heavily to locking, maybe he has some input),

Re: [Libreoffice] prevent the creation of lockfiles during unit tests

2012-01-13 Thread Michael Meeks
Hi guys, Markus - nice catch - really cool to get that nailed :-) On Fri, 2012-01-13 at 09:05 +0100, Stephan Bergmann wrote: bool IsLockingUsed() { return officecfg::Office::Common::Misc::UseLocking::get( comphelper::getProcessComponentContext()); } (I haven't

Re: [Libreoffice] prevent the creation of lockfiles during unit tests

2012-01-13 Thread Markus Mohrhard
Hello Stephan No idea about that either (I think Michael Stahl has previously been exposed heavily to locking, maybe he has some input), just two comments on the patch: +bool IsLockingUsed() +{ +    bool bLocking = true; +    try +    { + +        uno::Reference uno::XInterface

Re: [Libreoffice] prevent the creation of lockfiles during unit tests

2012-01-13 Thread Stephan Bergmann
On 01/13/2012 11:23 AM, Michael Meeks wrote: Oooh ! :-) it looks really rather nice; how efficient is the compiled representation ? hopefully much more so than the big chunks of in-lined UNO-ness that existing code uses :-) It still uses UNO to access configmgr, but through a

[Libreoffice] prevent the creation of lockfiles during unit tests

2012-01-12 Thread Markus Mohrhard
Hey, I finally found a solution to the lockfile problem. The attached patch prevents lockfiles during unit tests. I did not push that patch directly because I'm not sure if we really want to introduce another registry entry for this. If this is the correct patch i would like to push that to