Re: [PUSHED] Turn on strictures for some installer Perl modules

2012-02-16 Thread Tim Retout
On 15 February 2012 11:58, Michael Meeks michael.me...@suse.com wrote:        Also the 'make_installer.pl' takes about 20 options, AFAIR there are however only a few legitimate parameters / configurations that are possible in the LibreOffice world.        So - digging out the call sites

Re: [PUSHED] Turn on strictures for some installer Perl modules

2012-02-16 Thread Michael Meeks
Hi Tim, On Thu, 2012-02-16 at 11:08 +, Tim Retout wrote: Ah, thanks for pointing me to that. There's some nice cleanup possible in installer::parameter. :-) make cmd cmd=solenv/bin/ooinstall ... Running this under Devel::NYTProf, I found that a good deal of the

[PUSHED] Turn on strictures for some installer Perl modules

2012-02-15 Thread Michael Meeks
Hi Tim ! On Tue, 2012-02-14 at 23:02 +, Tim Retout wrote: I'd like to try to clean up some of the code in the solenv Perl modules Cool ! it is long overdue. - as a first task, I want to turn on 'use strict', which I'd consider a bare minimum for maintainable Perl. Longer-term,