Re: [REVIEW-3-6] fix for fdo#52351, remove conditional formatting if all its cells are removed

2012-08-06 Thread Kohei Yoshida
Hi Markus, On Sun, Aug 5, 2012 at 8:29 AM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: [1] is mostly a fix for a strange behavior of ScRangeList which affects also conditional formats. ScRangeList did not delete a ScRange if UpdateReference removed all the ScRange cells. The second

Re: [REVIEW-3-6] fix for fdo#52351, remove conditional formatting if all its cells are removed

2012-08-06 Thread Stephan Bergmann
On 08/06/2012 04:08 PM, Kohei Yoshida wrote: Regarding iterator itr = begin(); while(itr != end()) { if(itr-GetRange().empty()) maConditionalFormats.erase(itr++); else ++itr; } that erase line

Re: [REVIEW-3-6] fix for fdo#52351, remove conditional formatting if all its cells are removed

2012-08-06 Thread Kohei Yoshida
On Mon, Aug 6, 2012 at 11:21 AM, Stephan Bergmann sberg...@redhat.com wrote: On 08/06/2012 04:08 PM, Kohei Yoshida wrote: Regarding iterator itr = begin(); while(itr != end()) { if(itr-GetRange().empty())

[REVIEW-3-6] fix for fdo#52351, remove conditional formatting if all its cells are removed

2012-08-05 Thread Markus Mohrhard
Hey, [1] is mostly a fix for a strange behavior of ScRangeList which affects also conditional formats. ScRangeList did not delete a ScRange if UpdateReference removed all the ScRange cells. The second step of the patch is to remove the conditional formatting if the ScRangeList is empty after