https://bugs.freedesktop.org/show_bug.cgi?id=79023
Priority: medium
Bug ID: 79023
CC: er...@redhat.com
Assignee: libreoffice-bugs@lists.freedesktop.org
Summary: ScCompiler slowness ...
Severity: normal
Classification: Unclassified
OS: All
Reporter: michael.me...@collabora.com
Hardware: Other
Status: NEW
Version: 4.2.4.1 rc
Component: Libreoffice
Product: LibreOffice
It seems the ScCompiler burns 7% of load-time of my (large - 227bn
pseudo-cycles) of startup/load time inside 'IsValue'.
I attach a photo of the fun in action =)
Apart from the slow 'uppercase' call (did ScCompiler:: already uppercase the
string - duplicating it in the process ?) - we seem have an:
'IsNumber' function that spends most of its time in:
SvNumberFormatter::IsNumberFormat
which seems to do an extraordinary amount of hard work =) is that truly
necessary for parsing formulae from the file-format rather than exotic user
inputs ? =)
ie. would some:
if (FormulaGrammar::isODFF( eGrammar ))
followed by "is it a flat integer" work nicely there ? ;-)
Thoughts appreciated =)
I suspect the real win here comes from not parsing the formulae at all, but
printing and comparing them down the column to catch long repeated columns full
of ~identical formulae =) [ in the XLSX import this gave a very significant win
]
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
