https://bugs.freedesktop.org/show_bug.cgi?id=86929
Bug ID: 86929
Summary: Kill FOREACHPAM_START for good
Product: LibreOffice
Version: unspecified
Hardware: Other
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: Writer
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: bjoern.michael...@canonical.com
FOREACHPAM_START/FOREACHPAM_END were horrible macros that iterated over a Ring.
With the new sw::Ring class in sw/inc/ring.hxx having proper iterators, they
are obsolete and can be replaced with standard BOOST_FOREACH (and hopefully one
day directly with C++11s for( : ) iteration.
For now, lets kill FOREACHPAM_START/FOREACHPAM_END like done in e.g.:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=2b433d87525918bf8d51fe164ffea9c9099b52ce
While doing that, please look out for opportunities to use more constness in
the iteration: The old macros carelessly did cast away constness, so check if
there is room for improvement there.
Bonus points for walking through general calls to sw::Ring<>s
GetPrev()/GetNext() which are now stronger typed (returning a SwPaM* or
SwViewShell*) and check if there now is superfluous casting there that can be
removed.
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
