Re: [Libreoffice-ux-advise] [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

2012-02-13 Thread Noel Power
On 09/02/12 14:53, Albert Thuswaldner wrote: Hi, [...] So I have improved the patch according to Kohei's suggestion above. Now I store the prefix at each key-stroke and check for illegal characters. When an illegal character is entered, the text is reverted back to the last good prefix. (So

Re: [Libreoffice-ux-advise] [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

2012-02-13 Thread Noel Power
On 09/02/12 14:53, Albert Thuswaldner wrote: If it was up to me I would go for the visual bell. Any thoughts on this? actually thinking about it some more I don't find it unnatural to have the whole ( reverted ) prefix selected after entering an illegal character ( I think this is a technique

Re: [Libreoffice-ux-advise] [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

2012-02-13 Thread Albert Thuswaldner
On Mon, Feb 13, 2012 at 12:23, Noel Power nopo...@suse.com wrote: On 09/02/12 14:53, Albert Thuswaldner wrote: 2) When trying to delete text in the edit box, the last character sticks (can't be deleted). well that would seem to be because your code thinks a blank prefix is illegal, I

Re: [Libreoffice-ux-advise] [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

2012-02-09 Thread Albert Thuswaldner
Hi, Given that, I still think it's better (and easier) to check for every key-press, but instead of launching an error dialog for an illegal name, just put the old legal name back into the text box and sound an beep or something.  That's less intrusive than a big dialog being thrown right

Re: [Libreoffice-ux-advise] [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

2012-02-09 Thread Stefan Knorr (Astron)
Hi Albert, At least I get two annoying bugs: 1) The cursor moves In front of the text when the Prefix is reverted. 2) When trying to delete text in the edit box, the last character sticks (can't be deleted). Does someone have a clue whats going on? Hm, no (not a coder I am). But can you