Re: [Libreoffice] Fwd: Re: patch for scan-diialog

2011-10-19 Thread Markus Mohrhard
Hello Rob, I only did a quick check but it seems that you are missing the implementation. I think you need to adjust scanner.hxx:64 and the corresponding parts in this class. Then I saw that you are still using sal_Bool. We try to switch to bool where it is possible that means in most places

Re: [Libreoffice] make check fails in ScFiltersTest

2011-10-20 Thread Markus Mohrhard
Hello Regina, could you apply these two patches, rebuild sc and post the log file: workdir/unxlngx6.pro/CppunitTest/sc_filters_test.test.log where unxlngx6.pro is the corresponding windows folder. http://cgit.freedesktop.org/libreoffice/core/commit/?id=cda653d7d9038fdcab72cfcae37d3d20463693d5

Re: [Libreoffice] make check fails in ScFiltersTest

2011-10-20 Thread Markus Mohrhard
Hello Regina, 2011/10/20 Regina Henschel rb.hensc...@t-online.de: Hello Markus, Markus Mohrhard schrieb: Hello Regina, could you apply these two patches, rebuild sc and post the log file: workdir/unxlngx6.pro/CppunitTest/sc_filters_test.test.log where unxlngx6.pro is the corresponding

Re: [Libreoffice] make check fails in ScFiltersTest

2011-10-20 Thread Markus Mohrhard
Hello Regina, 2011/10/20 Regina Henschel rb.hensc...@t-online.de: Hi Markus, Markus Mohrhard schrieb: Hello Regina, 2011/10/20 Regina Henschelrb.hensc...@t-online.de: Hello Markus, Markus Mohrhard schrieb: Hello Regina, could you apply these two patches, rebuild sc and post the log

[Libreoffice] maybe clean rebuild needed

2011-10-21 Thread Markus Mohrhard
Hey, I just enabled the macro's test in calc again and it seems that in some situations we get a deadlock in the first incremental build after the patch. If you observe that in your build, do a make clean and the next make should execute the test without a problem. If you still get problem after

Re: [Libreoffice] [PUSHED] String::CompareIngoreCaseToAscii

2011-10-21 Thread Markus Mohrhard
Hello Michael, August, 2011/10/21 Michael Meeks michael.me...@suse.com: Hi August, On Fri, 2011-10-21 at 08:50 -0400, August Sodora wrote: Thanks to all for being so patient with me! Would it be worthwhile to continue working on the mess that is scanner/tokenizer/parser (why do they inherit

Re: [Libreoffice] make check fails in ScFiltersTest

2011-10-24 Thread Markus Mohrhard
Hey, 2011/10/24 Eike Rathke er...@redhat.com: Hi, On Thursday, 2011-10-20 23:53:39 +0200, Markus Mohrhard wrote: Kohei, Eike: Any ideas why our xls import of these cells goes wrong in a windows build. It seems that none of our Linux or mac builds has a problem with this cell import. I'm

Re: [Libreoffice] how to 'make' a single target?

2011-10-29 Thread Markus Mohrhard
Hello Kevin, 2011/10/30 Kevin Hunter hunt...@earlham.edu: Hullo List, I'm currently working in the sc/ module, and I'm in the make small change, re-compile, make small change, re-compile stage.  This is proving very cumbersome, however, as I'm unable to re-make just the affected files.  For

[Libreoffice] [REVIEW] fix for fdo#40967: or and and won't work correctly in array formulas

2011-11-01 Thread Markus Mohrhard
From: Markus Mohrhard markus.mohrh...@googlemail.com Date: Tue, 1 Nov 2011 17:08:19 +0100 Subject: [PATCH] boolean values are valid for matrix evaluation (fdo#49967) --- sc/source/core/tool/scmatrix.cxx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sc/source/core/tool

Re: [Libreoffice] [REVIEW 3-4] [PUSHED] Fix incorrect mapping of external ranges

2011-11-01 Thread Markus Mohrhard
Looks safe and correct to me. I'll push it to the 3-4 branch with my sign-off. 2011/11/1 Kohei Yoshida kohei.yosh...@suse.com: Hi there, I'd like to have http://cgit.freedesktop.org/libreoffice/core/commit/?id=5d02007469d84b248bb623196cca95d431f7ed11 backported to the 3-4 branch.  It fixes

Re: [Libreoffice] some hints needed for fdo 42286 in calc

2011-11-01 Thread Markus Mohrhard
Hello, 2011/11/1 Pierre-André Jacquod pjacq...@alumni.ethz.ch: hello, I am trying to debug fdo 42286 in calc. It has to do with autofilter, where some empty lines (rows) are shown despite the filter criteria that is set. (and a strange filter behaviour). As entry point, I found sc/..

[Libreoffice] [REVIEW] fix for fdo#41807 crash with ROW() or COLUMN() in matrix formulas

2011-11-01 Thread Markus Mohrhard
Hey, http://cgit.freedesktop.org/libreoffice/core/commit/?id=cf0dd2113527ba0a601c5c59de7f7f44da161d21 fixes a crash that happens if you use ROW() or COLUMN() in a matrix function. We try to get an entry from an empty mdds container which results in a crash. Even that we are not sure that return

Re: [Libreoffice] [REVIEW] fix for fdo#41807 crash with ROW() or COLUMN() in matrix formulas

2011-11-02 Thread Markus Mohrhard
Hello Kohei, Eike 2011/11/2 Kohei Yoshida kohei.yosh...@suse.com: On Wed, 2011-11-02 at 12:39 +0100, Markus Mohrhard wrote: Pushed a fix to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=b03e931439c54f4abaa520cf11ed24560ca1709a. Could anyone push that to the 3-4 branch

Re: [Libreoffice] build fail in tail_build InvalidRegistryException in ScFiltersTest::testCVEs

2011-11-08 Thread Markus Mohrhard
Hello Caolan, 2011/11/8 Caolán McNamara caol...@redhat.com: On Tue, 2011-11-08 at 11:26 +, Michael Meeks wrote: Hi Noel,       This does look interesting :-) thanks for the trace. On Tue, 2011-11-08 at 09:26 +0200, Noel Grandin wrote: Test name: ScFiltersTest::testCVEs setUp()

Re: [Libreoffice] [PATCH] Added line numbers to the basic ide

2011-11-11 Thread Markus Mohrhard
Hey, to make it easier for everyone I pushed it to a feature branch. The new feature branch for this is: feature/line-numbers-in-basicIDE. As soon as you get your commit access by Michael, you can work on this branch without to worry about the master branch too much. Markus

Re: [Libreoffice] [PATCH][PLEASE REVIEW] Remove String::Fill() usage

2011-11-12 Thread Markus Mohrhard
Hello Christina, 2011/11/12 Chr. Rossmanith chrrossman...@gmx.de: To add some information: LibO builds fine but I keep getting failed tests in the end: make[1]: *** [/Space/LibreOffice_OneGit/core/workdir/unxlngi6.pro/CppunitTest/sc_filters_test.test] Fehler 1 It's ./sc where I made

[Libreoffice] add sqlite path to library path for unit tests

2011-11-14 Thread Markus Mohrhard
Hey, could someone without system libsqlite give the following patch a try. Apply and rebuild sc. In theory the testPassword test should work without a problem. Thanks a lot for your help Markus From fc3316ac36beacf49fad044563dd8b3ea7967172 Mon Sep 17 00:00:00 2001 From: Markus Mohrhard

Re: [Libreoffice] .: bin/get-bugzilla-attachments-by-mimetype

2011-11-21 Thread Markus Mohrhard
2011/11/21 Caolán McNamara caol...@redhat.com: On Mon, 2011-11-21 at 02:04 +0100, Miklos Vajna wrote: On Mon, Nov 14, 2011 at 02:37:07AM -0800, Caolán McNamara cao...@kemper.freedesktop.org wrote:     add script to download documents from various bugzillas Which reminds me, if someone

Re: [Libreoffice] .: bin/get-bugzilla-attachments-by-mimetype

2011-11-21 Thread Markus Mohrhard
2011/11/21 Caolán McNamara caol...@redhat.com: On Mon, 2011-11-21 at 11:24 +0100, Markus Mohrhard wrote:  Big thanks from me too.  And just for the record all ods, xls and xlsx documents are tested with master. Really?, wow. i.e. every .ods, .xls and .xlsx available from freedesktop

Re: [Libreoffice] .: bin/get-bugzilla-attachments-by-mimetype

2011-11-21 Thread Markus Mohrhard
Hello Eike, 2011/11/21 Eike Rathke er...@redhat.com: Hi Markus, On Monday, 2011-11-21 12:40:11 +0100, Markus Mohrhard wrote: Not every document is crash free. We have 15 documents that either froze during the import or crashed calc. I have sent the list to Eike and Kohei and have already

Re: [Libreoffice] .: bin/get-bugzilla-attachments-by-mimetype

2011-11-21 Thread Markus Mohrhard
Hey, 2011/11/21 Kohei Yoshida kohei.yosh...@suse.com: On Mon, 2011-11-21 at 13:14 +0100, Markus Mohrhard wrote: If everyone is fine with the idea of putting the informatio in bugzilla I'll do that later today. All information are now in bugzilla as fdo#43152. I need to test each document

Re: [Libreoffice] how to acquire an ScDocument reference from scratch

2011-11-23 Thread Markus Mohrhard
Hello Kevin, 2011/11/23 Kevin Hunter hunt...@earlham.edu: Hello List, I'm trying to get hold of an ScDocument from scratch.  I have naively attempted to replicate another section of code, but for the life of me can't figure out what I'm missing.  My code crashes with a SIGSEGV on this line:

Re: [Libreoffice] how to acquire an ScDocument reference from scratch

2011-11-23 Thread Markus Mohrhard
2011/11/24 Kevin Hunter hunt...@earlham.edu: At 7:56pm -0500 Wed, 23 Nov 2011, Markus Mohrhard wrote: Can you explain in a bit more detail what you want to do. You can't just create a new ScDocShell, you always need to do some initialisation before. Depending on what you want to do you should

Re: [Libreoffice] [PUSHED] more translations in VCL

2011-11-26 Thread Markus Mohrhard
Hello Luc, 2011/11/25 Luc Castermans luc.casterm...@gmail.com: Gents, As promised ( to Michael) herewith 3 more file translations in  the VCL module many more to do.. As before (again repeating) my  contributions are under LGPL3/MPL. I hope you mean LGPLv3+/MPL. I just had a look at

[Libreoffice] concept for c++ based subsequenttests

2011-11-30 Thread Markus Mohrhard
debugging subsequenttests easier and writing new tests as easy as writing in-build tests. Do you have comments or suggestions? Regards, Markus From bbce3329e791a0c9c5c1594bc215c466c3bfb294 Mon Sep 17 00:00:00 2001 From: Markus Mohrhard markus.mohrh...@googlemail.com Date: Wed, 30 Nov 2011 14:40:29 +0100

Re: [Libreoffice] concept for c++ based subsequenttests

2011-11-30 Thread Markus Mohrhard
Hey, thanks a lot for your answers. 2011/11/30 Michael Stahl mst...@redhat.com: - having test files instead of code that fills the cells make it easier to use the test data outside of the test ( e.g. debugging a problem, having a testdocument with known result for some actions) hmm... am

Re: [Libreoffice] concept for c++ based subsequenttests

2011-11-30 Thread Markus Mohrhard
Hey, IMHO the pragmatic solution to this is to run them as subsequentests when dependencies are getting ugly. Writing them in sane C++ is of course better that using Junit, but nontrivial tests depending on the full product is not a big bug IMHO. I think by now pretty much everyone builds a

Re: [Libreoffice] concept for c++ based subsequenttests

2011-11-30 Thread Markus Mohrhard
Hey, Looks very promising.  Just one minor comment, I would move away from the unoapi name (and corresponding qa/unoapi directory).  The concept of the qadevOOo unoapi tests was to use more-or-less generic code to test all the interfaces of all the UNO objects exposed by OOo (so that all the

[Libreoffice] setting the background color of an Edit

2011-12-03 Thread Markus Mohrhard
Hey, I'm trying to set the background color of an Edit in the code but I failed with Window::SetControlBackground, Window::SetControlForeground and throught the OutputDevice::SetBackground, OutputDevice::SetFillColor methods. Do you have any ideas? Regards, Markus

Re: [Libreoffice] setting the background color of an Edit

2011-12-04 Thread Markus Mohrhard
Hello Kohei, You are almost there.  IIRC there is some quirk with setting a background color with the Edit control; you need to set fore ground color before setting the background color in order to change the background color.  No idea whether it's a bug or not (I think it is), but that's

Re: [Libreoffice] Make check from master fails in sc_datapilotfieldobj

2011-12-08 Thread Markus Mohrhard
Hello Alex, My understanding was that this was fixed according to : https://bugs.freedesktop.org/show_bug.cgi?id=43308#c9 Seems to have come back. It is fixed and it seems that you have a problem laoding the testfile. Can you check that you can open

Re: [Libreoffice] Make check from master fails in sc_datapilotfieldobj

2011-12-08 Thread Markus Mohrhard
Hello Michael, of course there is:            PropertyValue[] loadProps = new PropertyValue[1];            loadProps[0] = new PropertyValue();            loadProps[0].Name = ReadOnly;            loadProps[0].Value = new Boolean(true); now pass that as the last argument to

[Libreoffice] [PATCH] fix for crash in math.cxx for std::numeric_limitsint::min

2011-12-12 Thread Markus Mohrhard
but it would be good if someone could have a look at it. Regards, Markus From f3f36bb41509a3dc72f170b141c06a6de1dd52fa Mon Sep 17 00:00:00 2001 From: Markus Mohrhard markus.mohrh...@googlemail.com Date: Tue, 13 Dec 2011 00:09:42 +0100 Subject: [PATCH] fix crash for std::numeric_limitsint::min

Re: [Libreoffice] [PATCH] fix for crash in math.cxx for std::numeric_limitsint::min

2011-12-13 Thread Markus Mohrhard
Hello Kohei, I would be interested to know how to reproduce this crash.  Do you have a good way to reproduce this? Try fdo#43703 in master. This bug shows two problems. Firstly the problem in math.cxx and secondly as already done with

Re: [Libreoffice] Dangling symlinks (was: make dev-install hangs)

2011-12-14 Thread Markus Mohrhard
Hey, These are dangling symlinks such as test/user-template/user/config/images_tango.zip - /devel/libo/libo1/packimages/unxlngx6.pro/bin/images_tango.zip Any reason they were added to the repository? Or can they be safely removed? Will be fixed in some minutes.

Re: [Libreoffice] getting debug symbols when running build unit tests under gdb?

2011-12-14 Thread Markus Mohrhard
Hello Noel, his is under Ubuntu Linux. I'm trying to track down a stack overflow in my code, and I'm having some trouble running the unit tests under GDB and getting debugging symbols. I'm doing   EXPORT GDBCPPUNITTRACE=gdb --args then running the module build under /sc   build and then

Re: [Libreoffice] getting debug symbols when running build unit tests under gdb?

2011-12-14 Thread Markus Mohrhard
Hello Noel, Do you know of any trick for catching stack-overflow problems? The trick I'm using is pretty painful. Did you try to run the tests with memcheck? If you do some serious rework in calc it would be nice if you could as soon as the normal unit tests pass run them one time with

Re: [Libreoffice] [PATCH] removing mpNotes field from ScBaseCell

2011-12-17 Thread Markus Mohrhard
Hello Noel, So I've been working on this patch to move mpNotes from ScBaseCell to ScTable, and I got it mostly working. But I was struggling with leaks and getting the lifecycle of the notes to exactly match the lifecycle of the ScBaseCell object. I think that we should go another way.

Re: [Libreoffice] [PATCH] removing mpNotes field from ScBaseCell

2011-12-17 Thread Markus Mohrhard
Hello Noel, 2011/12/17 Noel Grandin noelgran...@gmail.com: Hi Yeah, that is what I tried the first time. But it turns out to be incredibly hard to keep the lifecycle of the ScBaseCell objects and the lifecycle of the ScPostIt objects tied together, because ScBaseCell and it's child classes

Re: [Libreoffice] [PATCH] removing mpNotes field from ScBaseCell

2011-12-18 Thread Markus Mohrhard
Hello Noel, 2011/12/18 Noel Grandin noelgran...@gmail.com: Hi The problem with doing the logic in ScTable is that an ScPostIt on an otherwise empty cell still needs an ScNoteCell object to exist. No. With this work we want to get rid of ScNoteCell. That is one of the goals of this work.

[Libreoffice] Notifications between different SfxObjectShells

2011-12-18 Thread Markus Mohrhard
Hey, I'm trying to improve calc's copy behavior but I'm a bit stuck with the last step. I need to get a notification if another document is being saved because I may need to adjust the reference to this document. I found already SfxEventHint which broadcasts all relevant information but only to

Re: [Libreoffice] calc: Re: com.sun.star.container.XNameContainer.removeByName() fails v3.5b0+ (linux)

2011-12-19 Thread Markus Mohrhard
Hey, let me check that. If it is a bug I'll create a test and fix it for beta3. Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] calc: Re: com.sun.star.container.XNameContainer.removeByName() fails v3.5b0+ (linux)

2011-12-19 Thread Markus Mohrhard
Hello Tomas, Ok, I wrote a simple c++ based test for that and can't reproduce your problem. The test ( http://cgit.freedesktop.org/libreoffice/core/commit/?id=b77902d38d06df87694564ded859733bdb1d4fb2 ) creates an empty document, checks that it has a second sheet( bad assumption there from me)

Re: [Libreoffice] calc: Re: com.sun.star.container.XNameContainer.removeByName() fails v3.5b0+ (linux)

2011-12-20 Thread Markus Mohrhard
Hello Tomas, 2011/12/20 Michael Stahl mst...@redhat.com: On 20/12/11 14:52, Tomas Hlavaty wrote: could you please advise me how to build and run the test case? I did: $ cd sc/ $ make and it built the tests. It seems to have run something called CHK from the console log, but where

Re: [Libreoffice] consistent SCCOL use?

2011-12-20 Thread Markus Mohrhard
Hello Kevin, A quick question to any more-knowledgeable-than-me person on whether there's a reason these spots in the calc code base are hard-coded to sal_Int16, It is sal_uInt16 which is not the same as SCCOL. rather than using SCCOL? There are 3 different cases here: - pivot.hxx may

Re: [Libreoffice] [Patch] [Review 3.5 - Late Feature] Improved copying between different calc documents

2012-01-04 Thread Markus Mohrhard
Hello Eike, We talked about that before Christmas (actually I thought that would be already in 3-5 now), and yes, this feature makes sense when copying between documents. After I had to enable the external references to unsaved documents through direct input I was not sure if it is not a new

[Libreoffice] limiting maximum sheet number to 10000 in 32 bit builds

2012-01-05 Thread Markus Mohrhard
Hey, I'm sorry but I have to correct one of our features from the release note page. After some discussion I need to limit the maximum amount of sheets in 32 bit builds to 1 sheets. That should still be much more than most people will ever need but we had some adventurous users who tried to

[Libreoffice] Licence statement

2012-01-06 Thread Markus Mohrhard
Hey, just in case that I really did not yet sent a licence statement. I provide all past and all future contributions to Libreoffice under the terms of the LGPLv3+ and MPL license. Regards, Markus ___ LibreOffice mailing list

[Libreoffice] [REVIEW] fix for fdo#44442, crash in ScInterpreter::GetDBParam with specific document

2012-01-07 Thread Markus Mohrhard
in this case. I think it is a simple patch fixing a crash and should be pushed to 3-4. Regards, Markus From 5065c9e2f00400d02681e5ac378d105d626b5ecb Mon Sep 17 00:00:00 2001 From: Markus Mohrhard markus.mohrh...@googlemail.com Date: Sun, 8 Jan 2012 04:32:06 +0100 Subject: [PATCH] return early on error

Re: [Libreoffice] [REVIEWED] [PUSHED 3-4] fix for fdo#44442, crash in ScInterpreter::GetDBParam with specific document

2012-01-08 Thread Markus Mohrhard
Hello Kohei, On Sat, Jan 7, 2012 at 10:40 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: I think it is a simple patch fixing a crash and should be pushed to 3-4. Simple and makes sense.  You have my approval. And pushed to the -3-4 branch with my sign-off. In case this needs

Re: [Libreoffice] [PATCH] ScGlobal::GetAutoFormat not always required to create fresh instance

2012-01-08 Thread Markus Mohrhard
Hello Stephan, Kohei, 2012/1/7 Kohei Yoshida kohei.yosh...@suse.com: On Fri, 2012-01-06 at 19:03 +0100, Stephan Bergmann wrote: So, I would appreciate it if some Calc aficionado could look at the patch, whether it actually makes any sense. First, I have to say all this auto format code is

[Libreoffice] prevent the creation of lockfiles during unit tests

2012-01-12 Thread Markus Mohrhard
that to master and 3-5 to prevent test failures because of old lockfiles. This brings us now one step closer to a read-only source tree. Regards, Markus From 2fe17e493046b9ecb58e3886d1f8cd27250f32b5 Mon Sep 17 00:00:00 2001 From: Markus Mohrhard markus.mohrh...@googlemail.com Date: Fri, 13 Jan 2012 03:34:28

[Libreoffice] unit test concept for draw/impress

2012-01-12 Thread Markus Mohrhard
7950b170ebedb2e0e64c3f4065577aa0184bcb85 Mon Sep 17 00:00:00 2001 From: Markus Mohrhard markus.mohrh...@googlemail.com Date: Fri, 13 Jan 2012 05:02:31 +0100 Subject: [PATCH] enable sd's regression test --- sd/Module_sd.mk |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/sd

Re: [Libreoffice] prevent the creation of lockfiles during unit tests

2012-01-13 Thread Markus Mohrhard
Hello Stephan No idea about that either (I think Michael Stahl has previously been exposed heavily to locking, maybe he has some input), just two comments on the patch: +bool IsLockingUsed() +{ +    bool bLocking = true; +    try +    { + +        uno::Reference uno::XInterface

Re: [Libreoffice] unit test concept for draw/impress

2012-01-13 Thread Markus Mohrhard
Hello Caolan, 2012/1/13 Caolán McNamara caol...@redhat.com: On Fri, 2012-01-13 at 06:10 +0100, Markus Mohrhard wrote: The advantage of the svg file is that it represents the visual representation extremely good and we ca easily compare it againts an reference svg file. How about pdf ? which

Re: [Libreoffice] Advice needed about some 3.4 named range related problem

2012-01-13 Thread Markus Mohrhard
Hello Noel, 2012/1/13 Noel Power nopo...@suse.com: Hi Guys, We have a bug here in the suse system that highlights a regression attempting to resolve a range by name. Note: this is not a problem on master. the failing macro code is something like so; Sub test    ProjectPlanSheet =

Re: [Libreoffice] Advice needed about some 3.4 named range related problem

2012-01-19 Thread Markus Mohrhard
Hello Noel, I think it makes sense to remove the findByName and replace them with findByUpperName. The findByName is error-prone and therefore I removed it for 3-5, internally we only use upper name (and in 3.5 we use it even to store the range name). I will clean-up your patch a bit because

Re: [Libreoffice] unit test concept for draw/impress

2012-01-19 Thread Markus Mohrhard
Hey, I finally found some time finishing the test. It now uses a character based comparison of the exported file and the reference file ( we can switch to a xml based diff later ). I enabled the test in the subsequenttest and hope that Stephan's tinderbox complains if I did something terribly

Re: [Libreoffice] Flat ODF usage in Git [Was: concept for c++ based subsequenttests]

2012-01-23 Thread Markus Mohrhard
Hello Niko, 2012/1/23 Niko Rönkkö ron...@iki.fi:        Only one query; I wonder whether we should be using the flat (fods) file-type for these tests - so we can read meaningful diffs to them in the git history. +1 for this... ... and I also think that all ODF files in git repos should be

Re: [Libreoffice] [REVIEW][3-5] Fix pivot table's date and number grouping

2012-01-24 Thread Markus Mohrhard
Hello Kohei, 2012/1/24 Kohei Yoshida kohei.yosh...@gmail.com: Hi there, I would like http://cgit.freedesktop.org/libreoffice/core/commit/?id=2c659e692a17cc10d364a2304bead9403fc6bdde to be backported to the 3-5 branch.  It fixes https://bugs.freedesktop.org/show_bug.cgi?id=45067 Review

Re: [Libreoffice] [REVIEW][3-5] Fix for pivot table refresh problem

2012-01-24 Thread Markus Mohrhard
Hello Kohei, I'd like to have http://cgit.freedesktop.org/libreoffice/core/commit/?id=561b044d62f4701e51abb4a7c47ce3b07f788f8e cherry-picked to 3-5.  This is a follow-up to my earlier changes in the pivot table code which somewhat changes the way pivot tables are refreshed. In short,

Re: [Libreoffice] [REVIEW 3-5] [PUSHED] potential fix for fdo#44391

2012-01-24 Thread Markus Mohrhard
Hello Noel, 2012/1/24 Noel Power nopo...@suse.com: would like to get this committed for 3.5, although I don't see the same artifacts  as mentioned in the bug, I do see sometimes the  some character is displayed still after switching to a blank cell from one with content. I no longer see this

[Libreoffice] Bug 33149 - EasyHack: EditDelete Contents always shows Delete, not currently assigned keystroke

2011-03-15 Thread Markus Mohrhard
This patch works for me! I suppose it should be solved like this. available under LGPLv3+/MPL https://bugs.freedesktop.org/show_bug.cgi?id=33149 I hope I did all right. Markus Mohrhard patch Description: Binary data ___ LibreOffice mailing list

Re: [Libreoffice] [Patch] allow one anonymous db range per sheet in calc

2011-03-22 Thread Markus Mohrhard
Hello, so I have reworked it. I haven't reworked the import and export as these affect some areas I don't fully understand. Patch is under LGPLv3+/MPL. Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [Patch] allow one anonymous db range per sheet in calc

2011-03-22 Thread Markus Mohrhard
This time with the patch. Sry. 2011/3/22 Markus Mohrhard markus.mohrh...@googlemail.com Hello, so I have reworked it. I haven't reworked the import and export as these affect some areas I don't fully understand. Patch is under LGPLv3+/MPL. Markus 0002-support-for-one-anonymous-db

Re: git branch audit ...

2012-07-19 Thread Markus Mohrhard
Hey, origin/feature/cell-format-data-bar origin/feature/cell-notes both obsolete now. origin/feature/chart_errorbars Have to look at that one again. origin/feature/gsoc_test_improvements origin/feature/gsoc_test_improvements2 origin/feature/gsoc_test_improvements3 Artur's

Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument

2012-07-19 Thread Markus Mohrhard
Hey Eike, Kohei, 2012/7/19 Kohei Yoshida kohei.yosh...@gmail.com: On 07/19/2012 10:29 AM, Eike Rathke wrote: Hi, Please review and cherry-pick to 3-6 and 3-6-0 http://cgit.freedesktop.org/libreoffice/core/commit/?id=a439cb5aba49d01df20f67a2c84b68542e4d3d5a that resolves

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - i18npool/source

2012-07-20 Thread Markus Mohrhard
i18npool/source/localedata/data/de_AT.xml |1 + i18npool/source/localedata/data/de_CH.xml |1 + i18npool/source/localedata/data/de_LI.xml |1 + i18npool/source/localedata/data/de_LU.xml |1 + 4 files changed, 4 insertions(+) New commits: commit

Re: [REVIEW 3-6][REVIEW 3-6-0] fdo#52240 added abbreviated date acceptance patterns for [de-{AT,CH,LI,LU}]

2012-07-20 Thread Markus Mohrhard
Hey, 2012/7/20 Eike Rathke er...@redhat.com: Hi, Please review and cherry-pick to 3-6 and 3-6-0 the no-brainer http://cgit.freedesktop.org/libreoffice/core/commit/?id=d0d840c27943f976fd59a673f2de84a10ea475c9 Looks good. Pushed into 3-6. Two more reviews needed for 3-6-0.

Re: [REVIEW 3-6, 3-6-0] [PUSHED 3-6] resolved fdo#52205 do not force all text cells in CSV import

2012-07-20 Thread Markus Mohrhard
Hey, 2012/7/20 Kohei Yoshida kohei.yosh...@gmail.com: On 07/19/2012 12:31 PM, Eike Rathke wrote: Hi, Please review and cherry-pick to 3-6 and 3-6-0 http://cgit.freedesktop.org/libreoffice/core/commit/?id=b7dbc768a71ccfb567e3b2979e57d0d1318977cf that fixes

[Libreoffice-commits] .: 4 commits - sc/inc sc/qa sc/source

2012-07-20 Thread Markus Mohrhard
|2 - sc/source/core/data/column2.cxx | 11 +++--- 10 files changed, 53 insertions(+), 52 deletions(-) New commits: commit 58d4ab69112ca1e1125b59a908fc48bb2f92c08f Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Fri Jul 20 20:57:43 2012 +0200

[Libreoffice-commits] .: 2 commits - sc/qa

2012-07-20 Thread Markus Mohrhard
sc/qa/unit/ucalc.cxx | 142 +++ 1 file changed, 142 insertions(+) New commits: commit d039b0070d62a54740b3f88d52debe3d5f4d664c Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Fri Jul 20 23:46:00 2012 +0200 second test

[Libreoffice-commits] .: sc/source

2012-07-22 Thread Markus Mohrhard
sc/source/core/data/table2.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 669784c6653732fd2ad43024332957d5df5652bb Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Sun Jul 22 21:15:37 2012 +0200 use correct source table for cond format paste

[Libreoffice-commits] .: 2 commits - sc/source

2012-07-22 Thread Markus Mohrhard
sc/source/ui/condformat/condformathelper.cxx |2 ++ sc/source/ui/src/globstr.src |4 2 files changed, 6 insertions(+) New commits: commit 7a26388f34feeec9568cbdcbad78fd5cd881747c Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Sun Jul 22 21:29:27 2012

[Libreoffice-commits] .: vcl/aqua

2012-07-22 Thread Markus Mohrhard
vcl/aqua/source/gdi/atsui/salatslayout.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 4b2d5d75ed8c2a8876e196593b1793798ce45441 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Mon Jul 23 00:00:20 2012 +0200 fix WaE on Mac Change-Id

[Libreoffice-commits] .: vcl/aqua

2012-07-22 Thread Markus Mohrhard
vcl/aqua/source/gdi/atsui/salatslayout.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit a9e58e29f65df820d133022c5cb15387075d6b37 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Mon Jul 23 00:15:54 2012 +0200 second fix for WaE Change-Id

[Libreoffice-commits] .: 2 commits - sc/source

2012-07-25 Thread Markus Mohrhard
76f56b5e8d4abf17682aa75b7cf183b883809234 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Tue Jul 24 08:54:58 2012 +0200 delete conditional format entries that are removed, fdo#52351 Change-Id: I9ab70d2b7a557ae5f717898edfb6c363343462f6 diff --git a/sc/source/core/data

Re: patches to clean up cppunit warnings (fdo#51154)

2012-07-26 Thread Markus Mohrhard
Hey, 2012/7/26 Robinson Tryon bishop.robin...@gmail.com: https://bugs.freedesktop.org/show_bug.cgi?id=51154 Here are a few patches that make cppunit compile warning-free when configured with -Weffc++ (and continue to be warning-free with -Wall -Wextra -Werror, too!) The .gitignore patches

[Libreoffice-commits] .: sc/source

2012-07-26 Thread Markus Mohrhard
sc/source/ui/unoobj/docuno.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit c55cfd273cf1d4666b91fc9a00c71b049c34adec Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Thu Jul 26 23:00:58 2012 +0200 mark manual row heights correctly during import, fdo#52393

[Libreoffice-commits] .: 4 commits - sc/inc sc/source sfx2/source

2012-07-27 Thread Markus Mohrhard
: Markus Mohrhard markus.mohrh...@googlemail.com Date: Fri Jul 27 14:03:09 2012 +0200 unify return type in this method Change-Id: I8db70cff48ce900db0710b30f94090ebd7d77c0a diff --git a/sc/inc/scerrors.hxx b/sc/inc/scerrors.hxx index 83636dc..3115cc2 100644 --- a/sc/inc/scerrors.hxx

[Libreoffice-commits] .: 2 commits - sc/source

2012-07-27 Thread Markus Mohrhard
: Markus Mohrhard markus.mohrh...@googlemail.com Date: Fri Jul 27 23:03:22 2012 +0200 copy conditional formats with sheets, fdo#52457 Change-Id: Ic7a337e8a6b36fecbd3aad0e3366fd6f0ccc99c6 diff --git a/sc/source/core/data/documen2.cxx b/sc/source/core/data/documen2.cxx index d537c35

[REVIEW 3-6] fix for fdo#52457, fdo#52565, problems with conditional formats

2012-07-27 Thread Markus Mohrhard
Hey, [1] and [2] fix two problems with conditional formats in 3-6. [1] correctly uses the current cursor position to calculate formulas for the conditional format dlg. [2] copies conditional formats correctly with sheets. They are both two simple fixes and should not create any problems.

[Libreoffice-commits] .: sc/source

2012-07-30 Thread Markus Mohrhard
sc/source/core/data/documen2.cxx | 134 +++ 1 file changed, 66 insertions(+), 68 deletions(-) New commits: commit 7c4e057b14c1d7325890297730e6cf710c128bf0 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Sat Jul 28 12:14:09 2012 +0200 small

Re: [REVIEW-3-6][REVIEW-3-6-x]fdo#52998 fdo#52999 MAB

2012-08-02 Thread Markus Mohrhard
Hello Noel 2012/8/2 Noel Power nopo...@suse.com: On 02/08/12 17:15, Eike Rathke wrote: Hi Noel, On Thursday, 2012-08-02 14:32:16 +0100, Noel Power wrote: master:6068f2f7cf5d66c68241b3831851b413b2e0b3ba ( sorry don't have the cgit url as cgit is dead ) git show

[Libreoffice-commits] .: sc/source

2012-08-05 Thread Markus Mohrhard
sc/source/filter/xml/xmlcondformat.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 507305afa0d826b7e3cb3cc9a4b389f0ba854638 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Sun Aug 5 11:47:19 2012 +0200 use correct string length for between

[REVIEW-3-6] fix for fdo#53010, use correct length for string

2012-08-05 Thread Markus Mohrhard
Hey, [1] fixes the problem with the is between conditional format. The problem was that I missed one character when I calculated the string length which prevented the import of the values/formulas. Regards, Markus [1]

[REVIEW-3-6] fix for fdo#52351, remove conditional formatting if all its cells are removed

2012-08-05 Thread Markus Mohrhard
Hey, [1] is mostly a fix for a strange behavior of ScRangeList which affects also conditional formats. ScRangeList did not delete a ScRange if UpdateReference removed all the ScRange cells. The second step of the patch is to remove the conditional formatting if the ScRangeList is empty after

[Libreoffice-commits] .: 2 commits - sc/source vcl/inc vcl/source

2012-08-05 Thread Markus Mohrhard
(-) New commits: commit 76ccb5fe45aef020f51a6c0d5ed14c95390a471f Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Sun Aug 5 14:48:51 2012 +0200 highlight invalid formulas in cond format dlg, fdo#43653, bnc#730048 Change-Id: I4893eb176aca976c037f8196dd3043e98fbf91dc diff --git

[Libreoffice-commits] .: sc/inc sc/source

2012-08-05 Thread Markus Mohrhard
sc/inc/column.hxx |3 sc/source/core/data/column2.cxx | 169 ++-- 2 files changed, 117 insertions(+), 55 deletions(-) New commits: commit 1e2964e55e6fc791b911998ca710a9f174c3d1ef Author: Markus Mohrhard markus.mohrh...@googlemail.com Date

[Libreoffice-commits] .: sc/qa

2012-08-07 Thread Markus Mohrhard
sc/qa/unit/ucalc.cxx |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) New commits: commit 96c5fb1dd28d2dbbe9d7130da518cbd5220bfddc Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Wed Aug 8 00:50:17 2012 +0200 enable tests for fixed cursor row navigation

[Libreoffice-commits] .: 3 commits - sc/inc sc/qa sc/source

2012-08-09 Thread Markus Mohrhard
: commit 5e0672f32ea6a4d3d6cf66874d0d7c0bdb3dec1d Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Thu Aug 9 15:58:00 2012 +0200 remove useless variable Change-Id: Ic04e11cd0768bc203188f0b5adb5f4b9725fd6d9 diff --git a/sc/source/core/data/column2.cxx b/sc/source/core/data

[Libreoffice-commits] .: 2 commits - sc/inc sc/source

2012-08-09 Thread Markus Mohrhard
067dca9c3e70091850dbb1d374170c2fce708e84 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Thu Aug 9 23:48:48 2012 +0200 make more calc methods const Change-Id: Ifc4775546ded8f524379946eb799dbbb314f7e8c diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx index 7b8e48b..ba23156 100644 --- a/sc/inc

[Libreoffice-commits] .: 2 commits - sc/inc sc/source

2012-08-10 Thread Markus Mohrhard
| 14 +++--- sc/source/core/data/table4.cxx |2 +- 7 files changed, 36 insertions(+), 36 deletions(-) New commits: commit 26a1aed24cc903ee858fb2d354f5dbb00f6d9969 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Fri Aug 10 19:21:12 2012 +0200 make more ScTable methods

[REVIEW-3-6] correctly calculate the percentile for upper data bar limit

2012-08-11 Thread Markus Mohrhard
Hey, the attached patch corrects the code that calculates the value if you select percentile for the upper limit. Until now it incorrectly used the lower bounds values to calculate these value. This will be fixed in master a bit differently. Regards, Markus

[Libreoffice-commits] .: 15 commits - sc/inc sc/qa sc/source

2012-08-13 Thread Markus Mohrhard
+--- sc/source/ui/src/colorformat.src |2 sc/source/ui/src/condformatdlg.src |2 18 files changed, 400 insertions(+), 271 deletions(-) New commits: commit 462907d48f18c8dab4f705203c840dee3253d268 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date

[Libreoffice-commits] .: sc/qa

2012-08-13 Thread Markus Mohrhard
sc/qa/unit/ucalc.cxx |2 -- 1 file changed, 2 deletions(-) New commits: commit 7ed9e024726747f9d0a70365c83ab619fac889e6 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Mon Aug 13 12:36:37 2012 +0200 these test should not have been disabled diff --git a/sc/qa/unit

[Libreoffice-commits] .: 4 commits - sc/inc sc/qa sc/source

2012-08-13 Thread Markus Mohrhard
Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Tue Aug 14 01:14:45 2012 +0200 remove some auto_ptr from xecontent Change-Id: Idef77ba4ce419aec26476ed027ac1a3c3fc41eef diff --git a/sc/source/filter/excel/xecontent.cxx b/sc/source/filter/excel/xecontent.cxx index d7461cf

[Libreoffice-commits] .: sc/inc sc/Library_sc.mk sc/source xmloff/source

2012-05-25 Thread Markus Mohrhard
(-) New commits: commit 1171a1375825785c9da40fd4e043d445c562c4aa Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Fri May 25 01:27:24 2012 +0200 import new conditional format information Change-Id: Iaa16792a74a3e33d3880cb9db41baf5613804387 diff --git a/sc/Library_sc.mk b

[Libreoffice-commits] .: sc/source xmloff/inc xmloff/source

2012-05-25 Thread Markus Mohrhard
|2 + xmloff/source/core/xmltoken.cxx|2 + 6 files changed, 73 insertions(+), 8 deletions(-) New commits: commit de687872926d0c54beba38fc2c33368b3ca6d634 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Sat May 26 00:40:49 2012 +0200 support remaining data bar

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

2012-05-25 Thread Markus Mohrhard
Hey Albert, 2012/5/24 Albert Thuswaldner albert.thuswald...@gmail.com: Hi Andras, Thanks for taking your time to reply. On Tue, May 22, 2012 at 5:50 PM, Andras Timar tima...@gmail.com wrote: Hi Albert, 2012/5/18 Markus Mohrhard markus.mohrh...@googlemail.com: This one is quite simple. we

  1   2   3   4   5   6   7   8   9   10   >