On Sunday, 10 September 2017 05:12:50 CET Jon Simons wrote:
> With this change, libcrypto.c will compile with BoringSSL. To
> get this working here's what I did:
>
> * Include the libcrypto-boringssl-compat shim header when building
>with OPENSSL_IS_BORINGSSL.
>
> * Bring in a few more fun
Will it be merge to the master of the main repository ?
I will try to. It would be great if you could test it and report back.
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
/git.libssh.org/users/aris/libssh.git/log/?h=chacha20
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
I will be back mid of October.
Will review patches when I'm back.
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
On Monday, 11 September 2017 18:00:47 CEST 312 wrote:
> Thank you for your commit, Andreas. I am going to import libssh as dll,so I
> think it's supposed to be LGPL compliant now. And I will try to contribute
> somesftp server examples to the libssh repo.
Thanks, but the sftp server implementation
stolen from the Samba project ;-)
We've added this in Samba after one of the last Security bugs we had ...
Thanks,
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
it is ok as long as you comply with the LGPL. I guess you're already
doing that, right?
https://bugs.libssh.org/T44 will be fixed with libssh 0.8.
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
fore Duke Nukem Forever will be release. Oh
wait? ...
OK, till someone starts to implement this. I think this means YOU :-)
> 2. Is there a way to write to the channel in non-blocking mode?
> Currently ssh_channel_write() says it's blocking...
Yeah, a lot of work ahead ...
Andre
On Wednesday, 9 August 2017 13:46:52 CEST Juraj Vijtiuk wrote:
> On Tue, Aug 08, 2017 at 05:30:07PM +0200, Andreas Schneider wrote:
> > Hi Juraj,
> >
> > thank you very much for your contribution to libssh. As the patch is
> > really
> > huge and I have commen
ode review tool we would like to use for these things :-)
You can create an account or use an existing github account to login.
Thanks,
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
nstall at least two header files I had to copy to /usr/include/libssh
> manually:
> poll.h
> config.h
>
> Thank you for such a powerful library! Playing around with it for a week
> already and find it very useful!
Those are internal header files, so they are not installed. Why do
nt it!
The server example:
https://git.libssh.org/projects/libssh.git/tree/examples/samplesshd-cb.c
shows how to do it for password, you need to add a callback for public key
authentication ...
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
tutorial.
However you should be able to find examples in the maling list archive. You
need your own protocol like
./command && echo OK || echo KO
To know if a command has been executed or failed ...
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.org
gt; https://pastebin.com/i5QLf1Gn
The page has been removed.
I think you have to turn on logging and try to find out what is going on. It
could also be a bug in libssh.
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
and so we loop forever.
>
> Does that theory sound plausible? Should the stderr data be ignored or bled
> off?
I dunno, the best would be if we have a reproducer and we could write a test
for for the issue.
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
ssh.git/tree/examples/ssh_server_fork.c
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
the patch, pushed.
I will review your other patches next week.
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
. If we are
connected to a version which we know supports the feature we turn it on.
I will add the patch.
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
On Thursday, 13 July 2017 00:40:52 CEST Jon Simons wrote:
>
Aris,
what do you think?
Should we make it configureable via an option or just be more graceful?
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
On Thursday, 13 July 2017 00:23:03 CEST Jon Simons wrote:
>
Hi Jon,
thanks for the patches.
The gcrypt build doesn't work anymore.
https://test.libssh.org/viewBuildError.php?buildid=41092
Could you please take a look.
Thanks,
Andreas
--
Andreas Schneider
On Thursday, 29 June 2017 10:54:12 CEST Tilo Eckert wrote:
> Am 28.06.2017 um 18:05 schrieb Andreas Schneider:
> > On Wednesday, 28 June 2017 15:40:00 CEST Tilo Eckert wrote:
> >> Am 28.06.2017 um 13:42 schrieb Andreas Schneider:
> >>> On Wednesday, 28 June 2017 1
On Wednesday, 28 June 2017 15:40:00 CEST Tilo Eckert wrote:
> Am 28.06.2017 um 13:42 schrieb Andreas Schneider:
> > On Wednesday, 28 June 2017 12:43:14 CEST Tilo Eckert wrote:
> >> Hi,
> >
> > Hi Tilo,
> >
> >> I am experiencing a re-occuring issue wh
erver is configured for HTTPS2, this post might be relevant:
> https://support.mozilla.org/en-US/questions/1139019
Thanks!
Please retry.
It should be reported to https://bettercrypto.org/ so that they update their
documentation.
Cheers,
Andreas
--
Andreas Schneider
t;.
The better way would be to reimplement the sftp-server using callbacks like
the rest of the ssh server we have. Then all you have to do is to define the
callblacks.
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
:
https://secure.phabricator.com/book/phabricator/article/arcanist/
The new bugtracker is at https://bugs.libssh.org/
The old one is read only and will be removed once we moved all the files.
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.org
nks for any examples or help!
Hi,
the problem is that the sftp server should be rewritten to use callbacks like
the rest of the server. We didn't have the time to do that yet. Help in that
area is much appreciated.
ou need to use messages to deal with sftp.
sftp_get_client_message()
chment.
See
https://git.libssh.org/projects/libssh.git/tree/SubmittingPatches
Thanks,
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
some
> tests with my libssh based project and it seems that the patch works OK
> for me. Please find the patch attached.
Thanks for your patch!
We really need tests for this code.
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
t; rc = ssh_userauth_none(session, NULL);
> if (rc != SSH_AUTH_SUCCESS) {
> return rc;
> }
>
> I believe it should be:
> If (rc == SSH_AUTH_SUCCESS) {
> return rc;
> }
I think it should be:
if (rc == SSH_AUTH_SUCCESS || rc == SSH_AUTH_ERROR) {
, shouldn't the
> above case not block anyway?
We already fixed some issues that the code is in the wrong state in the auth
code. I think there are more cases missing and those should be fixed.
It should be easy to extend our test suite with the case you describe and fix
it fro
gt; if I use libssh 0.7.5 is this probleme corrected or is there any other
> solution to this problem ?
>
> thanks for your answers
I think you have to try. Patches are very welcome :) Shouldn't be hard to fix.
--
Andreas Schneider GPG-ID: CC014E3D
www.crypt
error and set errno correctly.
Patches are very welcome.
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
ill able to
> connect to the server but I would like to have the key method to work.
>
> If you have any suggestion or tips, that would be greatly appreciated,
Turn on debug messages and it will give you some hints :)
http://api.libssh.org/master/
group__libssh__session.html#ga7a801b85800baa3f4e16f5b47db0a73d
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
Hi,
I've just released libssh-0.7.5
ChangeLog:
* Fixed a memory allocation issue with buffers
* Fixed PKI on Windows
* Fixed some SSHv1 functions
* Fixed config hostname expansion
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.org
On Tuesday, 11 April 2017 13:54:57 CEST Yanis Kurganov wrote:
> OK, no problem!
Pushed to master and will be in the next 0.7 release. Thanks for your
contribution!
> 2017-04-11 10:52 GMT+03:00 Andreas Schneider :
> > On Monday, 13 March 2017 16:19:43 CEST Yanis Kurganov wrote:
an point to those.
Everything is in tests/* in the master branch!
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
ng a
> new bind option (SSH_BIND_OPTIONS_IMPORT_KEY) to the function
> ssh_bind_options_set().
>
> Alfredo Mazzinghi
> ---
> Signed-off-by: Alfredo Mazzinghi
Pushed to master, that you very much for your contribution!
I've added the Sign-off to the patch itself.
s into an error mode
> (data_except is set which subsequently sets the status to SSH_CLOSED_ERROR)
Sounds like a bug which needs fixing :)
Can you provide a patch?
Thanks,
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
re you fine if I add the attached patchset?
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org>From 531e0e24c788fbd64e5771127c6a8a1e89caa88b Mon Sep 17 00:00:00 2001
From: Yanis Kurganov
Date: Tue, 11 Apr 2017 09:49
30d869d57b4dc813a84877d9
> > 174a15cd
> >
> > and an accompanying fix:
> > https://github.com/pmundkur/libssh/commit/df0fd2707c070e5f51ba3d68a8db6944
> > 65eced0e
> >
> > With this, an example of a fully non-blocking non-forking
> > callback-based server is here:
On Friday, 10 March 2017 10:16:07 CET Yanis Kurganov wrote:
> Dear libssh developers!
> Please care about ssh1. It's still alive =)
>
> Patch attached.
I will look into it, but we completely remove SSHv1 in future. I would say
telnet is as secure as SSHv1 ;-)
--
wait for
a connection.
Forking is better because if you have a segfault only the process for client
connection dies.
About threading:
http://bholley.net/blog/2015/must-be-this-tall-to-write-multi-threaded-code.html
Improved examples are always welcome.
Andreas
--
Andreas Schneider
output that I already read at #3.
>
> What am I doing wrong with this basic scenario?
Patches to improve the documentation are very welcome :)
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
an error on the page. We do not support it but maybe you're interested
to implement it?
Shouldn't be very hard to add it.
Cheers,
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
output that I already read at #3.
>
> What am I doing wrong with this basic scenario?
Hi,
look at examples/exec.c
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
ted space ...
This doesn't really make sense ...
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
On Wednesday, 23 November 2016 17:16:11 CET Mark Ramsden wrote:
> Aris,
>
> This may be a stupid question if I install MinFW to build the libs will I be
> able to link resultant dll with msvc projects ? Sure I could but don’t
> wantto run off on a fools errand
Aris and myself are not Windows user
Hello,
it took to long but finally here is a new release!
https://red.libssh.org/projects/libssh/files
Thanks for all contributors.
ChangeLog:
version 0.7.4 (released 2017-02-03)
* Added id_ed25519 to the default identity list
* Fixed sftp EOF packet handling
* Fixed ssh_send_banner()
me SSH_OK.
>
> What could be the problem.
Hey!
We don't know. Increase the logging output and try to find out yourself ;)
http://api.libssh.org/stable/
group__libssh__session.html#ga7a801b85800baa3f4e16f5b47db0a73d
Andreas
--
Andreas Schneider
On Friday, 25 November 2016 17:25:11 CET Mark Ramsden wrote:
> That’s worked a treat. Thank you. Now all I need to do is write my tunnel
> thread for my app and away I go.
> What could go wrong ? ☺
>
> Jeremy thanks for the patch
Thanks for all your help and contributions. Sorry but my time for
2009 with the v0-7
> build getting a link error
>
> error LNK2019: unresolved external symbol _ssh_agent_state_free referenced
> in function _ssh_free
>
> I like to think I'm relatively intelligent but this is getting beyond me
> now, trying to put together a proof of concept
ernal symbol _ssh_agent_state_free referenced
> in function _ssh_free
> I like to think I’m relatively intelligent but this is getting beyond me
> now, trying to put together a proof of concept but think I may have failed
> at first hurdle ☹
git pull
:)
>
> On 24/11/2016, 12:
not play nice with openssl
> 1.0.1. I could I guess try openssl 0.9 but that is now unsupported.
I've recently fixed all issues with VS2015 in the v0-7 and master.
It compiles just fine for me.
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
ill you hit EOF ...
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
e latest libssh library from the git repository.
Hey,
do you write in 16k chunks?
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
On Wednesday, 9 November 2016 16:34:14 CET Justus Winter wrote:
> * src/pki_gcrypt.c (pki_key_ecdsa_to_nid): Release 'sexp'.
I've pushed both patches upstream, thanks!
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.or
On Monday, 7 November 2016 10:44:12 CET Jakub Jelen wrote:
> On 11/05/2016 05:02 PM, Andreas Schneider wrote:
> > On Wednesday, 2 November 2016 17:58:01 CET Jakub Jelen wrote:
> >> Andreas,
> >> thank you for the comments. I reworked the patch (attached) to smaller
&g
On Friday, 13 May 2016 11:13:27 CET Игорь Коваленко wrote:
> Hi!
> there are such lines in function ssh_channel_read_timeout :
> ...
> if (channel->remote_eof && buffer_get_rest_len(stdbuf) == 0) {
> return 0;
> }
> It seems in such a case there should be a return of SSH_EOF value.
> Is it so o
On Friday, 13 May 2016 11:16:28 CET Игорь Коваленко wrote:
> Hi!
> There is a code in sftp_get_client_message
> case SSH_FXP_FSTAT:
> rc = ssh_buffer_unpack(payload,
> "Sd",
> &msg->handle,
> &msg->flag
On Monday, 7 November 2016 10:44:12 CET Jakub Jelen wrote:
> On 11/05/2016 05:02 PM, Andreas Schneider wrote:
> > On Wednesday, 2 November 2016 17:58:01 CET Jakub Jelen wrote:
> >> Andreas,
> >> thank you for the comments. I reworked the patch (attached) to smaller
&g
On Sunday, 6 November 2016 12:09:30 CET Andreas Schneider wrote:
> On Saturday, 5 November 2016 17:02:13 CET Andreas Schneider wrote:
> > On Wednesday, 2 November 2016 17:58:01 CET Jakub Jelen wrote:
> > > Andreas,
> > > thank you for the comments. I reworked the
On Saturday, 5 November 2016 17:02:13 CET Andreas Schneider wrote:
> On Wednesday, 2 November 2016 17:58:01 CET Jakub Jelen wrote:
> > Andreas,
> > thank you for the comments. I reworked the patch (attached) to smaller
> > parts that finally build and passes the testsui
00 00 00 2b ...+
> Event Log: Disconnected: All channels closed
>
> It seems that putty is waiting for SSH2_MSG_CHANNEL_CLOSE but server
> doesn't send it because it waits eof.
>
> Is it ok to remove the while loop? Or it could cause other problems?
You should really use sftp and not that broken scp protocol.
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
improves the
> readability of some constructions according to your hints.
Thank you very much. I split up one patch which didn't have your sign off. The
patchset is attached. I need your ok to add your sign-off and push it.
Cheers,
Andreas
--
Andreas Schneider
ast if you spend a lot of time in
the debugger and I do :)
Could you please check the memory leaks and fix them:
https://test.libssh.org/viewDynamicAnalysis.php?buildid=37424
Thanks,
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
.
>
> http://www.danisch.de/tmp/libssh_0.7.3_AUTH-AGENT.diff
Could you please send the patch for master as 'git format-patch' with your
sign-off?
Thanks,
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
life with them for now. For the future:
int len;
len = foo();
if (len == 1)
is easier to debug (gdb$ print len) and to understand then
if (foo() == 1)
Cheers,
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
. I've started with a review but did not finish it. I
will try to finish it tomorrow.
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
On Wednesday, 2 November 2016 12:34:59 CET Andreas Schneider wrote:
> On Wednesday, 2 November 2016 11:27:18 CET Aris Adamantiadis wrote:
> > Hi Jakub,
> >
> > That's great work you did here. Please let us some time to review your
> > patch and give feedback. We s
Yes, this is indeed nice work. However I've already found some small issues.
In DEBUG_CRYPTO there were some const issue and dsa instead of ecdsa was used.
I've fixed that in the branch here:
https://git.libssh.org/users/asn/libssh.git/log/?h=fix
Andreas
--
Andreas Schn
t;opts.identity);
>}
> +#ifndef _WIN32
>ssh_agent_state_free (session->agent_state);
> +#endif
>session->agent_state = NULL;
>SAFE_FREE(session->auth_auto_state);
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
"Received unhandled sftp message %d\n", msg->type);
> +"Received unhandled sftp message %d", msg->type);
>sftp_client_message_free(msg);
>return NULL;
>}
> diff --git a/src/wrapper.c b/src/wrapper.c
> index b75
){
> -return sftp_parse_attr(file->sftp, msg->payload, 0);
> +sftp_attributes attr = sftp_parse_attr(file->sftp, msg->payload, 0);
> +sftp_message_free(msg);
> +
> +return attr;
>} else if (msg->packet_type == SSH_FXP_STATUS) {
> st
On Friday, 1 July 2016 16:13:40 CEST Tilo Eckert wrote:
> Hi,
Hi Tilo,
> I attached some patches:
>
> - The SSH_FXF_READ flag was always set when opening a file via SFTP
> - I added support for opening files in append mode. Due to bad protocol
> design I had to query the file size through the s
On Wednesday, 5 October 2016 11:06:10 CEST Karl Scott wrote:
> Thank you very much for the quick response Aris! Good to know.
Patches are always welcome ;)
Cheers,
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
On Monday, 11 July 2016 17:18:18 CEST Yang Yubo wrote:
> And another question that may off topic: why libssh does not hosting on
> Github?
We prefer to run our own git infrastructure.
We do not trust web applications with write access to git.
--
Andreas Schneider
n successful
Maybe start with checking return codes, we provide them for a reason ...
-- andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
al are welcome.
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
lob/master/src/justup.c#L330
Isn't there a 0.7 version available?
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
On Tuesday, 23 August 2016 12:25:42 CEST Saju Panikulam wrote:
> Try reading and writing in blocks of 4K. Do this to EOF of source file.
Yes, exactly. I use 16k for the chunk size in KDE which works very well.
-- andreas
--
Andreas Schneider GPG-ID: CC014
On Friday, 29 July 2016 19:08:43 CEST Jason Goodell -X (jagoodel - KFORCE INC
at Cisco) wrote:
> Been trying to download the library all afternoon, and the webmaster link
> has no associated address. Thanks.
Fixed, sorry for the inconvenience.
--
Andreas Schneider
return of SSH_EOF value.
> Is it so or I'm missing something?
Hi,
this looks correct. Could you please send a patch as 'git format-patch' with
you Signed-Off?
See SubmittingPatches in the git tree.
Thanks,
-- andreas
--
Andreas Schneider GP
Hello,
the SSH developers of several FOSS implementations agreed to remove support
for SSHv1. The libssh project supports SSHv1 on the client side. libssh 0.8
will be the last release with SSHv1 support. After the release we will remove
all SSHv1 related code.
If you haven't done yet you shoul
On Monday, May 02, 2016 10:00:02 AM Kenneth Reister wrote:
> I had included the sign off in my email, but I see you've added it to the
> .patch file. Is that the correct way to do it in future?
>
> I don't see anything wrong with your changes/refactor. Looks like you
> refactored the entire func
On Monday, May 02, 2016 06:07:43 PM Yang Yubo wrote:
> Hi Andreas,
>
> It’s great to hear that, thank you for still remembered the patch.
>
> So for now, I do not have to keep my private branch, really good for me :)
>
> Thank you again for your work,
We have more issues with receiving and send
On Wednesday, March 30, 2016 11:53:25 AM you wrote:
> * ConfigureChecks.cmake: Set 'HAVE_ECC' and 'HAVE_GCRYPT_ECC' if
> applicable.
> * include/libssh/libgcrypt.h (EVPCTX): Fix type.
> (NID_gcrypt_nistp{256,384,521}): New constants.
> * include/libssh/pki.h (struct ssh_key_struct): Fix type of fie
On Tuesday, April 12, 2016 05:42:08 PM Stéphane Lemoine wrote:
> Hi ,
> I need help
> I have tried several ways to delete a directory and its subdirectory with
> sftp_rmdir
> on the sftp server and my function fails and the directory and its
> subdirectories are not deleted.
> How should I use the
On Sunday, October 18, 2015 04:41:36 PM Yang Yubo wrote:
> Hi,
Hi Yang,
> In attached patch, libssh banners end with “\r\n” if SSH 1 disabled in
> configuration, but keep origin behavior (send “\n”) if SSH 1 still allowed.
thanks you very much for your patch. I've rewrote the complete function
ct: [PATCH 1/2] client: Receive the banner correctly
Comply with RFC 4253 compliance section 4.2.
Allow data other than "SSH-" to be sent across prior to the actual
version striong.
Signed-off-by: Ken Reister
Reviewed-by: Andreas Schneider
---
src/client.c | 7 +++
1 file chang
On Tuesday, March 29, 2016 08:16:50 AM Sruthi Mohan wrote:
> Dear All,
> I tried integrating libssh to my "Qt-C++" application MINGW compiler I get
> heap errors in API like ssh_userauth_none , ssh_pki_import_pubkey_file and
> ultimately crashes in Debug Mode.
>
> It works perfectly in release mod
On Thursday, October 15, 2015 10:35:09 PM you wrote:
> Hello again,
>
> Sorry for having sent incorrect patch file.
>
> Previous patch file won’t send client banner immediately, it will be
> buffered.
>
> I use ssh_set_fd_towrite to force banner being sent immediately, but I’m not
> sure whether
st of
> >> introducing new security problems.
> >>
> >> Your code however correctly and neatly implements the packet parsing and
> >> packet sending, together with the corner case of SSH_MSG_GEX_OLD_INIT.
> >> My proposition now is that I'll work on a better way of decoupling the
> >> different key exchange methods, and implement GEX by using as much of
> >> your code as I can. I'll make sure you get your name as the commiter so
> >> you're properly credited for you work.
> >>
> >> Best regards,
> >>
> >> Aris
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
On Friday 29 January 2016 10:32:49 Andreas Schneider wrote:
> On Sunday, January 24, 2016 07:33:37 PM Younes Serraj wrote:
>
>
>
> Hi Younes,
>
> that for your contribution, but renaming this function would break the API.
> We still need the old function name .
_poll(ssh_pollfd_t *fds, nfds_t nfds, int timeout) {
> - return poll((struct pollfd *) fds, nfds, timeout);
> + int rc = poll((struct pollfd *) fds, nfds, timeout);
> + if (rc <= 0)
> + return -1;
> + return rc;
> }
>
> #else /* HAVE_POLL */
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
sue with missing brackets is Apples 'goto fail'.
However experience shows that missing brackets lead to errors.
Please also add brackets to the other patches.
Thanks,
-- andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
the patch and rebase against master. The best would be
an attachment created with 'git format-patch'.
Thanks,
-- andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
;sb);
> -if (rc < 0) {
> -sftp_server = getenv("TORTURE_SFTP_SERVER");
> -}
> -}
> + if (rc == 0)
> +break;
> }
> +if (sftp_server == NULL)
> +
_CHANNEL_FORWARDED_AUTH_AGENT;
> +if (ssh_callbacks_exists(session->common.callbacks,
> channel_open_request_auth_agent_function)) { + ssh_channel
> agent_channel = ssh_message_channel_request_open_reply_accept(msg); +
> session->common.callbacks->channel_open_request_auth_agent_function(session
> , +agent_channel,
> +session->common.callbacks->userdata);
> +}
> +goto error;
> + }
> +
>msg->channel_request_open.type = SSH_CHANNEL_UNKNOWN;
>goto end;
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.orga...@cryptomilk.org
301 - 400 of 930 matches
Mail list logo
