Re: [Patch] Windows sockets version 2.2

2017-06-07 Thread Chris Ruehl
Aris, ".. Applications on these platforms should normally request Winsock 2.2" is copied from MSDN. For sure there is a reason why there is a version 2.2 released. I can't accept a general noob from you. Question: Is this change harmful or introduce a regression? If the patch for 2.2 triggers

Re: [Patch] Windows sockets version 2.2

2017-06-07 Thread Chris Ruehl
On Thursday, June 08, 2017 12:39 AM, Aris Adamantiadis wrote: Hi Chris, Total noob here. Does winsock 2.2 change some semantics/fix some bugs from 2.0 we were used to see on windows? I'm thinking about WSAPoll that we had to stop supporting because it was so buggy. I don't understand this

Re: [Patch] Windows sockets version 2.2

2017-06-07 Thread Aris Adamantiadis
Hi Chris, Total noob here. Does winsock 2.2 change some semantics/fix some bugs from 2.0 we were used to see on windows? I'm thinking about WSAPoll that we had to stop supporting because it was so buggy. I don't understand this comment: +/* Validate version it can fallback to 2.0 */ If

Re: [Patch] Windows sockets version 2.2

2017-06-07 Thread Andreas Schneider
On Wednesday, 7 June 2017 07:37:18 CEST Chris Ruehl wrote: > Window Sockets 2.2 is the recommended DLL version, this patch > change from v2.0 to v2.2 and add fallback check. Hi Chris, could you please attach signed-off patches created with git format-patch? The best would be as an attachment.

[Patch] Windows sockets version 2.2

2017-06-06 Thread Chris Ruehl
Window Sockets 2.2 is the recommended DLL version, this patch change from v2.0 to v2.2 and add fallback check. Windows Sockets version 2.2 is supported on Windows Server 2008, Windows Vista, Windows Server 2003, Windows XP, Windows 2000, Windows NT 4.0 with Service Pack 4 (SP4) and later,