Re: Build libssh against openssl 1.1.0

2016-11-07 Thread Andreas Schneider
On Monday, 7 November 2016 10:44:12 CET Jakub Jelen wrote: > On 11/05/2016 05:02 PM, Andreas Schneider wrote: > > On Wednesday, 2 November 2016 17:58:01 CET Jakub Jelen wrote: > >> Andreas, > >> thank you for the comments. I reworked the patch (attached) to smaller > >> parts that finally build and

Re: Build libssh against openssl 1.1.0

2016-11-07 Thread Andreas Schneider
On Monday, 7 November 2016 10:44:12 CET Jakub Jelen wrote: > On 11/05/2016 05:02 PM, Andreas Schneider wrote: > > On Wednesday, 2 November 2016 17:58:01 CET Jakub Jelen wrote: > >> Andreas, > >> thank you for the comments. I reworked the patch (attached) to smaller > >> parts that finally build and

Re: Build libssh against openssl 1.1.0

2016-11-07 Thread Jakub Jelen
On 11/05/2016 05:02 PM, Andreas Schneider wrote: On Wednesday, 2 November 2016 17:58:01 CET Jakub Jelen wrote: Andreas, thank you for the comments. I reworked the patch (attached) to smaller parts that finally build and passes the testsuite in master for both OpenSSL versions (sorry for the firs

Re: Build libssh against openssl 1.1.0

2016-11-06 Thread Andreas Schneider
On Sunday, 6 November 2016 12:09:30 CET Andreas Schneider wrote: > On Saturday, 5 November 2016 17:02:13 CET Andreas Schneider wrote: > > On Wednesday, 2 November 2016 17:58:01 CET Jakub Jelen wrote: > > > Andreas, > > > thank you for the comments. I reworked the patch (attached) to smaller > > > p

Re: Build libssh against openssl 1.1.0

2016-11-06 Thread Andreas Schneider
On Saturday, 5 November 2016 17:02:13 CET Andreas Schneider wrote: > On Wednesday, 2 November 2016 17:58:01 CET Jakub Jelen wrote: > > Andreas, > > thank you for the comments. I reworked the patch (attached) to smaller > > parts that finally build and passes the testsuite in master for both > > Ope

Re: Build libssh against openssl 1.1.0

2016-11-05 Thread Andreas Schneider
On Wednesday, 2 November 2016 17:58:01 CET Jakub Jelen wrote: > Andreas, > thank you for the comments. I reworked the patch (attached) to smaller > parts that finally build and passes the testsuite in master for both > OpenSSL versions (sorry for the first bad version). It also improves the > reada

Re: Build libssh against openssl 1.1.0

2016-11-02 Thread Jakub Jelen
Andreas, thank you for the comments. I reworked the patch (attached) to smaller parts that finally build and passes the testsuite in master for both OpenSSL versions (sorry for the first bad version). It also improves the readability of some constructions according to your hints. The related

Re: Build libssh against openssl 1.1.0

2016-11-02 Thread Andreas Schneider
On Wednesday, 2 November 2016 12:34:59 CET Andreas Schneider wrote: > On Wednesday, 2 November 2016 11:27:18 CET Aris Adamantiadis wrote: > > Hi Jakub, > > > > That's great work you did here. Please let us some time to review your > > patch and give feedback. We should test on some older systems,

Re: Build libssh against openssl 1.1.0

2016-11-02 Thread Andreas Schneider
On Wednesday, 2 November 2016 11:27:18 CET Aris Adamantiadis wrote: > Hi Jakub, > > That's great work you did here. Please let us some time to review your > patch and give feedback. We should test on some older systems, such as > centos/RHEL 4.x that some people still use. Yes, this is indeed nic

Re: Build libssh against openssl 1.1.0

2016-11-02 Thread Aris Adamantiadis
Hi Jakub, That's great work you did here. Please let us some time to review your patch and give feedback. We should test on some older systems, such as centos/RHEL 4.x that some people still use. Aris On 1/11/16 15:39, Jakub Jelen wrote: > Hello libssh developers, > during last days we were port

Build libssh against openssl 1.1.0

2016-11-01 Thread Jakub Jelen
Hello libssh developers, during last days we were porting various applications to openssl 1.1.0, which brought various API changes to simplify the transition to new version in future Fedora [1]. The most of the changes are not backward compatible and require special layer of compatibility (al