Patch: for SSH 2.0, send client banner immediately and save a round-trip

2015-10-14 Thread Yang Yubo
Hello everyone,The SSH protocol version 2 standards allow client banner send immediately, no need to wait server responses its version identification first:https://tools.ietf.org/html/rfc4253#section-5.25.2. New Client, Old Server Since the new client MAY immediately send additional data after

Re: Patch: for SSH 2.0, send client banner immediately and save a round-trip

2015-10-15 Thread Yang Yubo
Hello again,Sorry for having sent incorrect patch file.Previous patch file won’t send client banner immediately, it will be buffered.I use ssh_set_fd_towrite to force banner being sent immediately, but I’m not sure whether it’s the right tool.By using Wireshark to trace packets shows client banner

Re: Patch: for SSH 2.0, send client banner immediately and save a round-trip

2015-10-22 Thread Andreas Schneider
On Wednesday 14 October 2015 15:07:00 Yang Yubo wrote: > Hello everyone, Hi, > The attachment is the patch that enables sending client banner immediately > for version 2, and keep the old behavior for version 1.x, created based on > 0.7 branch. Aris and I are quite busy this week. I try to revie

Re: Patch: for SSH 2.0, send client banner immediately and save a round-trip

2015-10-27 Thread Yang Yubo
Hi Andreas, Is it necessary to file bug reports on Redmine for the two patches that I’ve submitted? BR, Yang > On Oct 22, 2015, at 17:00, Andreas Schneider wrote: > > On Wednesday 14 October 2015 15:07:00 Yang Yubo wrote: >> Hello everyone, > > Hi, > >> The attachment is the patch that ena

Re: Patch: for SSH 2.0, send client banner immediately and save a round-trip

2016-05-02 Thread Andreas Schneider
On Thursday, October 15, 2015 10:35:09 PM you wrote: > Hello again, > > Sorry for having sent incorrect patch file. > > Previous patch file won’t send client banner immediately, it will be > buffered. > > I use ssh_set_fd_towrite to force banner being sent immediately, but I’m not > sure whether

Re: Patch: for SSH 2.0, send client banner immediately and save a round-trip

2016-05-02 Thread Yang Yubo
Got it, and thank you so much for incorporating the patch. Best regards, Yang > On May 2, 2016, at 16:20, Andreas Schneider wrote: > > On Thursday, October 15, 2015 10:35:09 PM you wrote: >> Hello again, >> >> Sorry for having sent incorrect patch file. >> >> Previous patch file won’t send c