Re: Quick question about some patches

2016-05-03 Thread Andreas Schneider
On Monday, May 02, 2016 10:00:02 AM Kenneth Reister wrote: > I had included the sign off in my email, but I see you've added it to the > .patch file. Is that the correct way to do it in future? > > I don't see anything wrong with your changes/refactor. Looks like you > refactored the entire func

Re: Quick question about some patches

2016-05-02 Thread Kenneth Reister
I had included the sign off in my email, but I see you've added it to the .patch file. Is that the correct way to do it in future? I don't see anything wrong with your changes/refactor. Looks like you refactored the entire function for tabs and applied my change as well. I know you might not kn

Re: Quick question about some patches

2016-05-02 Thread Andreas Schneider
On Friday, April 08, 2016 11:12:36 AM Kenneth Reister wrote: > I and a colleague submitted some patches. I was able to find his in the > commit logs. One in the 0.7.3 branch and the other 2 in master. I could > not find mine at all (see > http://www.libssh.org/archive/libssh/2015-11/000.html

Quick question about some patches

2016-04-08 Thread Kenneth Reister
I and a colleague submitted some patches. I was able to find his in the commit logs. One in the 0.7.3 branch and the other 2 in master. I could not find mine at all (see http://www.libssh.org/archive/libssh/2015-11/000.html) What can I do to make sure that my patch gets committed? Do you ha