Re: [PATCH 366] Libtoolize now advises AC_CONFIG_MACRO_DIR use where appropriate.

2008-04-23 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Thu, Apr 24, 2008 at 05:34:39AM CEST: > On 23 Apr 2008, at 17:26, Ralf Wildenhues wrote: >> >> It seems that one of your patches causes this test failure: >> --- expout 2008-04-23 22:41:22.0 +0200 >> +++ /home/ralf/libtool/write/build/tests/testsuite.dir/at-s

Re: Avoid using grep in func_lalib_p

2008-04-23 Thread Ralf Wildenhues
Hi Olly, * Olly Betts wrote on Thu, Apr 24, 2008 at 08:04:03AM CEST: > I noticed that the sed and grep combination in func_lalib_p can be > folded into a single use of sed. I don't think this is likely to > be a hot spot, but it's an easy fix. > > I'm not an expert on sed portability but it does

Avoid using grep in func_lalib_p

2008-04-23 Thread Olly Betts
I noticed that the sed and grep combination in func_lalib_p can be folded into a single use of sed. I don't think this is likely to be a hot spot, but it's an easy fix. I'm not an expert on sed portability but it doesn't seem to fall afoul of anything in the autoconf manual. The patch is against

Re: [PATCH 366] Libtoolize now advises AC_CONFIG_MACRO_DIR use where appropriate.

2008-04-23 Thread Gary V. Vaughan
Hi Ralf, On 23 Apr 2008, at 17:26, Ralf Wildenhues wrote: * Gary V. Vaughan wrote on Wed, Apr 23, 2008 at 12:04:02AM CEST: On 22 Apr 2008, at 15:27, Ralf Wildenhues wrote: I'm wondering a bit whether we should recommend putting ACLOCAL_AMFLAGS = -I MACRO-DIR in the toplevel Makefile.am. Agr

Re: [libtool 2.2.2] testsuite: ... 38 ... 56 ... failed

2008-04-23 Thread Ralf Wildenhues
Hello Michael, * Michael Haubenwallner wrote on Sat, Apr 19, 2008 at 11:46:32AM CEST: > On Fri, 2008-04-18 at 21:24 +0200, Ralf Wildenhues wrote: > > * Michael Haubenwallner wrote on Fri, Apr 18, 2008 at 04:22:03PM CEST: > > > [lt-2.2.2-testsuite-usrlocal.patch] > > > proposed patch to change any

Re: [PATCH 366] Libtoolize now advises AC_CONFIG_MACRO_DIR use where appropriate.

2008-04-23 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Wed, Apr 23, 2008 at 12:04:02AM CEST: > On 22 Apr 2008, at 15:27, Ralf Wildenhues wrote: >>> I'm wondering a bit whether we should >>> recommend putting >>> ACLOCAL_AMFLAGS = -I MACRO-DIR >>> >>> in the toplevel Makefile.am. > > Agreed. I'll add that before I