avoid compiler warning

2009-11-02 Thread Eric Blake
I'm seeing this when compiling with -Wall: | libltdl/ltdl.c: In function ‘try_dlopen’: | libltdl/ltdl.c:1267: error: the address of ‘libext’ will always evaluate as ‘true’ The problem is that LT_STRLEN is checking for null pointers, but the address of an array can never be null. But using a

Re: avoid compiler warning

2009-11-02 Thread Ralf Wildenhues
* Eric Blake wrote on Mon, Nov 02, 2009 at 08:17:36PM CET: Ralf Wildenhues Ralf.Wildenhues at gmx.de writes: The compiler warning is bogus. Your patch pessimizes the code; IIRC it can cause runtime-initialization of the pointer. OK to commit a patch to change this to strlen. Like

abs-bindir Was: bindir for libtool

2009-11-02 Thread Roumen Petrov
Ralf Wildenhues wrote: Hi Charles, [SNIP] I agree. I'd suggest, perhaps, adding a *different* libtool option, e.g. -abs-bindir, that works semantically as Roumen desires. Then, later, gcc may choose to use either -bindir or -abs-bindir, whatever seems best to them. I'm probably overlooking