Re: MSVC: MSVC needs a hint to force it to compile either as C or C++.

2010-06-22 Thread Peter Rosin
Hi Gary, Den 2010-06-22 14:53 skrev Gary V. Vaughan: In this case, Peter, would you point me at the followup patches that need this preliminary prep work? I had a poke around in your git branch but couldn't (quickly) figure out where this is going... and without that it's hard to do a sane revie

Re: [PATCH] getopt.m4sh generated libtool option parser, and XSI improvements.

2010-06-22 Thread Gary V. Vaughan
I forgot to commit the following chunk before extracting the patch from git: diff --git a/libltdl/config/getopt.m4sh b/libltdl/config/getopt.m4sh index 1487755..76f9d35 100644 --- a/libltdl/config/getopt.m4sh +++ b/libltdl/config/getopt.m4sh @@ -49,6 +49,13 @@ m4_pattern_forbid([^_?m4go_]) ## 1.

Re: MSVC: MSVC needs a hint to force it to compile either as C or C++.

2010-06-22 Thread Gary V. Vaughan
Hallo Ralf, Peter, On 23 Jun 2010, at 03:16, Ralf Wildenhues wrote: > * Peter Rosin wrote on Tue, Jun 22, 2010 at 03:07:30PM CEST: >> Den 2010-06-22 13:54 skrev Gary V. Vaughan: >>> But compile_tag is never set, so the patch is a NOP! > >>> If this has to be fudged into the libtool tag settings b

Re: [PATCH] [cygwin] Refactor C++ exception handling for Win32 correctness

2010-06-22 Thread Ralf Wildenhues
* Charles Wilson wrote on Wed, Jun 23, 2010 at 06:17:41AM CEST: > On 6/20/2010 1:33 PM, Ralf Wildenhues wrote: > > This can go. Please mention in the comment that not using a common lib > > represents an ODR violation (mentioning relevant terms from standards is > > helpful). > > > > BTW, does no

Re: [PATCH] [cygwin] Refactor C++ exception handling for Win32 correctness

2010-06-22 Thread Charles Wilson
On 6/20/2010 1:33 PM, Ralf Wildenhues wrote: > * Charles Wilson wrote on Sun, Jun 20, 2010 at 06:59:02AM CEST: >> There are ODR issues with the definition of the exception class(es). >> While on linux, the code may technically be in violation, in practice >> it is ok and works. > > But that's not

[PATCH] getopt.m4sh generated libtool option parser, and XSI improvements.

2010-06-22 Thread Gary V. Vaughan
This is the improved (and renamed) `Use getopt.m4sh to generate libtool option parser.' patch I promised yesterday. I'm pretty happy with this, save that even though _LT_PROG_XSI_REPLACE correctly generates sed scripts in config.status of the form: sed -i .tmp -e '/^func_name ()$/,/^} # func_na

Re: MSVC: MSVC needs a hint to force it to compile either as C or C++.

2010-06-22 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Tue, Jun 22, 2010 at 03:07:30PM CEST: > Den 2010-06-22 13:54 skrev Gary V. Vaughan: > >But compile_tag is never set, so the patch is a NOP! > >If this has to be fudged into the libtool tag settings by hand to > >support MSVC (or some other nefarious means I'm miss

Re: MSVC: MSVC needs a hint to force it to compile either as C or C++.

2010-06-22 Thread Gary V. Vaughan
Hi Chuck,On 22 Jun 2010, at 19:10, Charles Wilson wrote:On 6/22/2010 7:54 AM, Gary V. Vaughan wrote:But compile_tag is never set, so the patch is a NOP!If that happens with a later patch in your series, please roll allthe compile_tag machinery into a single commit.But what if that later patch, in o

Re: MSVC: MSVC needs a hint to force it to compile either as C or C++.

2010-06-22 Thread Peter Rosin
Hi Gary, Den 2010-06-22 13:54 skrev Gary V. Vaughan: But compile_tag is never set, so the patch is a NOP! If that happens with a later patch in your series, please roll all the compile_tag machinery into a single commit. If this has to be fudged into the libtool tag settings by hand to support

Re: MSVC: MSVC needs a hint to force it to compile either as C or C++.

2010-06-22 Thread Charles Wilson
On 6/22/2010 7:54 AM, Gary V. Vaughan wrote: > But compile_tag is never set, so the patch is a NOP! > > If that happens with a later patch in your series, please roll all > the compile_tag machinery into a single commit. But what if that later patch, in order to work correctly, also requires addi

Re: MSVC: MSVC needs a hint to force it to compile either as C or C++.

2010-06-22 Thread Gary V. Vaughan
Hi Peter, Thanks for your continued work on this. On 22 Jun 2010, at 16:35, Peter Rosin wrote: > MSVC needs a hint to force it to compile either as C or C++. > * libltdl/m4/libtool.m4: Add tag variable compile_tag to > enable tag specific compiler options that are bad in the >

Re: MSVC: MSVC needs a hint to force it to compile either as C or C++.

2010-06-22 Thread Peter Rosin
Ooops, exported the wrong thing from git... Sorry for the noise. Here's the intended patch Cheers, Peter commit 1e1a3cb447ee0d725d6cd8249358d9d5595a039b Author: Peter Rosin Date: Tue Jun 22 11:07:22 2010 +0200 MSVC needs a hint to force it to compile either as C or C++. * libltd

MSVC: MSVC needs a hint to force it to compile either as C or C++.

2010-06-22 Thread Peter Rosin
Next patch in the MSVC series... This is "MSVC needs a hint to force it to compile either as C or C++." abfb96f4c44b3e38fcf960c876e17fc252e9712c and the relevant part of "patch msvc-documentation.patch" 06cfce005204bb8ca212aadab38b38c0202ea04e with @var changed to @code This was originally su

Re: [PATCH] Use getopt.m4sh to generate libtool option parser.

2010-06-22 Thread Gary V. Vaughan
Hallo Ralf, On 22 Jun 2010, at 12:48, Ralf Wildenhues wrote: >> On 12 Jun 2010, at 17:45, Ralf Wildenhues wrote: >>> * Gary V. Vaughan wrote on Sat, Jun 12, 2010 at 12:34:04PM CEST: That's quite an invasive change, since the core of the M4SH_GETOPTS generated code will then rely on the X

Re: Multiple test failures with --disable-shared

2010-06-22 Thread Gary V. Vaughan
[working through my email backlog after being mostly offline for the last week or more. Apologies if this is too late to be relevant.] On 13 Jun 2010, at 12:07, Ralf Wildenhues wrote: > * Peter O'Gorman wrote on Sun, Jun 13, 2010 at 06:07:44AM CEST: >> On 06/11/2010 11:56 PM, Gary V. Vaughan wrot

Re: [PATCH] Use getopt.m4sh to generate libtool option parser.

2010-06-22 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Tue, Jun 22, 2010 at 07:42:27AM CEST: > On 22 Jun 2010, at 00:59, Ralf Wildenhues wrote: > > However, this makes me more cautious > > about your other patch for using this machinery for the libtool script > > itself: that is created in packages using Libtool, > > Not tru

Re: [PATCH] Ensure getopts.m4sh is compatible with Autoconf-2.61 and newer.

2010-06-22 Thread Gary V. Vaughan
On 22 Jun 2010, at 00:59, Ralf Wildenhues wrote: > Hi Gary, Hallo Ralf, > * Gary V. Vaughan wrote on Mon, Jun 21, 2010 at 02:56:12PM CEST: >> This fixes the FreeBSD bootstrap problem. Okay to push? > > Okay if it passes the testsuite. Tx. Pushed. [moved comments on my other patch back into t

Re: [PATCH] Use getopt.m4sh to generate libtool option parser.

2010-06-22 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Tue, Jun 22, 2010 at 07:42:27AM CEST: > # First we set _m4go_xsi_shell if the standard shell supports XSI features > # that allow us to avoid (expensive on Windows) forks: BTW, the number of forks in libtool is even measureable for builds on GNU/Linux. The list archive

Re: [PATCH] Use getopt.m4sh to generate libtool option parser.

2010-06-22 Thread Gary V. Vaughan
Hallo Ralf, [transplanted from another thread] On 22 Jun 2010, at 00:59, Ralf Wildenhues wrote: > However, this makes me more cautious > about your other patch for using this machinery for the libtool script > itself: that is created in packages using Libtool, Not true. We distribute libtoolize