Re: [PATCH] Add an XSI replacement for func_split_short_opt.

2010-06-28 Thread Gary V. Vaughan
Hi Eric, Thanks for the feedback! On 29 Jun 2010, at 05:37, Eric Blake wrote: > On 06/28/2010 04:19 PM, Ralf Wildenhues wrote: >> * Eric Blake wrote on Mon, Jun 28, 2010 at 02:49:40PM CEST: >>> tmp=${1#?} >>> patt= >>> i=2 >>> while test $i -lt ${#1}; do >>> patt="?$patt" >> >> If the parameter

Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

2010-06-28 Thread Ralf Wildenhues
Hello Vincent, * Ralf Wildenhues wrote on Sat, Jun 19, 2010 at 12:08:29PM CEST: > I would like to commit the patch quoted below, on the way of support for > LTO with GCC. For that, I need to know from somebody who is willing to > help out with the Windows CE port of Libtool whether the #defines u

Re: [PATCH] Add an XSI replacement for func_split_short_opt.

2010-06-28 Thread Eric Blake
On 06/28/2010 04:19 PM, Ralf Wildenhues wrote: > Hi Eric, > > thanks for the suggestion. I had considered the idea for a second, but > failed to see the nontrivial half. > > * Eric Blake wrote on Mon, Jun 28, 2010 at 02:49:40PM CEST: >> tmp=${1#?} >> patt= >> i=2 >> while test $i -lt ${#1}; do >

Re: [PATCH] Add an XSI replacement for func_split_short_opt.

2010-06-28 Thread Ralf Wildenhues
Hi Eric, thanks for the suggestion. I had considered the idea for a second, but failed to see the nontrivial half. * Eric Blake wrote on Mon, Jun 28, 2010 at 02:49:40PM CEST: > tmp=${1#?} > patt= > i=2 > while test $i -lt ${#1}; do > patt="?$patt" If the parameter may be expected to be very l

Re: [PATCH] Add an XSI replacement for func_split_short_opt.

2010-06-28 Thread Eric Blake
> No, ${parameter:offset} and ${parameter:offset:length} are bash specific > not XSI mandated. But we don't need bash-specific hacks. ${parameter#??} serves as a great XSI alternative to ${parameter:2}, and with a (lot) more thought, ${1:1:1} can be written without forks and without bash-isms as:

Re: MSVC: For MSVC, embed the manifest as a resource in the executable.

2010-06-28 Thread Peter Rosin
Hi Ralf, Thanks for the review! Den 2010-06-26 22:42 skrev Ralf Wildenhues: * Peter Rosin wrote on Fri, Jun 25, 2010 at 12:20:53AM CEST: Den 2010-06-24 20:17 skrev Ralf Wildenhues: I guess. Wait. Will mt be needed for programs also in packages using only static libraries on w32, that maybe

Re: MSVC: Add MSVC support.

2010-06-28 Thread Peter Rosin
Hi Ralf, Thanks for the review! Den 2010-06-24 06:51 skrev Ralf Wildenhues: How about this: * Changes in supported systems or compilers: - Initial support for the Microsoft C/C++ Compiler with help from (proposed changes to) the compile script in Automake. And then fiddle the NEWS ent

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static (take 8?)

2010-06-28 Thread Gary V. Vaughan
Hi Chuck, Thanks for persevering with the Windows support in Libtool. Regarding our patch review process, I honestly find the tough reviews valuable in keeping up the quality of my patches, not least because it makes me more careful not to leave loose ends in my submissions. Nevertheless, please