Hallo Ralf,
On 27 Jun 2010, at 00:44, Ralf Wildenhues wrote:
> * Gary V. Vaughan wrote on Tue, Jun 22, 2010 at 10:23:39PM CEST:
>> This is the improved (and renamed) `Use getopt.m4sh to generate libtool
>> option parser.' patch I promised yesterday. I'm pretty happy with this,
>> save that even
Hallo Ralf,
Thanks again for the review.
On 27 Jun 2010, at 04:26, Ralf Wildenhues wrote:
> another partial review:
>
> * Gary V. Vaughan wrote on Tue, Jun 22, 2010 at 10:23:39PM CEST:
>> --- a/libltdl/config/general.m4sh
>> +++ b/libltdl/config/general.m4sh
>
>
>> +func_stripname ()
>> +{
>
Hi Gary,
another partial review:
* Gary V. Vaughan wrote on Tue, Jun 22, 2010 at 10:23:39PM CEST:
> --- a/libltdl/config/general.m4sh
> +++ b/libltdl/config/general.m4sh
> +func_stripname ()
> +{
Trailing whitespace.
> +case ${2} in
> + .*) func_stripname_result=`$ECHO "${3}" | $SED
* Gary V. Vaughan wrote on Tue, Jun 22, 2010 at 10:23:39PM CEST:
> This is the improved (and renamed) `Use getopt.m4sh to generate libtool
> option parser.' patch I promised yesterday. I'm pretty happy with this,
> save that even though _LT_PROG_XSI_REPLACE correctly generates sed
> scripts in con
I forgot to commit the following chunk before extracting the
patch from git:
diff --git a/libltdl/config/getopt.m4sh b/libltdl/config/getopt.m4sh
index 1487755..76f9d35 100644
--- a/libltdl/config/getopt.m4sh
+++ b/libltdl/config/getopt.m4sh
@@ -49,6 +49,13 @@ m4_pattern_forbid([^_?m4go_])
## 1.
This is the improved (and renamed) `Use getopt.m4sh to generate libtool
option parser.' patch I promised yesterday. I'm pretty happy with this,
save that even though _LT_PROG_XSI_REPLACE correctly generates sed
scripts in config.status of the form:
sed -i .tmp -e '/^func_name ()$/,/^} # func_na
