Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

* Charles Wilson wrote on Sat, Aug 28, 2010 at 05:31:57PM CEST: > On 8/28/2010 11:31 AM, Ralf Wildenhues wrote: > > * Charles Wilson wrote on Sat, Aug 28, 2010 at 05:13:38PM CEST: > >> On 8/28/2010 9:21 AM, Ralf Wildenhues wrote: > >>> [__WINDOWS__, __CYGWIN__, _WIN32_WCE]: Define LT_DLSYM_CONS

Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

On Sat, 28 Aug 2010, Charles Wilson wrote: On 8/28/2010 11:43 AM, Vincent Torri wrote: On Sat, 28 Aug 2010, Charles Wilson wrote: On 8/28/2010 9:21 AM, Ralf Wildenhues wrote: [__WINDOWS__, __CYGWIN__, _WIN32_WCE]: Define LT_DLSYM_CONST I don't think __WINDOWS__ is the correct symbol; t

Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

On 8/28/2010 11:43 AM, Vincent Torri wrote: > On Sat, 28 Aug 2010, Charles Wilson wrote: >> On 8/28/2010 9:21 AM, Ralf Wildenhues wrote: >>> [__WINDOWS__, __CYGWIN__, _WIN32_WCE]: Define LT_DLSYM_CONST >> I don't think __WINDOWS__ is the correct symbol; that is only defined by >> Watcom C/C++.

Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

On Sat, 28 Aug 2010, Charles Wilson wrote: On 8/28/2010 9:21 AM, Ralf Wildenhues wrote: [__WINDOWS__, __CYGWIN__, _WIN32_WCE]: Define LT_DLSYM_CONST I don't think __WINDOWS__ is the correct symbol; that is only defined by Watcom C/C++. I think this should be changed to _WIN32 throughout.

Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

On 8/28/2010 11:31 AM, Ralf Wildenhues wrote: > * Charles Wilson wrote on Sat, Aug 28, 2010 at 05:13:38PM CEST: >> On 8/28/2010 9:21 AM, Ralf Wildenhues wrote: >>> [__WINDOWS__, __CYGWIN__, _WIN32_WCE]: Define LT_DLSYM_CONST >> I don't think __WINDOWS__ is the correct symbol; that is only defin

Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

Hi Charles, * Charles Wilson wrote on Sat, Aug 28, 2010 at 05:13:38PM CEST: > On 8/28/2010 9:21 AM, Ralf Wildenhues wrote: > > [__WINDOWS__, __CYGWIN__, _WIN32_WCE]: Define LT_DLSYM_CONST > I don't think __WINDOWS__ is the correct symbol; that is only defined by > Watcom C/C++. I think this sh

Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

On 8/28/2010 9:21 AM, Ralf Wildenhues wrote: > [__WINDOWS__, __CYGWIN__, _WIN32_WCE]: Define LT_DLSYM_CONST I don't think __WINDOWS__ is the correct symbol; that is only defined by Watcom C/C++. I think this should be changed to _WIN32 throughout. See http://predef.sourceforge.net/preos.html

Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

Since the question asked in: * Ralf Wildenhues wrote on Tue, Jun 29, 2010 at 06:49:39AM CEST: > > . was now answered in I feel confident enough for

Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

Hello Vincent, * Ralf Wildenhues wrote on Sat, Jun 19, 2010 at 12:08:29PM CEST: > I would like to commit the patch quoted below, on the way of support for > LTO with GCC. For that, I need to know from somebody who is willing to > help out with the Windows CE port of Libtool whether the #defines u

Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

Hello Vincent, all, I would like to commit the patch quoted below, on the way of support for LTO with GCC. For that, I need to know from somebody who is willing to help out with the Windows CE port of Libtool whether the #defines used in the patch are sufficient and correct. This is

[PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

On some systems, lt_preloaded_symbols may not be declared const due to relocation issues. C99 requires qualification to match for compatible declarations, so ensure we declare const'ness in the same way everywhere; link-time optimization may otherwise rightfully complain about inconsistencies. Sin