Re: [Libusbx-devel] Towards a 1.0.16 release, hotplug test branch, please test

2013-05-17 Thread Kustaa Nyholm
On 18/05/2013 02:19, "Pete Batard" wrote: > As a matter of fact, some unlikely people have already made a >first step towards that [1]... ;) ... >[1] https://www.kernel.org/doc/Documentation/stable_api_nonsense.txt Interesting reading, thanks. I don't know these people but I formed my opinion a

Re: [Libusbx-devel] [PATCH] Add support for BOS and Endpoint Companion USB 3.0 descriptors

2013-05-17 Thread Pete Batard
On 2013.05.17 14:43, Hans de Goede wrote: > With that said, I would have liked the new descriptor structures to > match, so that they can add > our version if the API, while keeping their own. Yeah, that's something I considered too. I've actually been 50/50 on keeping their not to great designat

Re: [Libusbx-devel] Towards a 1.0.16 release, hotplug test branch, please test

2013-05-17 Thread Pete Batard
On 2013.05.17 09:46, Hans de Goede wrote: >> but that'd mean changing the API... > > Right, which as we learned with the MaxPower is a complete no no, Not really. The only thing I learned is that we'll have to wait a bit longer for people to reach enlightenment about this whole API breakage bull

Re: [Libusbx-devel] [PATCH] Add support for BOS and Endpoint Companion USB 3.0 descriptors

2013-05-17 Thread Hans de Goede
Hi, On 05/13/2013 02:58 AM, Pete Batard wrote: > So, instead of looking at Hans' patch, as I should have, I decided to > spend some time on BOS and EP Companions, with the result being the proposed > solution above. > > Seems to work nicely against an FX3 device (also tested against an USB 3

Re: [Libusbx-devel] Towards a 1.0.16 release, hotplug test branch, please test

2013-05-17 Thread Hans de Goede
Hi, On 05/17/2013 03:04 AM, Pete Batard wrote: > Looks OK to me. Just a couple minor issues: > > > o io.c:1952:4: warning: Value stored to 'ret' is never read > ret = LIBUSB_ERROR_OTHER; > ^ ~~ > Looking at the source, we prob