Re: [Libusbx-devel] [m...@openbsd.org: Re: libusb: Update for OpenBSD's backend]

2013-08-01 Thread Xiaofan Chen
On Tue, Jul 30, 2013 at 11:38 PM, Hans de Goede wrote: > Hi Martin, > > On 07/16/2013 11:32 AM, Martin Pieuchot wrote: >> Hello Hans and Pete, >> >> You'll find below an update for OpenBSD's libusb backend, freshly >> rebased on top of the last libusb/libusbx release. >> >> I sent it twice to Pete

Re: [Libusbx-devel] [libusb] Possible alignment issues with struct libusb_transfer buffer pointer

2013-08-01 Thread Xiaofan Chen
On Wed, Jul 10, 2013 at 9:28 AM, Xiaofan Chen wrote: > On Thu, Jul 4, 2013 at 5:14 PM, Xiaofan Chen wrote: >> On Wed, Jul 3, 2013 at 3:29 AM, Sean McBride wrote: >>> On Tue, 2 Jul 2013 23:18:12 +0400, Paul Fertser said: What about documenting this in some special "API bugs" file or docum

Re: [Libusbx-devel] [libusbx] darwin: fix clang warnings about explicit conversion (b5acea3)

2013-08-01 Thread Nathan Hjelm
Not at all. The session id is internal to libusb so we can change it as we see fit.-NathanOn Aug 01, 2013, at 02:14 PM, Sean wrote:I just assumed change the session id to a uint64_t would be an API/ABI breakage... but didn't look...—Reply to this email directly or view it on GitHub.---

Re: [Libusbx-devel] [libusbx] darwin: fix clang warnings about explicit conversion (b5acea3)

2013-08-01 Thread Sean
I just assumed change the session id to a uint64_t would be an API/ABI breakage... but didn't look... --- Reply to this email directly or view it on GitHub: https://github.com/libusbx/libusbx/commit/b5acea3591ee713ec3392e8d3c8ba59e848d8641#commitcomment-3770292 ---

Re: [Libusbx-devel] [libusbx] darwin: fix clang warnings about explicit conversion (b5acea3)

2013-08-01 Thread Nathan Hjelm
Which is indeed the case! I will add some comments to that effect.While we are on this issue maybe we should discuss changing the session id to a uint64_t? I hate the use of long for this very reason.-NathanOn Aug 01, 2013, at 02:02 PM, Sean wrote:Might I suggest a comment in the code to that effe

Re: [Libusbx-devel] [libusbx] darwin: fix clang warnings about explicit conversion (b5acea3)

2013-08-01 Thread Sean
Might I suggest a comment in the code to that effect? On the surface it looks like one of those "add a cast to shut up the compiler" things. :( --- Reply to this email directly or view it on GitHub: https://github.com/libusbx/libusbx/commit/b5acea3591ee713ec3392e8d3c8ba59e848d8641#commitcomment-

Re: [Libusbx-devel] [libusbx] darwin: fix clang warnings about explicit conversion (b5acea3)

2013-08-01 Thread Nathan Hjelm
I know. But the lower 32 bits of the session ID should still be unique which is all I care about (since this is just the session id).-NathanOn Aug 01, 2013, at 01:34 PM, Sean wrote:Um, no. 'long' is precisely one of the types that is different size between 32 and 64 bit. See:https://developer.appl

Re: [Libusbx-devel] [libusbx] darwin: fix clang warnings about explicit conversion (b5acea3)

2013-08-01 Thread Sean
Um, no. 'long' is precisely one of the types that is different size between 32 and 64 bit. See: https://developer.apple.com/library/mac/#documentation/Darwin/Conceptual/64bitPorting/transition/transition.html The warning is correct. In 32 bit, UInt64 -> long is truncation. --- Reply to this

Re: [Libusbx-devel] Doing a 1.0.17 release

2013-08-01 Thread Sean McBride
On Thu, 1 Aug 2013 06:28:27 +0200, Ludovic Rousseau said: >I still have 2 commits from Sean in my Xcode branch: > >- Core: defensive programming >https://github.com/LudovicRousseau/libusbx/commit/ >5da4949cffacf1a19aeaf62ce796019daa50c49d >Not Xcode related. Maybe we can drop it. Why drop it? Th