[Libusbx-devel] [PATCH] linux_usbfs: Treat EINVAL as ENOTTY in cases where we may get ENOTTY

2014-03-11 Thread Hans de Goede
Older 64 bit kernels will return EINVAL to 32 bits userspace for unknown ioctls. So in places where we check for ENOTTY also check for EINVAL, and use the fallback path for EINVAL too. Note that if there really is an invalid parameter in the detach_kernel_driver_and_claim case, then the fallback p

Re: [Libusbx-devel] 32-bit libusbx broken on earlier 64-bit Linux kernels

2014-03-11 Thread Chris Dickens
Hi Hans, Patch works as expected, thanks! Regards, Chris On Tue, Mar 11, 2014 at 10:45 AM, Hans de Goede wrote: > Hi Chris, > > > On 03/11/2014 05:27 PM, Chris Dickens wrote: > >> Hi Hans, >> >> Are you sure this is what was happening ? Can you perhaps try again >> with >> a printf ad

Re: [Libusbx-devel] 32-bit libusbx broken on earlier 64-bit Linux kernels

2014-03-11 Thread Hans de Goede
Hi Chris, On 03/11/2014 05:27 PM, Chris Dickens wrote: Hi Hans, Are you sure this is what was happening ? Can you perhaps try again with a printf added at a strategic place to ensure this is really what is going on? Here's the debug output right after the DISCONNECT_CLAIM fails:

Re: [Libusbx-devel] 32-bit libusbx broken on earlier 64-bit Linux kernels

2014-03-11 Thread Chris Dickens
Hi Hans, Are you sure this is what was happening ? Can you perhaps try again with > a printf added at a strategic place to ensure this is really what is going > on? > Here's the debug output right after the DISCONNECT_CLAIM fails: [ 0.004913] [7d79] libusb: debug [libusb_claim_interface] int

Re: [Libusbx-devel] 32-bit libusbx broken on earlier 64-bit Linux kernels

2014-03-11 Thread Hans de Goede
Hi Chris, Thanks for the detailed bug report, and sorry for the slow reply. On 12/01/2013 08:56 AM, Chris Dickens wrote: > Hi, > > I recently had the need to compile a 32-bit version of the libusbx library > (v1.0.17) on a 64-bit RHEL 6.5 system (Linux Kernel v2.6.32). What I found > was that li