Re: [Libusbx-devel] Coverity: static analysis of libusbx

2013-08-26 Thread Nathan Hjelm
On Aug 26, 2013, at 8:18 PM, Nathan Hjelm wrote: > > On Aug 26, 2013, at 5:12 PM, Sean McBride wrote: > >> On Mon, 26 Aug 2013 22:33:10 +, Nathan Hjelm said: >> >>> Hmm, the conclusion is wrong. If ret > -1 the cached_device is always >>> not NULL. I should probably change: >>> >>> if (

Re: [Libusbx-devel] Coverity: static analysis of libusbx

2013-08-26 Thread Nathan Hjelm
On Aug 26, 2013, at 5:12 PM, Sean McBride wrote: > On Mon, 26 Aug 2013 22:33:10 +, Nathan Hjelm said: > >> Hmm, the conclusion is wrong. If ret > -1 the cached_device is always >> not NULL. I should probably change: >> >> if (ret < 0 || (cached_device && !cached_device->can_enumerate)) { >

Re: [Libusbx-devel] Coverity: static analysis of libusbx

2013-08-26 Thread Sean McBride
On Mon, 26 Aug 2013 22:33:10 +, Nathan Hjelm said: >Hmm, the conclusion is wrong. If ret > -1 the cached_device is always >not NULL. I should probably change: > >if (ret < 0 || (cached_device && !cached_device->can_enumerate)) { > >to: > >if (ret < 0 || !cached_device->can_enumerate) { > >to r

Re: [Libusbx-devel] Coverity: static analysis of libusbx

2013-08-26 Thread Nathan Hjelm
On Aug 26, 2013, at 04:22 PM, Sean McBride wrote:On Mon, 26 Aug 2013 20:47:33 +0200, Ludovic Rousseau said: I use Coverity as _another_ static analysis tool for my free softwareprojects. The clang static analyzer also gives one error in current git master: libusbx/libusb/os/darwin_usb.c:533:34: A

[Libusbx-devel] Coverity: static analysis of libusbx

2013-08-26 Thread Ludovic Rousseau
Hello, I registered the libusbx project at Coverity scan [1]. Coverity found 18 "problems". I exported a CSV list (attached) but the line numbers are missing so the results are not really usable in this form. If you are interested by the results it is best to create an account on Coverity and ask