Re: [Libusbx-devel] Minor compiler warning: enumeration value not handled in switch

2012-05-08 Thread Pete Batard
On 2012.05.08 19:29, Ludovic Rousseau wrote: > I suggest to NOT change any CFLAGS or other compilation option > selected by a developer/user. > > In my ~/.bash_profile file I have my own definition of CFLAGS and > CXXFLAGS but that is my choice. > > The good idea would be to use a high level of war

Re: [Libusbx-devel] Minor compiler warning: enumeration value not handled in switch

2012-05-08 Thread Ludovic Rousseau
2012/5/8 Pete Batard : > On 2012.05.08 14:59, Ludovic Rousseau wrote: >> I use the compiler option -Wswitch-enum: > > Depending on whether we have cross platform support for that option, do > you or anybody else think it may be worth enabling it by default? I suggest to NOT change any CFLAGS or ot

Re: [Libusbx-devel] Minor compiler warning: enumeration value not handled in switch

2012-05-08 Thread Pete Batard
On 2012.05.08 14:59, Ludovic Rousseau wrote: > I use the compiler option -Wswitch-enum: Depending on whether we have cross platform support for that option, do you or anybody else think it may be worth enabling it by default? > OK for LIBUSB_ERROR_IO > patch attached. Thanks. Now pushed. Regar

Re: [Libusbx-devel] Minor compiler warning: enumeration value not handled in switch

2012-05-08 Thread Ludovic Rousseau
2012/5/8 Pete Batard : > On 2012.05.08 12:16, Ludovic Rousseau wrote: >> I get these compiler warnings: >> >> sync.c: In function ‘libusb_control_transfer’: >> sync.c:122: warning: enumeration value ‘LIBUSB_TRANSFER_ERROR’ not >> handled in switch >> sync.c:122: warning: enumeration value ‘LIBUSB_T

Re: [Libusbx-devel] Minor compiler warning: enumeration value not handled in switch

2012-05-08 Thread Pete Batard
On 2012.05.08 12:16, Ludovic Rousseau wrote: > I get these compiler warnings: > > sync.c: In function ‘libusb_control_transfer’: > sync.c:122: warning: enumeration value ‘LIBUSB_TRANSFER_ERROR’ not > handled in switch > sync.c:122: warning: enumeration value ‘LIBUSB_TRANSFER_CANCELLED’ not > handle

[Libusbx-devel] Minor compiler warning: enumeration value not handled in switch

2012-05-08 Thread Ludovic Rousseau
Hello, I get these compiler warnings: sync.c: In function ‘libusb_control_transfer’: sync.c:122: warning: enumeration value ‘LIBUSB_TRANSFER_ERROR’ not handled in switch sync.c:122: warning: enumeration value ‘LIBUSB_TRANSFER_CANCELLED’ not handled in switch sync.c: In function ‘do_sync_bulk_tra