Re: [Libusbx-devel] Warnings from Intel Compiler

2012-06-22 Thread Orin Eman
On Fri, Jun 22, 2012 at 4:38 AM, Pete Batard wrote: > On 2012.06.21 21:42, Orin Eman wrote: > >> The patch is OK, but the compiler then throws the same warning on the >> next line ("return 1;") so you need to remove the next line as well. >> > > v2 attached. > > If you can confirm that everything

Re: [Libusbx-devel] Warnings from Intel Compiler

2012-06-22 Thread Sean McBride
On Fri, 22 Jun 2012 12:44:29 +0100, Pete Batard said: >On 2012.06.21 21:23, Sean McBride wrote: >> It would be nice to have nightly builds of libusbx where the resulting >errors/warnings are gathered together for display. > >I agree that it would be nice. However, > > *SNIP* I agree with all the

Re: [Libusbx-devel] Warnings from Intel Compiler

2012-06-22 Thread Pete Batard
On 2012.06.21 21:23, Sean McBride wrote: > It would be nice to have nightly builds of libusbx where the resulting > errors/warnings are gathered together for display. I agree that it would be nice. However, since this is volunteer based, I'm doubtful whether we can gather the minimal amount of v

Re: [Libusbx-devel] Warnings from Intel Compiler

2012-06-22 Thread Pete Batard
On 2012.06.21 21:42, Orin Eman wrote: The patch is OK, but the compiler then throws the same warning on the next line ("return 1;") so you need to remove the next line as well. v2 attached. If you can confirm that everything looks good on your end, and if nobody has further comment, I'll push

Re: [Libusbx-devel] Warnings from Intel Compiler

2012-06-21 Thread Orin Eman
On Thu, Jun 21, 2012 at 1:08 PM, Pete Batard wrote: > I'm gonna bump the priority of churning through the warnings, else I'm > pretty sure they're going to fall through. > > Proposed patch attached. Please let me know if still get reports for the > ones mentioned below. > All but the "statement

Re: [Libusbx-devel] Warnings from Intel Compiler

2012-06-21 Thread Sean McBride
On Thu, 21 Jun 2012 21:08:10 +0100, Pete Batard said: >I'm gonna bump the priority of churning through the warnings, else I'm >pretty sure they're going to fall through. It would be nice to have nightly builds of libusbx where the resulting errors/warnings are gathered together for display. Vo

Re: [Libusbx-devel] Warnings from Intel Compiler

2012-06-21 Thread Pete Batard
I'm gonna bump the priority of churning through the warnings, else I'm pretty sure they're going to fall through. Proposed patch attached. Please let me know if still get reports for the ones mentioned below. On 2012.06.19 19:41, Orin Eman wrote: ..\libusb\core.c(860): warning #188: enumerat

[Libusbx-devel] Warnings from Intel Compiler

2012-06-19 Thread Orin Eman
Since I have a copy, I compiled 1.0.12 with the Intel Compiler. I turned off the zero length array and unreferenced parameter warnings. This is what is left: Building with Intel(R) C++ Compiler 12.1 ClCompile: * ClCompile (Win32 - Intel C++) All outputs are up-to-date. core.c ..\libu