Re: [Libusbx-devel] some minor warning fixes

2012-06-01 Thread Ludovic Rousseau
2012/6/1 Pete Batard : > On 2012.06.01 13:49, Ludovic Rousseau wrote: >> -     const char *prefix; >> +     const char *prefix = "unknown"; >>       struct timeval now; >>       int global_debug; >>       static int has_debug_header_been_displayed = 0; >> @@ -1828,8 +1828,8 @@ void usbi_log_v(struc

Re: [Libusbx-devel] some minor warning fixes

2012-06-01 Thread Pete Batard
On 2012.06.01 13:49, Ludovic Rousseau wrote: > - const char *prefix; > + const char *prefix = "unknown"; > struct timeval now; > int global_debug; > static int has_debug_header_been_displayed = 0; > @@ -1828,8 +1828,8 @@ void usbi_log_v(struct libusb_context *ctx, enum >

Re: [Libusbx-devel] some minor warning fixes

2012-06-01 Thread Pete Batard
On 2012.06.01 13:44, Ludovic Rousseau wrote: > This patch was made automatically by the autoupdate command. > So I can't really elaborate I guess that means that one of the newer macros could require 2.68+ > Autoconf 2.50 was released in Jul 2001. > Autoconf 2.68 was released in Sep 2010. This c

Re: [Libusbx-devel] some minor warning fixes

2012-06-01 Thread Sean McBride
On Fri, 1 Jun 2012 12:53:26 +0100, Pete Batard said: >o [PATCH 1/4] autoupdate using autoupdate (GNU Autoconf) 2.68 >-AC_PREREQ([2.50]) >+AC_PREREQ([2.68]) >Overall looks OK, but can you elaborate on the above? Indeed, that seems like much more than a 'minor warning fix'! :) Mac OS X 10.5 & 10.6

Re: [Libusbx-devel] some minor warning fixes

2012-06-01 Thread Ludovic Rousseau
2012/6/1 Pete Batard : > The other ones look good to me. Update for 0004-Fix-compiler-warning.patch to fix an compiler error introduced by the patch: core.c:1839:10: warning: 'prefix' may be used uninitialized in this function [-Wuninitialized] --  Dr. Ludovic Rousseau 0004-Fix-compiler-warnin

Re: [Libusbx-devel] some minor warning fixes

2012-06-01 Thread Ludovic Rousseau
2012/6/1 Pete Batard : > o [PATCH 1/4] autoupdate using autoupdate (GNU Autoconf) 2.68 > -AC_PREREQ([2.50]) > +AC_PREREQ([2.68]) > Overall looks OK, but can you elaborate on the above? Is that due to the > AC_CONFIG_HEADERS or AM_CPPFLAGS or is it something else? This patch was made automatically

Re: [Libusbx-devel] some minor warning fixes

2012-06-01 Thread Pete Batard
On 2012.06.01 10:56, Ludovic Rousseau wrote: > These are small patches to fix small warnings. Thanks. One day I'll learn to set my function calls to static by default in xusb... o [PATCH 1/4] autoupdate using autoupdate (GNU Autoconf) 2.68 -AC_PREREQ([2.50]) +AC_PREREQ([2.68]) Overall looks OK,

[Libusbx-devel] some minor warning fixes

2012-06-01 Thread Ludovic Rousseau
Hello, These are small patches to fix small warnings. Bye --  Dr. Ludovic Rousseau 0001-autoupdate-using-autoupdate-GNU-Autoconf-2.68.patch Description: Binary data 0002-Fix-autoreconf-warning.patch Description: Binary data 0003-Fix-compiler-warning-no-previous-prototype.patch Description