[Libusbx-devel] some minor warning fixes

2012-06-01 Thread Ludovic Rousseau
Hello, These are small patches to fix small warnings. Bye --  Dr. Ludovic Rousseau 0001-autoupdate-using-autoupdate-GNU-Autoconf-2.68.patch Description: Binary data 0002-Fix-autoreconf-warning.patch Description: Binary data 0003-Fix-compiler-warning-no-previous-prototype.patch Description

Re: [Libusbx-devel] [PATCH] Send all logging output to stderr

2012-06-01 Thread Ludovic Rousseau
Hello, 2012/5/28 Pete Batard : > v2. There were a couple more mentions of stdout in the doc that needed > amending. Any progress on this patch? I vote for its inclusion. Bye --  Dr. Ludovic Rousseau -- Live Security V

Re: [Libusbx-devel] [PATCH] Send all logging output to stderr

2012-06-01 Thread Pete Batard
On 2012.06.01 10:57, Ludovic Rousseau wrote: > Any progress on this patch? > I vote for its inclusion. Now pushed. ;) I also pushed another commit with more realignment of the OS-X logging levels [1]. This is a follow up of the stalled pipe message we got with xusb for the 0xEE string descripto

[Libusbx-devel] [PATCH] Toggleable debug logging support

2012-06-01 Thread Pete Batard
Moving on on the roadmap. This patch ensures that debug logging messages are always included in the library and can be turned on or off by changing the log level. I tried to keep things simple, so this modifies the existing behaviour where debug messages were only included (and enable) with t

Re: [Libusbx-devel] some minor warning fixes

2012-06-01 Thread Pete Batard
On 2012.06.01 10:56, Ludovic Rousseau wrote: > These are small patches to fix small warnings. Thanks. One day I'll learn to set my function calls to static by default in xusb... o [PATCH 1/4] autoupdate using autoupdate (GNU Autoconf) 2.68 -AC_PREREQ([2.50]) +AC_PREREQ([2.68]) Overall looks OK,

Re: [Libusbx-devel] some minor warning fixes

2012-06-01 Thread Ludovic Rousseau
2012/6/1 Pete Batard : > o [PATCH 1/4] autoupdate using autoupdate (GNU Autoconf) 2.68 > -AC_PREREQ([2.50]) > +AC_PREREQ([2.68]) > Overall looks OK, but can you elaborate on the above? Is that due to the > AC_CONFIG_HEADERS or AM_CPPFLAGS or is it something else? This patch was made automatically

Re: [Libusbx-devel] [PATCH] Toggleable debug logging support

2012-06-01 Thread Xiaofan Chen
On Fri, Jun 1, 2012 at 7:44 PM, Pete Batard wrote: > With this patch, unless you use --disable-log, then all logging messages are > available, and debug logging can be turned on with either a call to > libusb_set_debug (relies on a context having been initialized, even if NULL > is passed, so MUST

Re: [Libusbx-devel] some minor warning fixes

2012-06-01 Thread Ludovic Rousseau
2012/6/1 Pete Batard : > The other ones look good to me. Update for 0004-Fix-compiler-warning.patch to fix an compiler error introduced by the patch: core.c:1839:10: warning: 'prefix' may be used uninitialized in this function [-Wuninitialized] --  Dr. Ludovic Rousseau 0004-Fix-compiler-warnin

Re: [Libusbx-devel] some minor warning fixes

2012-06-01 Thread Sean McBride
On Fri, 1 Jun 2012 12:53:26 +0100, Pete Batard said: >o [PATCH 1/4] autoupdate using autoupdate (GNU Autoconf) 2.68 >-AC_PREREQ([2.50]) >+AC_PREREQ([2.68]) >Overall looks OK, but can you elaborate on the above? Indeed, that seems like much more than a 'minor warning fix'! :) Mac OS X 10.5 & 10.6

Re: [Libusbx-devel] some minor warning fixes

2012-06-01 Thread Pete Batard
On 2012.06.01 13:44, Ludovic Rousseau wrote: > This patch was made automatically by the autoupdate command. > So I can't really elaborate I guess that means that one of the newer macros could require 2.68+ > Autoconf 2.50 was released in Jul 2001. > Autoconf 2.68 was released in Sep 2010. This c

Re: [Libusbx-devel] some minor warning fixes

2012-06-01 Thread Pete Batard
On 2012.06.01 13:49, Ludovic Rousseau wrote: > - const char *prefix; > + const char *prefix = "unknown"; > struct timeval now; > int global_debug; > static int has_debug_header_been_displayed = 0; > @@ -1828,8 +1828,8 @@ void usbi_log_v(struct libusb_context *ctx, enum >

Re: [Libusbx-devel] [PATCH] Toggleable debug logging support

2012-06-01 Thread Pete Batard
On 2012.06.01 13:45, Xiaofan Chen wrote: > So this mean that LIBUSB_DEBUG=4 will have the same effect as > the previous --enable-debug-log, right? Pretty much, with the one small limitation that whereas --enable-debug-log allows debug output outside of a context having been initialized, LIBUSB_D

Re: [Libusbx-devel] some minor warning fixes

2012-06-01 Thread Ludovic Rousseau
2012/6/1 Pete Batard : > On 2012.06.01 13:49, Ludovic Rousseau wrote: >> -     const char *prefix; >> +     const char *prefix = "unknown"; >>       struct timeval now; >>       int global_debug; >>       static int has_debug_header_been_displayed = 0; >> @@ -1828,8 +1828,8 @@ void usbi_log_v(struc