Re: [Libusbx-devel] [PATCH] Add HID capability detection for all backends

2013-03-22 Thread Hans de Goede
Hi, On 03/22/2013 01:16 AM, Pete Batard wrote: > On 2013.03.21 20:06, Ludovic Rousseau wrote: >> Maybe LIBUSBX_IMPLEMENTS_DETACH_KERNEL_DRIVER > > Works for me. I've a small nitpick, lets call it LIBUSB_CAP_SUPPORTS_DETACH_KERNEL_DRIVER to match with the LIBUSB_ERROR_NOT_SUPPORTED error code. >>

Re: [Libusbx-devel] [PATCH] Add HID capability detection for all backends

2013-03-22 Thread Ludovic Rousseau
2013/3/22 Hans de Goede : > Although automatic detaching may seem like a smart and user (programmer) > friendly thing to do, I'm very much against it! Let me explain > why: > > a) libusb_detach_kernel_driver on Linux will *always* work if the > user has the necessary rights on the usbfs device node

[Libusbx-devel] [PATCH] Fix HID descriptor creation code in Windows backend

2013-03-22 Thread Toby Gray
Hi, I've been investigating a STATUS_STACK_BUFFER_OVERRUN (0xc409) exception when running the latest libusbx in Windows XP. I believe it's due to a bug in how the fake USB descriptors for HID devices are created. The location of the second endpoint was being calculated incorrectly in _hid

Re: [Libusbx-devel] [PATCH] Fix HID descriptor creation code in Windows backend

2013-03-22 Thread Toby Gray
On 22/03/13 13:57, Toby Gray wrote: > > I also can't reproduce it with debug builds of libusbx, only release > binaries. I've just realised that the reason for this must be that debug builds aren't optimising out the variables around the buffer which is overrun. As these variables aren't used a

Re: [Libusbx-devel] [PATCH] Add HID capability detection for all backends

2013-03-22 Thread Hans de Goede
Hi, On 03/22/2013 10:58 AM, Ludovic Rousseau wrote: > 2013/3/22 Hans de Goede : >> Although automatic detaching may seem like a smart and user (programmer) >> friendly thing to do, I'm very much against it! Let me explain >> why: >> >> a) libusb_detach_kernel_driver on Linux will *always* work if

Re: [Libusbx-devel] [PATCH] Fix HID descriptor creation code in Windows backend

2013-03-22 Thread Tim Roberts
Toby Gray wrote: > Hi, > > I've been investigating a STATUS_STACK_BUFFER_OVERRUN (0xc409) > exception when running the latest libusbx in Windows XP. I believe it's > due to a bug in how the fake USB descriptors for HID devices are > created. The location of the second endpoint was being calc

Re: [Libusbx-devel] [PATCH] Add HID capability detection for all backends

2013-03-22 Thread Ludovic Rousseau
2013/3/22 Hans de Goede : > Hi, > > > On 03/22/2013 10:58 AM, Ludovic Rousseau wrote: >> >> 2013/3/22 Hans de Goede : >>> >>> Although automatic detaching may seem like a smart and user (programmer) >>> friendly thing to do, I'm very much against it! Let me explain >>> why: >>> >>> a) libusb_detach

Re: [Libusbx-devel] WinCE integration (was: 2 new commits in libusbx)

2013-03-22 Thread Toby Gray
On 23/01/13 13:37, Xiaofan Chen wrote: 1) Windows CE USB Wrapper: https://github.com/RealVNC/CEUSBKWrapper If you're building for a WinCE 5.0 system then you'll have trouble. The big (and hopefully only) issue is that between WinCE 5.0 and WinCE 6.0 the method for kernel code to access user mem

Re: [Libusbx-devel] [PATCH] Add HID capability detection for all backends

2013-03-22 Thread Pete Batard
On 2013.03.22 17:25, Ludovic Rousseau wrote: > Change: Auto detach is now fine for me. OK. I wasn't actually proposing such a change, since, unless somebody volunteers to create a patch, it's extremely unlikely that I'll have time to spend on that. At any rate, even if there's a volunteer, this

Re: [Libusbx-devel] [PATCH] Fix HID descriptor creation code in Windows backend

2013-03-22 Thread Pete Batard
On 2013.03.22 17:24, Tim Roberts wrote: > Toby Gray wrote: >> I've been investigating a STATUS_STACK_BUFFER_OVERRUN (0xc409) >> exception when running the latest libusbx in Windows XP. I believe it's >> due to a bug in how the fake USB descriptors for HID devices are >> created. The location of

Re: [Libusbx-devel] WinCE integration (was: 2 new commits in libusbx)

2013-03-22 Thread Pete Batard
On 2013.03.22 18:16, Toby Gray wrote: > I appreciate that this is 2 months later. Given our current pace, this isn't really a problem ;) > But I've finally found the > spare time to try to add WinCE 5 support to CEUSBKwrapper. > > I've attached a couple of patches. Don't feel any pressure to try