Re: [Libusbx-devel] Announcing libusbx-1.0.16-rc2

2013-07-02 Thread Xiaofan Chen
On Tue, Jul 2, 2013 at 1:32 PM, Xiaofan Chen wrote: > On Tue, Jul 2, 2013 at 11:44 AM, Xiaofan Chen wrote: >> Sorry for the false alarm. It seems to do with using WinZIP >> to un-archive the tar.bz2 file. Using MSys utility sorted out >> the issue. Normally I am using 7-zip and/or MSys utility >>

Re: [Libusbx-devel] Announcing libusbx-1.0.16-rc2

2013-07-02 Thread Hans de Goede
Hi, On 07/01/2013 11:45 PM, Pete Batard wrote: > Thanks for RC2, but did you forget to push your RC2 commit by any > chance? The public git repo has neither the version.h update or the rc2 tag. Yes I did, sorry. I know it was going to smoothly / already had the feeligng I was forgetting something

Re: [Libusbx-devel] [libusb] Possible alignment issues with struct libusb_transfer buffer pointer

2013-07-02 Thread Hans de Goede
Hi, On 07/01/2013 07:07 PM, Paul Fertser wrote: > On Mon, Jul 01, 2013 at 12:02:45PM +0200, Hans de Goede wrote: >> Unaligned accesses on architectures which don't support it, either get >> trapped and emulated (with a fat warnign logged somewhere), or get trapped >> and terminate the program. So

Re: [Libusbx-devel] [libusb] Possible alignment issues with struct libusb_transfer buffer pointer

2013-07-02 Thread Paul Fertser
On Tue, Jul 02, 2013 at 11:52:17AM +0200, Hans de Goede wrote: > Thanks! I'll apply this to master once 1.0.16 is out the door. Note I plan to > drop the __attribute__ ((aligned (2))), as we support compilers other then > gcc. I know but that's inside a comment and serves documentation purposes,

Re: [Libusbx-devel] [libusb] Possible alignment issues with struct libusb_transfer buffer pointer

2013-07-02 Thread Hans de Goede
Hi, On 07/02/2013 12:13 PM, Paul Fertser wrote: > On Tue, Jul 02, 2013 at 11:52:17AM +0200, Hans de Goede wrote: >> Thanks! I'll apply this to master once 1.0.16 is out the door. Note I plan to >> drop the __attribute__ ((aligned (2))), as we support compilers other then >> gcc. > > I know but th

Re: [Libusbx-devel] Announcing libusbx-1.0.16-rc2

2013-07-02 Thread Xiaofan Chen
On Mon, Jul 1, 2013 at 7:14 PM, Hans de Goede wrote: > You can find 1.0.16-rc2 docs including all the new API-s here: > http://people.fedoraproject.org/~jwrdegoede/libusb-reference/ One issue here: http://people.fedoraproject.org/~jwrdegoede/libusb-reference/group__hotplug.html This does not men

Re: [Libusbx-devel] Announcing libusbx-1.0.16-rc2

2013-07-02 Thread Pete Batard
On 2013.07.02 15:11, Xiaofan Chen wrote: > This does not mention that libusbx-1.0.16 will only support > hotplug under Linux and Mac OS X. So probably it is > good to fix the documentations. I think what we probably want to do is indicate that before using hotplug on a platform, you should check

Re: [Libusbx-devel] [libusb] Possible alignment issues with struct libusb_transfer buffer pointer

2013-07-02 Thread Sean McBride
On Mon, 1 Jul 2013 12:02:45 +0200, Hans de Goede said: >Unaligned accesses on architectures which don't support it, either get >trapped and emulated (with a fat warnign logged somewhere), or get trapped >and terminate the program. So I don't think this may cause "subtle" bugs. > >I do agree it cou

Re: [Libusbx-devel] [libusb] Possible alignment issues with struct libusb_transfer buffer pointer

2013-07-02 Thread Sean McBride
On Tue, 2 Jul 2013 23:18:12 +0400, Paul Fertser said: >On Tue, Jul 02, 2013 at 02:43:54PM -0400, Sean McBride wrote: >> I don't think Paul's patch should be committed, at least not as-is. >> It adds strange double casts (with no comment) that future readers >> of the code will wonder about > >What

Re: [Libusbx-devel] [libusb] Possible alignment issues with struct libusb_transfer buffer pointer

2013-07-02 Thread Paul Fertser
On Tue, Jul 02, 2013 at 02:43:54PM -0400, Sean McBride wrote: > I don't think Paul's patch should be committed, at least not as-is. > It adds strange double casts (with no comment) that future readers > of the code will wonder about What else can a reader think of seeing a double cast via void* (a