Re: [Libusbx-devel] usbdevfs: BULK_CONTINUATION flag does not work with XHCI controller

2012-06-04 Thread Sarah Sharp
the short packet. Otherwise we could have the case where multiple URBs are queued for a bulk endpoint, a short packet stops the endpoint ring, the xHCI driver never restarts the endpoint ring running, and then the queued URBs just sit on the endpoint ring. Sarah Sharp --

Re: [Libusbx-devel] usbdevfs: BULK_CONTINUATION flag does not work with XHCI controller

2012-06-04 Thread Sarah Sharp
gt; No, the cancellation doesn't come too late. Rather, the endpoint queue > did not get stopped as it should when the EREMOTEIO error occurred. Why would the xHCI endpoint queue get stopped after an EREMOTEIO error? The upper layers never clear a halt on a short bulk packet, so the xHCI

Re: [Libusbx-devel] usbdevfs: BULK_CONTINUATION flag does not work with XHCI controller

2012-06-04 Thread Sarah Sharp
the completion > handler (for the URB that got the short packet) returns. Doing it > earlier is a bug. Ok, let me take a look at that xHCI ring code and see if I can come up with a patch. I think if I let the completion handler run first, it should queue any cancellations for th

Re: [Libusbx-devel] [RFC] xhci: Let completion handlers run before rings are restarted.

2012-06-07 Thread Sarah Sharp
mat that would make it hard to share code with lsusb? > [1] https://sourceforge.net/apps/trac/libusbx/roadmap > [2] > https://sourceforge.net/mailarchive/forum.php?thread_name=4FCCA5E3.8080101%40akeo.ie&forum_name=libusbx-devel Sarah Sharp ---

Re: [Libusbx-devel] Do you need a product ID for your open source project?

2012-06-07 Thread Sarah Sharp
en source devices. You should contact Greg KH to get the approval process rolling. Sarah Sharp -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has c

Re: [Libusbx-devel] xhci driver fails and corrupt memory

2012-06-25 Thread Sarah Sharp
maybe?..)? Let's try with the NEC host controller, since that's a bit more stable than the Fresco Logic host. Can you try running with my for-usb-linus branch? I just fixed a bug related to successive stalls corrupting the software ring state. Send me the dmesg with xHCI debugging

Re: [Libusbx-devel] xhci driver fails and corrupt memory

2012-07-02 Thread Sarah Sharp
two during > certain operations. I haven't seen it before, with other kernels. The 3.5 kernel added USB 3.0 Link Power Management. It's turned for all USB 3.0 devices. What do you mean by "hang"? As in userspace hangs? khubd hangs? Sarah Sharp --

Re: [Libusbx-devel] Linux xHCI driver problems

2012-09-24 Thread Sarah Sharp
point was actually halted due to a stall, babble, transfer error, etc. It won't reset the endpoint toggles or sequence number at arbitrary points, so we can't reset the endpoint after a new alternate interface setting is installed. Sarah Sharp ---

Re: [Libusbx-devel] Sequence number not incremented for large control transfer

2012-10-22 Thread Sarah Sharp
e time to work on this patch, so please take a stab at it if you have some time. The cancellation code might need some work to handle multi-TRB data phases as well, but we shouldn't worry about that until we see if this work-around helps the AsMedia host. Sarah Sharp > On Tue, Oct 2,

Re: [Libusbx-devel] USB3 Error

2013-02-25 Thread Sarah Sharp
; > Correct run: http://pastebin.com/Nh487CXn > >> > Second run(error): http://pastebin.com/RrcS3f70 > >> > Kernel log from the whole time: http://pastebin.com/gL002CrS I note that after several untransferred bytes, the driver attempts

Re: [Libusbx-devel] USB3 Error

2013-02-28 Thread Sarah Sharp
at's the problem then. Some cameras may need the clear halt request, and the xHCI won't send it because the endpoints aren't halted. Fixing this is on my todo list, but not very high right now. Sarah Sharp > The second call then fails to send the bulk transfers at all, just like

Re: [Libusbx-devel] USB3 Error

2013-03-11 Thread Sarah Sharp
On Sat, Mar 09, 2013 at 09:16:53PM +0100, Marcus Meissner wrote: > On Thu, Feb 28, 2013 at 09:32:05AM -0800, Sarah Sharp wrote: > > On Thu, Feb 28, 2013 at 04:59:36PM +0100, Marcus Meissner wrote: > > > Hi, > > > > > > Something must happen after the

Re: [Libusbx-devel] USB3 Error

2013-03-13 Thread Sarah Sharp
On Wed, Mar 13, 2013 at 01:37:35PM +0800, Xiaofan Chen wrote: > On Tue, Mar 12, 2013 at 2:10 PM, Marcus Meissner wrote: > > On Mon, Mar 11, 2013 at 03:30:19PM -0700, Sarah Sharp wrote: > >> On Sat, Mar 09, 2013 at 09:16:53PM +0100, Marcus Meissner wrote: > >> > On T

[Libusbx-devel] Need testers for long-standing xHCI clear halt bug

2013-10-10 Thread Sarah Sharp
u try the test again with the two patches? Hi Yuliya, You ran into this issue as well, back in Oct 2012. You added a set interface to your driver to work around the issue. If you're still working on that code, can you take the set interface out, test these two patches, and let me know if you

Re: [Libusbx-devel] Need testers for long-standing xHCI clear halt bug

2013-10-14 Thread Sarah Sharp
7;s not needed, but I want to double check that the code still works without it. Thanks, Sarah Sharp > On Thu, Oct 10, 2013 at 02:43:49PM -0700, Sarah Sharp wrote: > > Hi Sipter and Marcus, > > > > Xenia has a potential fix for a long-standing bug in the xHCI driver, >

Re: [Libusbx-devel] [PATCH 9/9] usbfs: Add support for allocating / freeing streams

2013-11-14 Thread Sarah Sharp
not sure where you got that value. Each xHCI host can indicate the max primary stream array size (basically the number of streams) it supports, see MaxPSASize in section 5.3.6 of the xHCI spec. An xHCI host can choose to indicate it doesn't support streams at all, by setting that value to zero