Re: [Libva] [PATCH 1/2] test/encode: remove unused variables and functions

2015-09-16 Thread Kelley, Sean V
On Thu, 2015-09-17 at 08:54 +0800, Zhao Yakui wrote: On 09/17/2015 12:12 AM, U. Artie Eoff wrote: > This gets rid of compiler warnings caused by various unused > variables and functions. The variables are not used and it is OK to remove them for fixing the compiler warnings. This patch looks go

Re: [Libva] [PATCH 2/2] test/encode: remove dead code

2015-09-16 Thread Kelley, Sean V
On Thu, 2015-09-17 at 08:42 +0800, Zhao Yakui wrote: On 09/17/2015 12:12 AM, U. Artie Eoff wrote: > Remove commented code and their functions that are no > longer executed. This erradicates some compiler warnings > for unused functions. The commented code will be used if the H264encoding test c

Re: [Libva] [PATCH 1/2] test/encode: remove unused variables and functions

2015-09-16 Thread Zhao Yakui
On 09/17/2015 12:12 AM, U. Artie Eoff wrote: This gets rid of compiler warnings caused by various unused variables and functions. The variables are not used and it is OK to remove them for fixing the compiler warnings. This patch looks good to me. Signed-off-by: U. Artie Eoff --- test/e

Re: [Libva] [PATCH 2/2] test/encode: remove dead code

2015-09-16 Thread Zhao Yakui
On 09/17/2015 12:12 AM, U. Artie Eoff wrote: Remove commented code and their functions that are no longer executed. This erradicates some compiler warnings for unused functions. The commented code will be used if the H264encoding test case works in another mode(That is to say: The H264 slice

Re: [Libva] [PATCH 1/2] test/encode: remove unused variables and functions

2015-09-16 Thread Sean V Kelley
+Haihao, Yakui Can you comment on what appears to be code brought in from h264encode that isn't being exercised? There are two things here I want to understand: 1) Brought in from h264encode, oversight? 2) Commented out for specific manual testing or not? I want to hold off on this merge until

[Libva] [PATCH 1/2] test/encode: remove unused variables and functions

2015-09-16 Thread U. Artie Eoff
This gets rid of compiler warnings caused by various unused variables and functions. Signed-off-by: U. Artie Eoff --- test/encode/avcenc.c | 44 ++-- test/encode/mpeg2vaenc.c | 1 - test/loadsurface.h | 24 3 files chang

[Libva] [PATCH 2/2] test/encode: remove dead code

2015-09-16 Thread U. Artie Eoff
Remove commented code and their functions that are no longer executed. This erradicates some compiler warnings for unused functions. Signed-off-by: U. Artie Eoff --- test/encode/h264encode.c | 171 --- 1 file changed, 171 deletions(-) diff --git a/te

[Libva] Scale of vaapisink

2015-09-16 Thread Engin Firat
Hello all, I render decoded frames on a QtWidget with the help of a vaapisink with the following code: *gst_video_overlay_set_window_handle(GST_VIDEO_OVERLAY(videoSink), widget->winId());* here videosink is a vaapisink and widget is a pointer to QWidget. The rendering is successful but whenever