Re: [Libva] [PATCH] shaders: gen[789]: fix Y coefficient in YUV->RGB conversion

2015-10-21 Thread Zhao Yakui
On 10/21/2015 06:13 PM, Lionel Landwerlin wrote: On 21/10/15 01:57, Zhao Yakui wrote: On 10/21/2015 12:48 AM, Lionel Landwerlin wrote: In the following formula for the conversion : R = Clamp ( 1.164(Y-16/255) + 1.596(Cr-128/255)) G = Clamp ( 1.164(Y-16/255) - 0.813(Cr-128/255) - 0.392(Cb-128/2

Re: [Libva] Weird memory problem around vaGetDisplay

2015-10-21 Thread Ratin
Found the culprit, it was missing header (libva_x11.h). If anybody interested to know, this caused the compiler to think the function will return a 32 bit pointer, so the compiler inserted a cltq statement into the assembly code which was flipping the upper 32 bits to all 1s. On Wed, Oct 21, 2015

Re: [Libva] Weird memory problem around vaGetDisplay

2015-10-21 Thread Ratin
# uname -a Linux nuc1 3.16.0-51-generic #69~14.04.1-Ubuntu SMP Wed Oct 7 15:32:41 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux On Wed, Oct 21, 2015 at 12:13 PM, Ratin wrote: > Breakpoint 1, vaGetDisplay (native_dpy=0x7fffe4312870) at va_x11.c:154 > 154{ > (gdb) list > 149 > 150 > 151VADisp

[Libva] Weird memory problem around vaGetDisplay

2015-10-21 Thread Ratin
Breakpoint 1, vaGetDisplay (native_dpy=0x7fffe4312870) at va_x11.c:154 154{ (gdb) list 149 150 151VADisplay vaGetDisplay ( 152Display *native_dpy /* implementation specific */ 153) 154{ 155 VADisplay dpy = NULL; 156 VADisplayContextP pDisplayContext; 157 ;;; 179

Re: [Libva] [PATCH] shaders: gen[789]: fix Y coefficient in YUV->RGB conversion

2015-10-21 Thread Gwenole Beauchesne
2015-10-20 18:48 GMT+02:00 Lionel Landwerlin : > In the following formula for the conversion : > > R = Clamp ( 1.164(Y-16/255) + 1.596(Cr-128/255)) > G = Clamp ( 1.164(Y-16/255) - 0.813(Cr-128/255) - 0.392(Cb-128/255)) > B = Clamp ( 1.164(Y-16/255) + 2.017(Cb-128/255)) > > we must substract 16 (or

Re: [Libva] [PATCH] shaders: gen[789]: fix Y coefficient in YUV->RGB conversion

2015-10-21 Thread Gwenole Beauchesne
2015-10-21 12:13 GMT+02:00 Lionel Landwerlin : > On 21/10/15 01:57, Zhao Yakui wrote: >> >> On 10/21/2015 12:48 AM, Lionel Landwerlin wrote: >>> >>> In the following formula for the conversion : >>> >>> R = Clamp ( 1.164(Y-16/255) + 1.596(Cr-128/255)) >>> G = Clamp ( 1.164(Y-16/255) - 0.813(Cr-128/

Re: [Libva] [PATCH] shaders: gen[789]: fix Y coefficient in YUV->RGB conversion

2015-10-21 Thread Lionel Landwerlin
On 21/10/15 01:57, Zhao Yakui wrote: On 10/21/2015 12:48 AM, Lionel Landwerlin wrote: In the following formula for the conversion : R = Clamp ( 1.164(Y-16/255) + 1.596(Cr-128/255)) G = Clamp ( 1.164(Y-16/255) - 0.813(Cr-128/255) - 0.392(Cb-128/255)) B = Clamp ( 1.164(Y-16/255) + 2.017(Cb-128/25