[Libva] [PATCH] Changed 'c' variable 'char' data type to 'int' data type.

2016-07-01 Thread Lim Siew Hoon
The getopt_long func is return integer data type is more than 1 bytes. Already access invalid memory location since size of 'c' is char data type. Signed-off-by: Lim Siew Hoon --- test/encode/h264encode.c| 2 +- test/putsurface/putsurface_common.c | 2 +- 2

Re: [Libva] [PATCH 2/3] Encoding: Add ROI example

2016-07-01 Thread Qu, Pengfei
-Original Message- From: Libva [mailto:libva-boun...@lists.freedesktop.org] On Behalf Of Sreerenj Sent: Thursday, June 30, 2016 9:01 PM To: libva@lists.freedesktop.org Subject: Re: [Libva] [PATCH 2/3] Encoding: Add ROI example On 30.06.2016 04:49, Pengfei Qu wrote: > From: Zhao Yakui

Re: [Libva] [PATCH 06/14] Encoding: Dynamically select one mechanism to construct encoding command buffer for each frame on Haswell and Gen7/Gen6

2016-07-01 Thread Xiang, Haihao
LGTM. Thanks Haihao > From: Zhao Yakui > > v1: combine the Haswell and Gen7/6 patch together > > Currently it uses the fixed policy to construct encoding command > buffer. > (Use CPU or GPU). And it is statically compiled. > But sometimes it needs to choose the

Re: [Libva] [PATCH 01/14] Encoding: Abstract the calculation of mbmv cost for qp as one function and Add one function that initialize mbmv cost table for supported Qp range

2016-07-01 Thread Zhao Yakui
On 07/01/2016 02:40 PM, Xiang, Haihao wrote: On Fri, 2016-07-01 at 14:11 +0800, Zhao Yakui wrote: On 07/01/2016 12:49 PM, Xiang, Haihao wrote: From: Zhao Yakui Signed-off-by: Zhao Yakui Signed-off-by: pjl Signed-off-by:

Re: [Libva] Full HD h264 choppy on Core i5 M 520 (nehalem)

2016-07-01 Thread dE
It gives the same performance as the 1.7 one. I too noticed the 'libva 1.4.1'... looking on this. Will revert. On 07/01/16 12:05, Xiang, Haihao wrote: Hi! I got this CPU an old laptop -- |processor : 0|| ||vendor_id : GenuineIntel|| ||cpu family : 6|| ||model :

Re: [Libva] [PATCH 01/14] Encoding: Abstract the calculation of mbmv cost for qp as one function and Add one function that initialize mbmv cost table for supported Qp range

2016-07-01 Thread Xiang, Haihao
On Fri, 2016-07-01 at 14:11 +0800, Zhao Yakui wrote: > On 07/01/2016 12:49 PM, Xiang, Haihao wrote: > > > > > > > From: Zhao Yakui > > > > > > Signed-off-by: Zhao Yakui > > > Signed-off-by: pjl > > > Signed-off-by: Pengfei

Re: [Libva] Full HD h264 choppy on Core i5 M 520 (nehalem)

2016-07-01 Thread Xiang, Haihao
Hi! I got this CPU an old laptop -- processor : 0 vendor_id : GenuineIntel cpu family : 6 model : 37 model name : Intel(R) Core(TM) i5 CPU M 520 @ 2.40GHz stepping: 2 microcode : 0x9 cpu MHz : 1199.000 cache size : 3072 KB

Re: [Libva] [PATCH 04/14] encoding: Send VME instruction uses one register as the desc parameter instead of hardcode

2016-07-01 Thread Xiang, Haihao
This patch LGTM, but one question: does Gen8+ need a similar patch? Thanks Haihao > From: Zhao Yakui > > The desc parameter of current VME send instruction is hardcode. And > it can't > be updated based on the input parameter. > > Signed-off-by: Zhao Yakui

[Libva] Full HD h264 choppy on Core i5 M 520 (nehalem)

2016-07-01 Thread dE
Hi! I got this CPU an old laptop -- |processor : 0|| ||vendor_id : GenuineIntel|| ||cpu family : 6|| ||model : 37|| ||model name : Intel(R) Core(TM) i5 CPU M 520 @ 2.40GHz|| ||stepping : 2|| ||microcode : 0x9|| ||cpu MHz : 1199.000|| ||cache size : 3072 KB||