Re: [Libva] [Libva-intel-driver][PATCH] Code cleanup for vme/mfc initializing on SKL

On 09/07/2016 11:01 AM, Xiang, Haihao wrote: i965_encoder.c is a general file, it would be better not to include more HW/implementation related code in this file. Actually it is more clear if you look into the new gen9_vme_context_init() and gen9_mfc_context_init(). Previous it selects

Re: [Libva] [PATCH V3: 1/4] HEVC10bit ENC: add private surface for p010 conversion to nv12

-Original Message- From: Xiang, Haihao Sent: Tuesday, September 6, 2016 10:00 PM To: Qu, Pengfei ; libva@lists.freedesktop.org Subject: RE: [Libva] [PATCH V3: 1/4] HEVC10bit ENC: add private surface for p010 conversion to nv12 >-Original Message- >From:

Re: [Libva] [PATCH V3: 2/4] HEVC10bit ENC:enable hevc 10bit on VME and PAK

-Original Message- From: Xiang, Haihao Sent: Wednesday, September 7, 2016 10:09 AM To: Zhao, Yakui Cc: Qu, Pengfei ; libva@lists.freedesktop.org Subject: Re: [Libva] [PATCH V3: 2/4] HEVC10bit ENC:enable hevc 10bit on VME and PAK On Wed,

Re: [Libva] [Libva-intel-driver][PATCH 07/18] Remove unused fields and code in H.264/VP8 BRC

On 09/06/2016 11:41 PM, Xiang, Haihao wrote: H.264 and VP8 share some data structures Signed-off-by: Xiang, Haihao --- src/gen6_mfc.h| 6 -- src/gen6_mfc_common.c | 29 +++-- src/gen8_mfc.c| 35

Re: [Libva] [Libva-intel-driver][PATCH 04/18] Check bitrate control related parameters in sequence and misc parameters

On 09/06/2016 11:41 PM, Xiang, Haihao wrote: Currently only used for H.264 encoding Signed-off-by: Xiang, Haihao --- src/i965_encoder.c | 184 +++-- src/i965_encoder.h | 12 2 files changed, 190 insertions(+), 6

Re: [Libva] [Libva-intel-driver][PATCH 03/18] Add some new internal variables for a new sequence

> On 09/06/2016 11:41 PM, Xiang, Haihao wrote: > > Currently these variables are used only for H.264 encoding > > > > Signed-off-by: Xiang, Haihao > > --- > >   src/i965_encoder.c | 7 +++ > >   src/i965_encoder.h | 4 > >   2 files changed, 11 insertions(+) > > >

Re: [Libva] [Libva-intel-driver][PATCH 03/18] Add some new internal variables for a new sequence

On 09/06/2016 11:41 PM, Xiang, Haihao wrote: Currently these variables are used only for H.264 encoding Signed-off-by: Xiang, Haihao --- src/i965_encoder.c | 7 +++ src/i965_encoder.h | 4 2 files changed, 11 insertions(+) diff --git a/src/i965_encoder.c

Re: [Libva] [Libva-intel-driver][PATCH] Code cleanup for vme/mfc initializing on SKL

On 09/06/2016 11:39 PM, Xiang, Haihao wrote: It keeps i965_encoder.c simple Thanks for the patch. But I don't think that this patch is necessary. The code looks more clear if it can select the different initialization callback function earlier based on the corresponding profile/entrypoint .

Re: [Libva] [PATCH RFC intel-driver 00/11] Automated (Unit) Test Suite

Hi Haihao, I am unable to duplicate your segmentation fault. Could you provide more output and details on your setup? Thanks, U. Artie > -Original Message- > From: Xiang, Haihao > Sent: Friday, September 02, 2016 1:40 AM > To: Eoff, Ullysses A ;

[Libva] [Libva-intel-driver][PATCH 18/18] Add support for VAConfigAttribEncRateControlExt attribute

Currently bit rate control per temporal layer is disabled Signed-off-by: Xiang, Haihao --- src/i965_drv_video.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/i965_drv_video.c b/src/i965_drv_video.c index 3be7f6a..664a19a 100644 ---

[Libva] [Libva-intel-driver][PATCH 16/18] Initialize internal related parameters per temporal layer for H.264 BRC

Signed-off-by: Xiang, Haihao --- src/gen6_mfc_common.c | 70 ++- 1 file changed, 42 insertions(+), 28 deletions(-) diff --git a/src/gen6_mfc_common.c b/src/gen6_mfc_common.c index 5c10147..ccf20a2 100644 ---

[Libva] [Libva-intel-driver][PATCH 17/18] Update CBR algo for H.264 per tempolar layer

Signed-off-by: Xiang, Haihao --- src/gen6_mfc.c| 4 +-- src/gen6_mfc_common.c | 76 +-- src/gen6_vme.c| 2 +- src/gen75_mfc.c | 4 +-- src/gen75_vme.c | 4 +-- src/gen7_vme.c| 2 +-

[Libva] [Libva-intel-driver][PATCH 12/18] Use arrays to store bitrate and framerate

Currently only the first element is used Signed-off-by: Xiang, Haihao --- src/gen6_mfc_common.c | 6 +++--- src/i965_encoder.c| 18 +- src/i965_encoder.h| 4 ++-- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git

[Libva] [Libva-intel-driver][PATCH 13/18] Save bitrate and framerate per temporal layer

Signed-off-by: Xiang, Haihao --- src/i965_encoder.c | 79 +- 1 file changed, 48 insertions(+), 31 deletions(-) diff --git a/src/i965_encoder.c b/src/i965_encoder.c index 7bb369a..da62955 100644 --- a/src/i965_encoder.c

[Libva] [Libva-intel-driver][PATCH 10/18] Store buffers for VAEncMiscParameterTypeRateControl and VAEncMiscParameterTypeFrameRate per temporal layer

Signed-off-by: Xiang, Haihao --- src/i965_drv_video.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/src/i965_drv_video.c b/src/i965_drv_video.c index 1ec0453..3be7f6a 100644 --- a/src/i965_drv_video.c +++

[Libva] [Libva-intel-driver][PATCH 14/18] Change the type of the 2nd parameter of intel_mfc_update_hrd()

In addition, change the two caller functions as well. Signed-off-by: Xiang, Haihao --- src/gen6_mfc.c| 2 +- src/gen6_mfc.h| 4 ++-- src/gen6_mfc_common.c | 8 +--- src/gen75_mfc.c | 2 +- src/gen8_mfc.c| 9 + 5 files changed, 14

[Libva] [Libva-intel-driver][PATCH 15/18] Use arrays to store BRC related parameters per temporal layer

Currently only the first element is used Signed-off-by: Xiang, Haihao --- src/gen6_mfc.c| 8 +++ src/gen6_mfc.h| 6 ++--- src/gen6_mfc_common.c | 66 +-- src/gen6_vme.c| 2 +- src/gen75_mfc.c

[Libva] [Libva-intel-driver][PATCH 11/18] Check temporal layer structure

Signed-off-by: Xiang, Haihao --- src/i965_encoder.c | 66 ++ src/i965_encoder.h | 9 2 files changed, 75 insertions(+) diff --git a/src/i965_encoder.c b/src/i965_encoder.c index 2ba5de7..1ba24e6 100644 ---

[Libva] [Libva-intel-driver][PATCH 05/18] Remove unnecessary code in H.264 BRC

Signed-off-by: Xiang, Haihao --- src/gen6_mfc_common.c | 52 ++- 1 file changed, 2 insertions(+), 50 deletions(-) diff --git a/src/gen6_mfc_common.c b/src/gen6_mfc_common.c index abeefa8..13c9494 100644 ---

[Libva] [Libva-intel-driver][PATCH 07/18] Remove unused fields and code in H.264/VP8 BRC

H.264 and VP8 share some data structures Signed-off-by: Xiang, Haihao --- src/gen6_mfc.h| 6 -- src/gen6_mfc_common.c | 29 +++-- src/gen8_mfc.c| 35 +++ 3 files changed, 6 insertions(+), 64

[Libva] [Libva-intel-driver][PATCH 04/18] Check bitrate control related parameters in sequence and misc parameters

Currently only used for H.264 encoding Signed-off-by: Xiang, Haihao --- src/i965_encoder.c | 184 +++-- src/i965_encoder.h | 12 2 files changed, 190 insertions(+), 6 deletions(-) diff --git a/src/i965_encoder.c

[Libva] [Libva-intel-driver][PATCH 08/18] move QpPrimeY to another inner structure for H.264/VP8 BRC

It doesn't cause functionality change Signed-off-by: Xiang, Haihao --- src/gen6_mfc.c| 4 ++-- src/gen6_mfc.h| 2 +- src/gen6_mfc_common.c | 58 +++ src/gen6_vme.c| 2 +- src/gen75_mfc.c |

[Libva] [Libva-intel-driver][PATCH 06/18] Do not use the input parameters directly in H.264 BRC

The corresponding paramters are saved in the context Signed-off-by: Xiang, Haihao --- src/gen6_mfc_common.c | 52 +++ 1 file changed, 19 insertions(+), 33 deletions(-) diff --git a/src/gen6_mfc_common.c

[Libva] [Libva-intel-driver][PATCH 03/18] Add some new internal variables for a new sequence

Currently these variables are used only for H.264 encoding Signed-off-by: Xiang, Haihao --- src/i965_encoder.c | 7 +++ src/i965_encoder.h | 4 2 files changed, 11 insertions(+) diff --git a/src/i965_encoder.c b/src/i965_encoder.c index e7e1554..d045881 100644

[Libva] [Libva-intel-driver][PATCH 09/18] Use a 2-dimensional array to store misc parameters

This patch allows multiple misc parameter buffers for the same type within the same Begin/Render/End sequence in the future. Currently only the first element for each misc type is used, so it doesn't change any functionality yet. Signed-off-by: Xiang, Haihao ---

[Libva] [Libva-intel-driver][PATCH 02/18] Add an internal flag to indicate the start of a new sequence

Signed-off-by: Xiang, Haihao --- src/i965_encoder.c | 10 +- src/i965_encoder.h | 1 + 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/i965_encoder.c b/src/i965_encoder.c index be01e83..e7e1554 100644 --- a/src/i965_encoder.c +++

[Libva] [Libva-intel-driver][PATCH 01/18] intel_mfc_brc_prepare() only works for H.264 or H.264 MVC

Signed-off-by: Xiang, Haihao --- src/gen6_mfc_common.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gen6_mfc_common.c b/src/gen6_mfc_common.c index 9f041d8..abeefa8 100644 --- a/src/gen6_mfc_common.c +++ b/src/gen6_mfc_common.c @@ -422,9

[Libva] [Libva-intel-driver][PATCH] Code cleanup for vme/mfc initializing on SKL

It keeps i965_encoder.c simple Signed-off-by: Xiang, Haihao --- src/gen6_mfc.h | 6 ++ src/gen6_vme.h | 2 +- src/gen9_mfc.c | 25 +++-- src/gen9_vme.c | 15 ++- src/i965_encoder.c | 37

Re: [Libva] [PATCH V3: 2/4] HEVC10bit ENC:enable hevc 10bit on VME and PAK

>-Original Message- >From: Libva [mailto:libva-boun...@lists.freedesktop.org] On Behalf Of >Pengfei Qu >Sent: Tuesday, September 6, 2016 8:09 AM >To: libva@lists.freedesktop.org >Subject: [Libva] [PATCH V3: 2/4] HEVC10bit ENC:enable hevc 10bit on VME and >PAK > >1.add p010->nv12 before

Re: [Libva] [PATCH V3: 1/4] HEVC10bit ENC: add private surface for p010 conversion to nv12

>-Original Message- >From: Libva [mailto:libva-boun...@lists.freedesktop.org] On Behalf Of >Pengfei Qu >Sent: Tuesday, September 6, 2016 8:09 AM >To: libva@lists.freedesktop.org >Subject: [Libva] [PATCH V3: 1/4] HEVC10bit ENC: add private surface for p010 >conversion to nv12 >

[Libva] [PATCH 1/3] Merge and modify encoding bit-rate control per temporal layer.

Cherry-pick'ed from: e6f92ae: Added geneirc support for encoding bit-rate control per temporal layer 753ec17: va.h: add data structure for the structure of temporal layer encoding Signed-off-by: Jonathan Bian Signed-off-by: Austin Yuan

[Libva] [PATCH 2/3] Add the comment for framerate in VAEncMiscParameterFrameRate

To express a frame rate, such as 7.5, we have to use 'numerator / denominator'. The high 2 bytes will be used as denominator and the low 2 bytes will be used as numerator. To keep backward compatible, the low 2 bytes is the real frame rate when the high 2 bytes is 0. Signed-off-by: Xiang,