Re: [Libva] [Libva-intel-driver][PATCH] Needn't reset brc if the bitrate setting isn't changed in the Begin/Render/End sequence

2016-12-28 Thread Zhao Yakui
On 12/29/2016 03:08 PM, Xiang, Haihao wrote: On 12/29/2016 01:22 PM, Xiang, Haihao wrote: User can use VAEncMiscParameterRateControl to update bitrate, so we should ignore the bitrate in the sequence parameter if VAEncMiscParameterRateControl is present. This makes sense. The MiscRateControl

Re: [Libva] [Libva-intel-driver][PATCH] Needn't reset brc if the bitrate setting isn't changed in the Begin/Render/End sequence

2016-12-28 Thread Xiang, Haihao
> On 12/29/2016 01:22 PM, Xiang, Haihao wrote: > > User can use VAEncMiscParameterRateControl to update bitrate, so we > > should ignore > > the bitrate in the sequence parameter if > > VAEncMiscParameterRateControl is present. > > This makes sense. The MiscRateControl mentions that it can overri

Re: [Libva] [Libva-intel-driver][PATCH] Needn't reset brc if the bitrate setting isn't changed in the Begin/Render/End sequence

2016-12-28 Thread Zhao Yakui
On 12/29/2016 01:22 PM, Xiang, Haihao wrote: User can use VAEncMiscParameterRateControl to update bitrate, so we should ignore the bitrate in the sequence parameter if VAEncMiscParameterRateControl is present. This makes sense. The MiscRateControl mentions that it can override the bps settin

[Libva] [Libva-intel-driver][PATCH] Needn't reset brc if the bitrate setting isn't changed in the Begin/Render/End sequence

2016-12-28 Thread Xiang, Haihao
User can use VAEncMiscParameterRateControl to update bitrate, so we should ignore the bitrate in the sequence parameter if VAEncMiscParameterRateControl is present. Hence it is not needed to reset brc if VAEncMiscParameterRateControl doesn't change the used bitrate. Signed-off-by: Xiang, Haihao

Re: [Libva] [PATCH] Add new sequence flag check for HEVC/VP9 Encoding

2016-12-28 Thread Xiang, Haihao
LGTM and applied. Thanks Haihao > Signed-off-by: Zhao Yakui > --- >  src/i965_encoder.c | 16 >  1 file changed, 16 insertions(+) > > diff --git a/src/i965_encoder.c b/src/i965_encoder.c > index be37b84..3099175 100644 > --- a/src/i965_encoder.c > +++ b/src/i965_encoder.c > @@