Re: [Libva] [PATCH] VP8 HWEnc: Fix vp8 mv incorrectly stored issue

2015-05-03 Thread lizhong
Sorry, I forgot to add 'Libva' in the patch subject. Please ignore this patch, I've sent it again. On 05/04/2015 01:09 PM, Zhong Li wrote: As vp8 spec, all luma motion vectors are doubled stored. This patch has much benefit to P frame qualtity. Signed-off-by: Zhong Li --- src/gen8_mfc.c | 7

Re: [Libva] [PATCH] VP8 HWEnc: Add CBR Support

2015-04-22 Thread lizhong
On 04/23/2015 11:19 AM, Xiang, Haihao wrote: On Wed, 2015-04-22 at 15:47 +0800, Zhong Li wrote: Signed-off-by: Zhong Li --- src/gen6_mfc.h | 19 +++ src/gen6_mfc_common.c| 19 --- src/gen8_mfc.c | 382 ++- src/i965_drv_

Re: [Libva] [PATCH V4 2/7] HEVC ENC:Added slice header generated internally

2015-01-07 Thread lizhong
On 01/08/2015 09:34 AM, Xiang, Haihao wrote: On Thu, 2015-01-08 at 09:24 +0800, Zhao, Yakui wrote: On Wed, 2015-01-07 at 18:24 -0700, Xiang, Haihao wrote: On Thu, 2015-01-08 at 09:01 +0800, Zhao, Yakui wrote: On Wed, 2015-01-07 at 01:44 -0700, Qu,Pengfei wrote: Signed-off-by: Qu,Pengfei ---

Re: [Libva] [PATCH 1/2] Move gen6 phantom slice function as common

2014-08-26 Thread lizhong
Hi Gwenole: Thanks for your review. I'll update following your suggestion. BRS Zhong On 08/27/2014 11:53 AM, Gwenole Beauchesne wrote: Hi, 2014-08-08 5:50 GMT+02:00 Zhong Li : Following haihao's suggestion, make gen6 phantom slice funcion can be re-used by SNB+. Signed-off-by: Zhong Li -

Re: [Libva] [PATCH] Add phantom slice support on IVB+

2014-08-06 Thread lizhong
On 08/07/2014 01:17 PM, Xiang, Haihao wrote: HW requires driver to add a phantom slice when FirstMbX and FirstMbY are not 0, in order to avc decoding error concealment. Otherwise, GPU may hang. This patch is a workround for bug: https://bugs.freedesktop.org/show_bug.cgi?id=81447 Signed-off-by:

Re: [Libva] [PATCH 0/7] AVC encoding quality configuration implementation update

2014-08-04 Thread lizhong
Any other comments for this patch? I am going to update it following yakui's suggestion. On 07/24/2014 05:47 PM, Zhong Li wrote: 1. Refine gen7 implementation: use the same shader to implement it. 2. Add SNB/HSW/BDW platforms support. Zhong Li (7): Revert "Add old version vme shaders" Use

Re: [Libva] [PATCH 5/7] Enabling HSW avc encoding configuration

2014-07-28 Thread lizhong
On 07/29/2014 08:54 AM, Zhao, Yakui wrote: On Mon, 2014-07-28 at 01:02 -0600, Li, Zhong wrote: On 07/28/2014 02:32 PM, Zhao, Yakui wrote: On Thu, 2014-07-24 at 03:47 -0600, Zhong Li wrote: Signed-off-by: Zhong Li --- src/gen75_vme.c | 22 ++ src/shader

Re: [Libva] [PATCH 5/7] Enabling HSW avc encoding configuration

2014-07-28 Thread lizhong
On 07/28/2014 02:32 PM, Zhao, Yakui wrote: On Thu, 2014-07-24 at 03:47 -0600, Zhong Li wrote: Signed-off-by: Zhong Li --- src/gen75_vme.c | 22 ++ src/shaders/vme/inter_frame_haswell.asm | 69 +++--- src/shaders/vme/inter_frame_

Re: [Libva] [PATCH 4/7] Enabling SNB avc encoding configuration

2014-07-27 Thread lizhong
On 07/28/2014 02:17 PM, Zhao, Yakui wrote: On Thu, 2014-07-24 at 03:47 -0600, Zhong Li wrote: Signed-off-by: Zhong Li --- src/gen6_vme.c | 50 ++- src/shaders/vme/inter_frame.asm | 25 ++-- src/shaders/vme/inter_frame

Re: [Libva] [PATCH 2/7] Use the same shader to configure quality level

2014-07-27 Thread lizhong
On 07/28/2014 02:15 PM, Zhao, Yakui wrote: On Thu, 2014-07-24 at 03:47 -0600, Zhong Li wrote: Using the same shader to configure gen7 avc quality level, it is benefit to make code clear and reduce profile limitation. It seems that two things are mixed in one patch. a. use the same shader t

Re: [Libva] [Patch intel-driver 2/3] decoder: Remove the dependency on H.264 picture parameter

2014-06-27 Thread lizhong
On 06/27/2014 03:03 PM, Xiang, Haihao wrote: From: "Xiang, Haihao" Only POC is needed in the algorithm Signed-off-by: Xiang, Haihao --- src/i965_decoder_utils.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/src/i965_decoder_utils.c b/src/i965

Re: [Libva] [PATCH V3 2/2] Add multi quality levels encoding support for GEN7

2014-06-10 Thread lizhong
Thanks. Zhong On 06/11/2014 01:30 PM, Zhao, Yakui wrote: On Tue, 2014-06-10 at 20:49 -0600, Zhong Li wrote: Two encoding quality levels are support on GEN7. Default quality level is set to be 1, which has better quality, but higher gpu usage and worse performance. The second quality level is se

Re: [Libva] [PATCH V2 2/2] Add multi quality levels encoding support for GEN7

2014-06-05 Thread lizhong
On 06/05/2014 11:23 PM, Xiang, Haihao wrote: -Original Message- From: Libva [mailto:libva-boun...@lists.freedesktop.org] On Behalf Of Zhong Li Sent: Thursday, June 05, 2014 3:08 PM To: libva@lists.freedesktop.org Subject: [Libva] [PATCH V2 2/2] Add multi quality levels encoding support

Re: [Libva] [PATCH 3/3] Keep binding table index consistent for gen7

2014-06-04 Thread lizhong
On 06/05/2014 01:28 PM, Xiang, Haihao wrote: On Thu, 2014-06-05 at 13:11 +0800, lizhong wrote: On 06/05/2014 12:14 PM, Xiang, Haihao wrote: It would be better to merge 1/3 and 3/3 into a single patch. [Zhong] I separated them because I want to show sharders of patch 1/3 totally come from

Re: [Libva] [PATCH 2/3] Add multi quality levels encoding support for GEN7

2014-06-04 Thread lizhong
On 06/05/2014 01:14 PM, Xiang, Haihao wrote: On Thu, 2014-06-05 at 12:54 +0800, lizhong wrote: On 06/05/2014 12:12 PM, Xiang, Haihao wrote: On Wed, 2014-06-04 at 21:37 +0800, Zhong Li wrote: Two encoding quality levels are support on GEN7. Default quality level is set to be 1, which has

Re: [Libva] [PATCH 3/3] Keep binding table index consistent for gen7

2014-06-04 Thread lizhong
On 06/05/2014 12:14 PM, Xiang, Haihao wrote: It would be better to merge 1/3 and 3/3 into a single patch. [Zhong] I separated them because I want to show sharders of patch 1/3 totally come from driver v1.0.20. And patch 3/3 is a bug fixing when I implement quality level configuration, it depen

Re: [Libva] [PATCH 2/3] Add multi quality levels encoding support for GEN7

2014-06-04 Thread lizhong
On 06/05/2014 12:12 PM, Xiang, Haihao wrote: On Wed, 2014-06-04 at 21:37 +0800, Zhong Li wrote: Two encoding quality levels are support on GEN7. Default quality level is set to be 1, which has better quality, but higher gpu usage and worse performance. The second quality level is set to be 2, w

Re: [Libva] [PATCH 2/3] Convert encoding misc param type to index

2014-05-14 Thread lizhong
On 05/14/2014 04:55 PM, Gwenole Beauchesne wrote: Hi, This is close. When I meant "do the conversion once while parsing/accumulating", this is so that to further optimize the translation/usage process. In this patch, you still have to perform conversions afterwards, this is suboptimal. Here is

Re: [Libva] [PATCH 3/3] Expose h264 encoder motion vector buffer on IVB

2014-05-13 Thread lizhong
No, function gen6_mfc_get_motion_vector() always be called, but if FEI misc param isn't set or mv buffer isn't created, it will do nothing. BTW, I find a error in this patch: dri_bo_unmap(vme_context->vme_output.bo) should be in if{}. I will update this patch. Thanks Zhong On 05/14/2014 08

Re: [Libva] [PATCH 1/3] Add VAEntrypointEncFEIIntel support

2014-05-13 Thread lizhong
I just add entrypoint VAEntrypointEncFEIIntel support. The whole encoding pipeline is the same as VAEntrypointEncSlice for all platforms right now. So I think no need to add restrictions now. We can add some restrictions when VAEntrypointEncFEIIntel pipeline is different with VAEntrypointEncSli

Re: [Libva] [PATCH] Expose gen6 avc endcoer mv buffer

2014-05-11 Thread lizhong
Thanks for your comments. I noted this disadvantage, I will reduce misc_param buffer size On 05/09/2014 06:15 PM, Gwenole Beauchesne wrote: 2014-05-08 8:56 GMT+02:00 Zhong Li : Support VAEntrypointEncFEIIntel and get motion vectors of gen6 h264 encoding Signed-off-by: Zhong Li --- src/gen6_

Re: [Libva] [PATCH][Libva-intel-driver] i965_DeriveImage() support JPEG color formats

2014-04-15 Thread lizhong
Yes, IMC3 is required for JPEG decoding driver. I added IMC3 to follow decoding driver. On 04/16/2014 08:48 AM, Xiang, Haihao wrote: On Tue, 2014-04-15 at 07:27 -0700, Gwenole Beauchesne wrote: Hi, 2014-04-14 1:17 GMT-07:00 Zhong Li : Signed-off-by: Zhong Li --- src/i965_drv_video.c |

Re: [Libva] [PATCH][Libva-intel-driver] i965_DeriveImage() support JPEG color formats

2014-04-14 Thread lizhong
Thanks for your comment. I will add it... Thanks Zhong On 04/15/2014 09:32 AM, Zhao Yakui wrote: On Mon, 2014-04-14 at 02:17 -0600, Zhong Li wrote: Signed-off-by: Zhong Li The Imageformat for JPEG should also be added. Thanks. Yakui --- src/i965_drv_video.c |6 ++ 1 file