Re: [Libva] [PATCH 1/4] i965_encoder: consistently represent framerate as a fraction

2016-12-27 Thread Kelley, Sean V
On 12/22/16, 5:08 PM, "Libva on behalf of Mark Thompson" wrote: Update references in both H.264 encoders (gen6_mfc and gen9_vdenc). Lgtm, Sean Signed-off-by: Mark Thompson --- Changes for the series: * Derive numerator and denominator from the correct parts of the

Re: [Libva] [PATCH 1/4] i965_encoder: consistently represent framerate as a fraction

2016-12-23 Thread Xiang, Haihao
: [Libva] [PATCH 1/4] i965_encoder: consistently represent framerate >as a fraction > >Update references in both H.264 encoders (gen6_mfc and gen9_vdenc). > >Signed-off-by: Mark Thompson >--- >Changes for the series: >* Derive numerator and denominator from the correct p

[Libva] [PATCH 1/4] i965_encoder: consistently represent framerate as a fraction

2016-12-22 Thread Mark Thompson
Update references in both H.264 encoders (gen6_mfc and gen9_vdenc). Signed-off-by: Mark Thompson --- Changes for the series: * Derive numerator and denominator from the correct parts of the framerate parameter (see also earlier patch fixing the comment in va.h). * Make VP8 HRD buffer size deriva

Re: [Libva] [PATCH 1/4] i965_encoder: consistently represent framerate as a fraction

2016-12-21 Thread Xiang, Haihao
> On 21/12/16 04:21, Xiang, Haihao wrote: > > > > > Update references in both H.264 encoders (gen6_mfc and > > > gen9_vdenc). > > > > > > Signed-off-by: Mark Thompson > > > --- > > > New version. > > > > > > Changes for the whole series: > > > * Use a single field for framerate (adding a new s

Re: [Libva] [PATCH 1/4] i965_encoder: consistently represent framerate as a fraction

2016-12-21 Thread Mark Thompson
On 21/12/16 04:21, Xiang, Haihao wrote: > >> Update references in both H.264 encoders (gen6_mfc and gen9_vdenc). >> >> Signed-off-by: Mark Thompson >> --- >> New version. >> >> Changes for the whole series: >> * Use a single field for framerate (adding a new struct to represent >> it), as recomme

Re: [Libva] [PATCH 1/4] i965_encoder: consistently represent framerate as a fraction

2016-12-20 Thread Xiang, Haihao
> Update references in both H.264 encoders (gen6_mfc and gen9_vdenc). > > Signed-off-by: Mark Thompson > --- > New version. > > Changes for the whole series: > * Use a single field for framerate (adding a new struct to represent > it), as recommended by Haihao. > * Fix some missed cases where b

[Libva] [PATCH 1/4] i965_encoder: consistently represent framerate as a fraction

2016-12-19 Thread Mark Thompson
Update references in both H.264 encoders (gen6_mfc and gen9_vdenc). Signed-off-by: Mark Thompson --- New version. Changes for the whole series: * Use a single field for framerate (adding a new struct to represent it), as recommended by Haihao. * Fix some missed cases where bitrate was read from

Re: [Libva] [PATCH 1/4] i965_encoder: consistently represent framerate as a fraction

2016-12-15 Thread Xiang, Haihao
> On 15/12/16 08:54, Xiang, Haihao wrote: > > > > Hi Mark, > > > > Thanks for your patch, is there any benefit to use a fraction? > > using > > 100 as framerate_den works well in the driver. > > Everything the driver interacts with directly, on both sides, uses a > fraction: > > * In VAAPI, VA

Re: [Libva] [PATCH 1/4] i965_encoder: consistently represent framerate as a fraction

2016-12-15 Thread Sean V Kelley
I'm fine with this change and it adds consistency. lgtm Thanks, Sean On Thu, Dec 15, 2016 at 4:26 AM, Mark Thompson wrote: > On 15/12/16 08:54, Xiang, Haihao wrote: > > > > Hi Mark, > > > > Thanks for your patch, is there any benefit to use a fraction? using > > 100 as framerate_den works wel

Re: [Libva] [PATCH 1/4] i965_encoder: consistently represent framerate as a fraction

2016-12-15 Thread Mark Thompson
On 15/12/16 08:54, Xiang, Haihao wrote: > > Hi Mark, > > Thanks for your patch, is there any benefit to use a fraction? using > 100 as framerate_den works well in the driver. Everything the driver interacts with directly, on both sides, uses a fraction: * In VAAPI, VAEncMiscParameterFrameRate c

Re: [Libva] [PATCH 1/4] i965_encoder: consistently represent framerate as a fraction

2016-12-15 Thread Xiang, Haihao
Hi Mark, Thanks for your patch, is there any benefit to use a fraction? using 100 as framerate_den works well in the driver. Regards Haihao > Update references in both H.264 encoders (gen6_mfc and gen9_vdenc). > > Signed-off-by: Mark Thompson > --- >  src/gen6_mfc_common.c | 11 ++ >

[Libva] [PATCH 1/4] i965_encoder: consistently represent framerate as a fraction

2016-12-08 Thread Mark Thompson
Update references in both H.264 encoders (gen6_mfc and gen9_vdenc). Signed-off-by: Mark Thompson --- src/gen6_mfc_common.c | 11 ++ src/gen9_vdenc.c | 29 ++-- src/gen9_vdenc.h | 3 ++- src/i965_encoder.c| 61 +---