Re: [Libvir] Autostarting guests and networks

On 2/17/07, Daniel P. Berrange <[EMAIL PROTECTED]> wrote: On Fri, Feb 16, 2007 at 02:51:07PM +, Mark McLoughlin wrote: > Hey, > We need some way to have libvirtd automatically start guests and > networks. > > We had said we should have autostart directories containing config > fi

Re: [Libvir] [patch 9/9] Implement better error reporting

On Fri, Feb 16, 2007 at 02:44:57PM +, Mark McLoughlin wrote: > Add a qemudLog() function which uses syslog() if we're in > daemon mode, doesn't output INFO/DEBUG messages unless > the verbose flag is set and doesn't output DEBUG messages > unless compiled with --enable-debug. The QEMU daemon c

Re: [Libvir] [patch 8/9] Implement better signal handling

On Fri, Feb 16, 2007 at 02:44:46PM +, Mark McLoughlin wrote: > Handle SIGHUP by shutting down all guests and networks > and re-loading configs This violates the 'principle of least surprise'. I certainly do not expect a config file reload to terminate all active guests. Since QEMU is a full vi

Re: [Libvir] [patch 0/9] More miscellaneous qemud patches

On Fri, Feb 16, 2007 at 02:43:42PM +, Mark McLoughlin wrote: > Hey, > Okay, here's another batch of qemud patches I've > committed. Usual practice is to post patches for review *before* committing them, unless they're trivial bug fixes. I don't recall us ever deciding to change that p

Re: [Libvir] Autostarting guests and networks

On Fri, Feb 16, 2007 at 02:51:07PM +, Mark McLoughlin wrote: > Hey, > We need some way to have libvirtd automatically start guests and > networks. > > We had said we should have autostart directories containing config > files of guests/networks which should be autostarted. One prob

[Fwd: Re: [Libvir] Autostarting guests and networks]

Oops, meant to send this to the list... --H -- Red Hat Virtualization Group http://redhat.com/virtualization Hugh Brock | virt-manager http://virt-manager.org [EMAIL PROTECTED]| virtualization library http://libvirt.org --- Begin Message --- Mark McLoughlin wrote: Hey, We n

Re: [Libvir] [patch 7/9] Fix our FD_CLOEXEC usage

Mark McLoughlin <[EMAIL PROTECTED]> wrote: > Implement a sane policy around our use of FD_CLOEXEC: > > 1) Every descriptor which shouldn't be passed to > child processes should have the flag set > > 2) Let exec() do the descriptor closing, rather > than us doing it ourselves ... > -

Re: [Libvir] [patch 3/9] Dont share virConnect->handle between xen and qemu

On Fri, 2007-02-16 at 13:29 +, Richard W.M. Jones wrote: > I don't really understand this patch. Surely if you want to connect to > the Xen h/v and qemud you'd use two separate connections? I think it's better if each driver keeps its data separate from the others ... so we should p

Re: [Libvir] [patch 8/9] Implement better signal handling

Mark McLoughlin <[EMAIL PROTECTED]> wrote: > Index: libvirt/qemud/qemud.c ... > +write(sigwrite, &sigc, 1); ... > +close(sigwrite); Hi Mark, Diagnosing potential write and close failures might well save someone some time debugging. Jim -- Libvir-list mailing list Libvir-list@redhat.com

[Libvir] Autostarting guests and networks

Hey, We need some way to have libvirtd automatically start guests and networks. We had said we should have autostart directories containing config files of guests/networks which should be autostarted. One problem I see with that is that we'd need a new API to define autostart confi

[Libvir] [patch 9/9] Implement better error reporting

Add a qemudLog() function which uses syslog() if we're in daemon mode, doesn't output INFO/DEBUG messages unless the verbose flag is set and doesn't output DEBUG messages unless compiled with --enable-debug. Also, make a first pass through fatal errors and add error messages for them. Signed-off-

[Libvir] [patch 8/9] Implement better signal handling

Handle SIGHUP by shutting down all guests and networks and re-loading configs Handle SIGTERM/SIGINT by cleanly shutting down Signed-off-by: Mark McLoughlin <[EMAIL PROTECTED]> Index: libvirt/qemud/internal.h === --- libvirt.orig/qem

[Libvir] [patch 7/9] Fix our FD_CLOEXEC usage

Implement a sane policy around our use of FD_CLOEXEC: 1) Every descriptor which shouldn't be passed to child processes should have the flag set 2) Let exec() do the descriptor closing, rather than us doing it ourselves Signed-off-by: Mark McLoughlin <[EMAIL PROTECTED]> Index: libv

[Libvir] [patch 6/9] Fix qemudEnableIpForwarding()

Don't leak an fd if we fail to write to /proc/sys/net/ipv4/ip_forward Also, fix indentation Signed-off-by: Mark McLoughlin <[EMAIL PROTECTED]> Index: libvirt/qemud/qemud.c === --- libvirt.orig/qemud/qemud.c +++ libvirt/qemud/qemud.c

[Libvir] [patch 5/9] Fix network iface XML output

We weren't handling the network interface type correctly and also outputting incorrect XML Signed-off-by: Mark McLoughlin <[EMAIL PROTECTED]> Index: libvirt/qemud/conf.c === --- libvirt.orig/qemud/conf.c +++ libvirt/qemud/conf.c @@ -

[Libvir] [patch 4/9] Output SDL graphics XML

It seems we were forgetting to handle QEMUD_GRAPHICS_SDL in qemudGenerateXML() Signed-off-by: Mark McLoughlin <[EMAIL PROTECTED]> Index: libvirt/qemud/conf.c === --- libvirt.orig/qemud/conf.c +++ libvirt/qemud/conf.c @@ -1907,13 +190

[Libvir] [patch 3/9] Fix a couple of typos

A couple of typos: 1) confusion around the isGuest arg to ScanConfigDir() 2) forgetting a quot in network interface xml output Signed-off-by: Mark McLoughlin <[EMAIL PROTECTED]> Index: libvirt/qemud/conf.c === --- libvirt.orig/

[Libvir] [patch 2/9] Fix segv with networks re-defining patch

Silly typo causing a segv Signed-off-by: Mark McLoughlin <[EMAIL PROTECTED]> Index: libvirt/qemud/conf.c === --- libvirt.orig/qemud/conf.c +++ libvirt/qemud/conf.c @@ -1558,6 +1558,7 @@ struct qemud_network *qemudLoadNetworkCo

[Libvir] [patch 1/9] Minor nitpick

Just move qemudFreeVMDef() alonside qemudFreeVM() Signed-off-by: Mark McLoughlin <[EMAIL PROTECTED]> Index: libvirt/qemud/conf.h === --- libvirt.orig/qemud/conf.h +++ libvirt/qemud/conf.h @@ -30,12 +30,12 @@ int qemudBuildCommandLine

[Libvir] [patch 0/9] More miscellaneous qemud patches

Hey, Okay, here's another batch of qemud patches I've committed. The most significant ones are the signal handling and error reporting ones at the end. Appreciate someone looking over them. Thanks, Mark. -- -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.c

Re: [Libvir] [PATCH] Add Require gnutls-devel for SRPM build

On Fri, Feb 16, 2007 at 01:13:30PM +, Daniel P. Berrange wrote: > On Fri, Feb 16, 2007 at 01:57:04PM +0900, Atsushi SAKAI wrote: > > Hi, > > > > This patch adds a Require gnutls-devel for "libvirt.spec" file. > > Hmm, I certainly meant to strip out all code which referenced the > gnutls libr

Re: [Libvir] [PATCH] Remove init from virDriver structure.

Looks good & since we've previously agreed this was a good fix I'll apply it now. Dan. On Fri, Feb 16, 2007 at 02:58:19PM +, Richard W.M. Jones wrote: > From 8f04c42e183fc0e339fdef993ec10833a056e791 Mon Sep 17 00:00:00 2001 > From: Richard Jones <[EMAIL PROTECTED]> > Date: Fri, 16 Feb 2007 14

[Libvir] [PATCH] Remove init from virDriver structure.

-- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis M

Re: [Libvir] [patch 3/9] Dont share virConnect->handle between xen and qemu

[EMAIL PROTECTED] wrote: Don't share virConnect->handle with the xen hypervisor socket so that we can have a qemud connection open at the same time as a xen hypervisor connection. Signed-off-by: Mark McLoughlin <[EMAIL PROTECTED]> Index: libvirt-foo/src/internal.h ==

Re: [Libvir] [PATCH] to run on IA64

On Fri, Feb 16, 2007 at 07:24:19PM +0900, Atsushi SAKAI wrote: > Hi, > > This patch intends to run libvirt 0.2.0 on IA64. > > Signed-off-by: Atsushi SAKAI <[EMAIL PROTECTED]> This patch looks fine to me - I assume its just about silencing warnings from ever stricter GCC compiles. > Just one que

Re: [Libvir] [PATCH] Add Require gnutls-devel for SRPM build

On Fri, Feb 16, 2007 at 01:57:04PM +0900, Atsushi SAKAI wrote: > Hi, > > This patch adds a Require gnutls-devel for "libvirt.spec" file. Hmm, I certainly meant to strip out all code which referenced the gnutls libraries, since we were not intending to use it in this release. I'll check see what

[Libvir] [PATCH] to run on IA64

Hi, This patch intends to run libvirt 0.2.0 on IA64. Signed-off-by: Atsushi SAKAI <[EMAIL PROTECTED]> Just one question, is there any plan to support big/little endian for libvirt? (related to network) Thanks Atsushi SAKAI ia64-work.patch Description: Binary data -- Libvir-list mailing list