[Libvir] [PATCH] check the maximum of virtual CPU

2007-02-28 Thread Masayuki Sunou
Hi The maximum of virtual CPU is not guarded in virsh setvcpus now. Then, when 32767 was set to virtual CPU of virsh setvcpus, the problem that Xend became abnormal was detected. example: -- # virsh setvcpus 0 32767 libvir: X

Re: [Libvir] Request for libvirt/ChangeLog

2007-02-28 Thread Atsushi SAKAI
Hi, Dan Thank you for showing your policy. I am consider local counting rule based on your policy. Anyway I usually see it with "cvs log libvirt/ChangeLog" not bare "vi libvirt/ChangeLog". It shows commiters name.:-) Thanks Atsushi SAKAI "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > On We

[Libvir] [PATCH] export virConf* symbols (second version)

2007-02-28 Thread Richard W.M. Jones
Second version of that patch. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessi

Re: [Libvir] Patch: include for setlocale

2007-02-28 Thread Richard W.M. Jones
Daniel P. Berrange wrote: Incidentally this reminds me that the handling of CFLAGS in configure.ac is fubar - we're hardcoding the compiler flags including optimization level. So in the RPM builds we're forcing it to -O instead of honouring the $RPM_BUILD_OPTS which would normally turned on -O2,

Re: [Libvir] Patch: include for setlocale

2007-02-28 Thread Daniel P. Berrange
On Wed, Feb 28, 2007 at 04:14:30PM +, Richard W.M. Jones wrote: > Very trivial, but useful for me because I'm trying to debug the remote > stuff without -O, and without -O it turns out that libvirt doesn't compile. Wow, very wierd - it appears that there is some GLibC magic at work here. If y

Re: [Libvir] Patch: export virConf* symbols

2007-02-28 Thread Richard W.M. Jones
Daniel P. Berrange wrote: On Wed, Feb 28, 2007 at 04:29:14PM +, Richard W.M. Jones wrote: The standalone parts of libvirt (particularly libvirtd) use the configuration mini-lib. We can change these to be exported with a leading underscore, and add macros in the private src/conf.h like

Re: [Libvir] Patch: export virConf* symbols

2007-02-28 Thread Daniel P. Berrange
On Wed, Feb 28, 2007 at 04:29:14PM +, Richard W.M. Jones wrote: > > The standalone parts of libvirt (particularly libvirtd) use the > configuration mini-lib. We can change these to be exported with a leading underscore, and add macros in the private src/conf.h like #define virConfGetValu

Re: [Libvir] Patch: Driver private data

2007-02-28 Thread Daniel P. Berrange
On Wed, Feb 28, 2007 at 04:27:05PM +, Richard W.M. Jones wrote: > This patch is more aspirational than currently useful. Only the remote > patch would use driver->private, but I think others should be changed to > do so too. Certainly - I'll update the QEMU & Test drivers at least once we'v

Re: [Libvir] Patch: driver->open functions return declined or error status

2007-02-28 Thread Daniel P. Berrange
On Wed, Feb 28, 2007 at 04:18:45PM +, Richard W.M. Jones wrote: > > I want to change the driver->open function so that as well as declining > a name (returning -1 as now), it may also indicate that it accepts the > name, but there is an error opening the name (-2). virConnectOpen fails > i

Re: [Libvir] Patch: Define SYSCONFDIR symbol

2007-02-28 Thread Richard W.M. Jones
Daniel P. Berrange wrote: This SYSCONFDIR macro isn't actually used anywhere in the current code yet is it ? ie, its just incremental support for the daemon, rather than fixing an existing bug ? That is true, yes. Put this patch in the "aspirational" category :-) Rich. -- Emerging Technolog

Re: [Libvir] Patch: Define SYSCONFDIR symbol

2007-02-28 Thread Daniel P. Berrange
This SYSCONFDIR macro isn't actually used anywhere in the current code yet is it ? ie, its just incremental support for the daemon, rather than fixing an existing bug ? Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search

[Libvir] Patch: tabstops

2007-02-28 Thread Richard W.M. Jones
I've been slowly adding the Emacs & vi tabstop code to the end of files. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of t

[Libvir] Patch: export virConf* symbols

2007-02-28 Thread Richard W.M. Jones
The standalone parts of libvirt (particularly libvirtd) use the configuration mini-lib. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations a

Re: [Libvir] VCPU mapping into the XML

2007-02-28 Thread Hugh Brock
ASANO Yuzuru wrote: Hugh Brock wrote: Daniel P. Berrange wrote: Libvirt is really just the lowest level is what I see as a stack of tools for managing virtual machines. Above libvirt I'd expect to see some form of 'policy manager' which defines/controls things such as VCPU mapping, or schedular

[Libvir] Patch: Driver private data

2007-02-28 Thread Richard W.M. Jones
This patch is more aspirational than currently useful. Only the remote patch would use driver->private, but I think others should be changed to do so too. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Ne

[Libvir] Patch: Fix documentation and code of virGetDomain function

2007-02-28 Thread Richard W.M. Jones
It turns out that you _can't_ pass name=NULL to virGetDomain, despite what the docs say. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations

[Libvir] Patch: Define SYSCONFDIR symbol

2007-02-28 Thread Richard W.M. Jones
-- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Mas

[Libvir] Patch: driver->open functions return declined or error status

2007-02-28 Thread Richard W.M. Jones
I want to change the driver->open function so that as well as declining a name (returning -1 as now), it may also indicate that it accepts the name, but there is an error opening the name (-2). virConnectOpen fails in this second case, rather than going on and trying the next driver in seque

[Libvir] Patch: include for setlocale

2007-02-28 Thread Richard W.M. Jones
Very trivial, but useful for me because I'm trying to debug the remote stuff without -O, and without -O it turns out that libvirt doesn't compile. Rich. --- Index: proxy/libvirt_proxy.c === RCS f

Re: [Libvir] Request for libvirt/ChangeLog

2007-02-28 Thread Daniel P. Berrange
On Wed, Feb 28, 2007 at 07:41:00PM +0900, Atsushi SAKAI wrote: > Hi, Karel > > Thank you for your suggestion. > > I need to count our company contribution based on # of patches > to report our managers. > This patch counting method is available > for virtinst/virtmanager/Xen but not for libvir

Re: [Libvir] Request for libvirt/ChangeLog

2007-02-28 Thread Atsushi SAKAI
Hi, Karel Thank you for your suggestion. I need to count our company contribution based on # of patches to report our managers. This patch counting method is available for virtinst/virtmanager/Xen but not for libvirt. Thanks Atsushi SAKAI Karel Zak <[EMAIL PROTECTED]> wrote: > On Wed, Feb 2

Re: [Libvir] Request for libvirt/ChangeLog

2007-02-28 Thread Karel Zak
On Wed, Feb 28, 2007 at 10:22:12AM +0900, Atsushi SAKAI wrote: > Please add the submitter Mail address to libvirt/ChangeLog > for ease of contribution counting. Please, include ChangeLog entry always to your patches. I think it's the best way. BTW, your name and e-mail is already in AUTHORS

Re: [Libvir] VCPU mapping into the XML

2007-02-28 Thread Karel Zak
On Tue, Feb 27, 2007 at 02:04:22PM +, Daniel P. Berrange wrote: > On Tue, Feb 27, 2007 at 06:40:54PM +0900, ASANO Yuzuru wrote: > > Hello, > > > > I want to add the info of VCPU mapping into the XML, > > because we cannot manage VCPU mapping automatically > > when a domain starts or reboots. >

RE: [Libvir] VCPU mapping into the XML

2007-02-28 Thread ASANO Yuzuru
Hugh Brock wrote: > Daniel P. Berrange wrote: > > > >Libvirt is really just the lowest level is what I see as a stack of tools > >for managing virtual machines. Above libvirt I'd expect to see some form > >of 'policy manager' which defines/controls things such as VCPU mapping, > >or schedular param

Re: [Libvir] [PATCH]Report the error from xend for Domain-0

2007-02-28 Thread Richard W.M. Jones
Daniel P. Berrange wrote: On Tue, Feb 27, 2007 at 07:34:01PM +0900, Kazuki?$B!!Mizushima wrote: When I test virsh subcommands, dump save, for Domain-0, It says following normal messages, but the processing is not done. -} else if ((ret = 202) && (strstr(content, "failed") != NULL)) { +}