Masayuki Sunou wrote:
Hi
The maximum of virtual CPU is not guarded in virsh setvcpus now.
Then, when 32767 was set to virtual CPU of virsh setvcpus, the problem
that Xend became abnormal was detected.
example:
--
# virsh
Hi Rich,
On Wed, 2007-02-28 at 17:33 +, Richard W.M. Jones wrote:
+#define virConfNew() (_virConfNew())
I wouldn't bother doing this, it just adds confusion - e.g. it helps to
know that the symbol is private from the calling site too, so just use
_virConfNew() everywhere ...
On Wed, 2007-02-28 at 17:06 +, Daniel P. Berrange wrote:
On Wed, Feb 28, 2007 at 04:27:05PM +, Richard W.M. Jones wrote:
This patch is more aspirational than currently useful. Only the remote
patch would use driver-private, but I think others should be changed to
do so too.
Hi, Rich
The patch looks pretty sensible to me. Needs the same check added to
virt-manager too?
Virt-manager seems to check maximums of the number of CPU.
However, virt-manager checks the number of CPU by fixed value (32).
Therefore, I think that the check of architecture is needed in
On Tue, 2007-02-20 at 23:32 -0500, Daniel Veillard wrote:
On Mon, Feb 19, 2007 at 02:46:43PM +, Mark McLoughlin wrote:
Unfortunately I don't see a good thing to do in
this case except to change the semantics of virConnectGetType, which
arguably breaks ABI compatibility.
Hey,
Btw, I'm really becoming quite convinced we'll evenutally regret using
SunRPC if we stick with it.
On Wed, 2007-02-28 at 21:03 +, Richard W.M. Jones wrote
+AC_PATH_PROG(LOGGER, logger)
+AC_DEFINE_UNQUOTED(LOGGER, $LOGGER,
+ [Define the location of the external
Mark McLoughlin wrote:
Hey,
Btw, I'm really becoming quite convinced we'll evenutally regret using
SunRPC if we stick with it.
Morning Mark, thanks for taking the time to look at the patch in detail.
Do you have some actual concrete problems with SunRPC? For me it solves
the problem
Mark McLoughlin wrote:
On Wed, 2007-02-28 at 16:18 +, Richard W.M. Jones wrote:
+ case VIR_DRV_OPEN_ERROR: goto failed;
+ case VIR_DRV_OPEN_DECLINED:
+ /*
+* For a default connect to Xen make sure we manage to contact
+*
Mark McLoughlin wrote:
Hi Rich,
On Wed, 2007-02-28 at 17:33 +, Richard W.M. Jones wrote:
+#define virConfNew() (_virConfNew())
I wouldn't bother doing this, it just adds confusion - e.g. it helps to
know that the symbol is private from the calling site too, so just use
I'm seeing the warnings below when compiling on Fedora Rawhide.
src/Makefile.am:84: `%'-style pattern rules are a GNU make extension
tests/Makefile.am:11: wildcard $(top_builddir: non-POSIX variable name
tests/Makefile.am:11: (probably a GNU make extension)
tests/confdata/Makefile.am:2: wildcard
On Thu, 2007-03-01 at 12:20 +, Mark McLoughlin wrote:
dnl
dnl make CFLAGS very pedantic at least during the devel phase for everybody
+dnl (Overriding $CFLAGS here is very wrong. See discussion of AM_CFLAGS
+dnl in the automake info. - RWMJ)
dnl
if test ${GCC} = yes ;
On Thu, Mar 01, 2007 at 04:09:26PM +, Mark McLoughlin wrote:
On Thu, 2007-03-01 at 16:06 +, Mark McLoughlin wrote:
@@ -75,7 +77,7 @@ dnl
dnl make CFLAGS very pedantic at least during the devel phase for everybody
dnl
if test ${GCC} = yes ; then
- CFLAGS=-g -O -W
Mark McLoughlin wrote:
On Thu, 2007-03-01 at 16:16 +, Daniel P. Berrange wrote:
On Thu, Mar 01, 2007 at 04:09:26PM +, Mark McLoughlin wrote:
Uh, never mind this ... fixed patch attached.
Looks good to me, lets commit it.
Done. Now, who wants to make it build with
Richard W.M. Jones wrote:
Mark McLoughlin wrote:
On Thu, 2007-03-01 at 16:16 +, Daniel P. Berrange wrote:
On Thu, Mar 01, 2007 at 04:09:26PM +, Mark McLoughlin wrote:
Uh, never mind this ... fixed patch attached.
Looks good to me, lets commit it.
Done. Now, who wants to
Richard W.M. Jones [EMAIL PROTECTED] wrote:
Richard W.M. Jones wrote:
Mark McLoughlin wrote:
On Thu, 2007-03-01 at 16:16 +, Daniel P. Berrange wrote:
On Thu, Mar 01, 2007 at 04:09:26PM +, Mark McLoughlin wrote:
Uh, never mind this ... fixed patch attached.
Looks good to me, lets
Mark McLoughlin [EMAIL PROTECTED] wrote:
On Wed, 2007-02-28 at 16:24 +, Richard W.M. Jones wrote:
virGetDomain(virConnectPtr conn, const char *name, const unsigned char
*uuid) {
virDomainPtr ret = NULL;
-if ((!VIR_IS_CONNECT(conn)) || ((name == NULL) (uuid == NULL)) ||
+
On Thu, Mar 01, 2007 at 06:11:44PM +0900, Tatsuro Enokura wrote:
Hi, Dan
Daniel P. Berrange wrote:
and shut-off domain's information is got from xend.
I make a patch for xend_internal.c
The attached patch resolve this issue in the following way:
1) If the domain's name can't be
On Thu, Mar 01, 2007 at 10:02:03AM +0900, Masayuki Sunou wrote:
Hi
The maximum of virtual CPU is not guarded in virsh setvcpus now.
Then, when 32767 was set to virtual CPU of virsh setvcpus, the problem
that Xend became abnormal was detected.
example:
On Thu, Mar 01, 2007 at 08:13:40PM +0900, Kazuki Mizushima wrote:
Hi, Dan
After I studying this issue,
I change my mind about fixing method.
How do you think about this?
1)Change the scanning code from Cannot to xend.err
By the survey on xend_internal.c, I found
Xend reports errors
Hi, Dan
Daniel P. Berrange wrote:
and shut-off domain's information is got from xend.
I make a patch for xend_internal.c
The attached patch resolve this issue in the following way:
1) If the domain's name can't be pulled out from
the running domains list by uuid, request xend by
20 matches
Mail list logo
