Re: [Libvir] [PATCH] Add the message when a little memory is set with setmaxmem.

2007-03-26 Thread Daniel Veillard
On Mon, Mar 26, 2007 at 11:34:10AM +0900, Masayuki Sunou wrote: Hi Daniel Hi Masayuki, I understood your suggestion. Therefore, I decline applying this patch. [...] I'm afraid that patch - even if limited to virsh - is unfortunately not a good idea, as usual the preferred way would

Re: [Libvir] [PATCH] Fix value of XEN_V2_OP_SETMAXMEM

2007-03-26 Thread Daniel Veillard
On Mon, Mar 26, 2007 at 09:24:27AM +0900, Masayuki Sunou wrote: Hi Because the value of XEN_V2_OP_SETMAXMEM in xen_internal.c is wrong, virsh setmaxmem outputs error message. -- Both XEN_V2_OP_SETMAXMEM and XEN_V2_OP_GETVCPUINFO are set to 14, but XEN_V2_OP_SETMAXMEM should be set to

[Libvir] [PATCH] Fix warn_unused_result when compiling with latest glibc

2007-03-26 Thread Richard W.M. Jones
I'm not sure if this is the right way to solve this, but it is a way. Rich. Index: qemud/qemud.c === RCS file: /data/cvs/libvirt/qemud/qemud.c,v retrieving revision 1.34 diff -u -r1.34 qemud.c --- qemud/qemud.c 22 Mar 2007 18:30:57

Re: [Libvir] [PATCH] Fix warn_unused_result when compiling with latest glibc

2007-03-26 Thread Daniel Veillard
On Mon, Mar 26, 2007 at 03:39:51PM +0100, Richard W.M. Jones wrote: I'm not sure if this is the right way to solve this, but it is a way. we should test the return value to check for an error there, the unfortunate thing is that since we are in a signal handler there isn't much we can do, I

Re: [Libvir] [PATCH] Fix warn_unused_result when compiling with latest glibc

2007-03-26 Thread Richard W.M. Jones
Daniel Veillard wrote: On Mon, Mar 26, 2007 at 03:39:51PM +0100, Richard W.M. Jones wrote: I'm not sure if this is the right way to solve this, but it is a way. we should test the return value to check for an error there, the unfortunate thing is that since we are in a signal handler there

Re: [Libvir] [PATCH] Fix warn_unused_result when compiling with latest glibc

2007-03-26 Thread Daniel P. Berrange
On Mon, Mar 26, 2007 at 04:22:33PM +0100, Richard W.M. Jones wrote: Daniel Veillard wrote: On Mon, Mar 26, 2007 at 03:39:51PM +0100, Richard W.M. Jones wrote: I'm not sure if this is the right way to solve this, but it is a way. we should test the return value to check for an error there,

Re: [Libvir] [PATCH] pae/nonpae capabilities for paravirt xen guests

2007-03-26 Thread Daniel P. Berrange
On Sun, Mar 25, 2007 at 03:48:41PM +0100, Richard W.M. Jones wrote: David Lutterkort wrote: I noticed that the guest capabilities on a xen dom0 always contain both the pae and nonpae feature - AFAIK, you can't mix pae/nonpae guests and hosts, and only one of the features should be there.

Re: [Libvir] [PATCH] Fix warn_unused_result when compiling with latest glibc

2007-03-26 Thread Daniel Veillard
On Mon, Mar 26, 2007 at 04:22:33PM +0100, Richard W.M. Jones wrote: Daniel Veillard wrote: On Mon, Mar 26, 2007 at 03:39:51PM +0100, Richard W.M. Jones wrote: I'm not sure if this is the right way to solve this, but it is a way. we should test the return value to check for an error there,

Re: [Libvir] [PATCH] pae/nonpae capabilities for paravirt xen guests

2007-03-26 Thread Daniel P. Berrange
On Fri, Mar 23, 2007 at 12:24:57PM -0700, David Lutterkort wrote: I noticed that the guest capabilities on a xen dom0 always contain both the pae and nonpae feature - AFAIK, you can't mix pae/nonpae guests and hosts, and only one of the features should be there. So it turned out to be a bit

[Libvir] libvirt not compatible with Xen-unstable hypercall API ?

2007-03-26 Thread Jerone Young
While trying to verify any potential problem between with libvirt Xen PPC port. I've found that libvirt currently in CVS attempts to determine what hypercall version to follow, by looking at the hypervisior version. It determines that this is some arbitrary versioning v2 of the hypercall api.

Re: [Libvir] [PATCH] pae/nonpae capabilities for paravirt xen guests

2007-03-26 Thread Daniel Veillard
On Mon, Mar 26, 2007 at 08:39:16PM +0100, Daniel P. Berrange wrote: On Fri, Mar 23, 2007 at 12:24:57PM -0700, David Lutterkort wrote: I noticed that the guest capabilities on a xen dom0 always contain both the pae and nonpae feature - AFAIK, you can't mix pae/nonpae guests and hosts, and