Re: [Libvir] [PATCH] increase storage domains of a definition file

2007-04-24 Thread Atsushi SAKAI
Hi, Dan Thank you for comment. Shigeki does not repond this issue at this moment. I will comment on this instead. He should respond this issue quickly! In his survey, Many area is allocated as constant data(usually about 1KB size) in libvirt. He plan to fix this issue(dynamical allocation(which

Re: [Libvir] [PATCH] increase storage domains of a definition file

2007-04-24 Thread Daniel Veillard
On Tue, Apr 24, 2007 at 08:36:01PM +0900, Atsushi SAKAI wrote: Hi, Dan Thank you for comment. Shigeki does not repond this issue at this moment. I will comment on this instead. He should respond this issue quickly! In his survey, Many area is allocated as constant data(usually about 1KB

[Libvir] Re: [PATCH] allocate virBuffer* routines

2007-04-24 Thread S.Sakamoto
Hi, Daniel I can't help thinking this method would be better off using the dyn allocated virBuffer* routines instead of a static string snprintf. Oops, sorry, virBuffer* routines had entirely slipped my mind. Buffer is allocated dynamically when I use this. therefore, I make the patch

Re: [Libvir] [PATCH][RFC] Adding Cloning Feature

2007-04-24 Thread Daniel Veillard
On Tue, Apr 24, 2007 at 10:57:09PM +0900, Kazuki Mizushima wrote: Hi all, Hi Kazuki, I've been planing to adding cloning feature. Hum, interesting usage, of course it sounds difficult to really fully automate it in a completely generic way. Then, I tried to make the patch in the following

Re: [Libvir] [PATCH][RFC] Adding Cloning Feature

2007-04-24 Thread Richard W.M. Jones
Kazuki Mizushima wrote: Hi all, I've been planing to adding cloning feature. Then, I tried to make the patch in the following way. [...] Right - didn't see the patch the first time around ... I think the clone should be done as a libvirt call, rather than in virsh. Adding stuff to virsh

Re: [Libvir] [PATCH][RFC] Adding Cloning Feature

2007-04-24 Thread Kazuki Mizushima
Hi Rich, I think cloning is a great feature. From when I used to sysadmin a Xen server, I used cloning as the main technique to create new servers - ie. take an existing machine which is similar to the new one which I want, and just clone it. Thank you for your comments and agreement.