Re: [Libvir] Extending libvirt to probe NUMA topology

2007-06-14 Thread Richard W.M. Jones
Daniel P. Berrange wrote: - Linux/Solaris Xen - hypercalls - Linux non-Xen - libnuma - Solaris non-Xen - liblgrp The Xen Linux modelling seems reasonably similar IIRC, but Solaris is a slightly different representational approach. The Solaris approach seems to be fully hierarchical

[Libvir] Re: parted/LVM for ET [Storage manager initial requirements and thoughts

2007-06-14 Thread Jim Meyering
I'm reviving this old thread to give you all an update. http://thread.gmane.org/gmane.comp.emulators.libvirt/826 I've been working on parted for some time now, http://git.debian.org/?p=parted/parted.git;a=summary http://news.gmane.org/gmane.comp.gnu.parted.devel and have just

Re: [Libvir] Extending libvirt to probe NUMA topology

2007-06-14 Thread Daniel Veillard
On Thu, Jun 14, 2007 at 02:08:12PM +0100, Richard W.M. Jones wrote: Daniel P. Berrange wrote: - Linux/Solaris Xen - hypercalls - Linux non-Xen - libnuma - Solaris non-Xen - liblgrp The Xen Linux modelling seems reasonably similar IIRC, but Solaris is a slightly different

Re: [Libvir] Re: parted/LVM for ET [Storage manager initial requirements and thoughts

2007-06-14 Thread Richard W.M. Jones
Jim Meyering wrote: [...] Thanks for looking into this. In addition, there is the fact that Parted's partition-table (aka what it calls label) support is currently tied to a 512-byte sector size for many label types. BTW, do any of you know which are the partition types that matter the most

Re: [Libvir] Re: parted/LVM for ET [Storage manager initial requirements and thoughts

2007-06-14 Thread Daniel P. Berrange
On Thu, Jun 14, 2007 at 03:50:28PM +0100, Richard W.M. Jones wrote: Jim Meyering wrote: [...] Thanks for looking into this. In addition, there is the fact that Parted's partition-table (aka what it calls label) support is currently tied to a 512-byte sector size for many label types.

Re: [Libvir] Re: parted/LVM for ET [Storage manager initial requirements and thoughts

2007-06-14 Thread Jim Meyering
Richard W.M. Jones [EMAIL PROTECTED] wrote: ... From the virt-manager/libvirt p.o.v. it seems to me the important operations are: (1) Find attached drives. (2) Find partitions available their sizes. (3) Allocate logical volumes. (4) Find out how much free space is available on a

Re: [Libvir] Re: parted/LVM for ET [Storage manager initial requirements and thoughts

2007-06-14 Thread Daniel P. Berrange
On Thu, Jun 14, 2007 at 05:55:33PM +0200, Jim Meyering wrote: Richard W.M. Jones [EMAIL PROTECTED] wrote: ... From the virt-manager/libvirt p.o.v. it seems to me the important operations are: (1) Find attached drives. (2) Find partitions available their sizes. (3) Allocate

Re: [Libvir] Re: parted/LVM for ET [Storage manager initial requirements and thoughts

2007-06-14 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: And (4) can be done by libvirtd using ordinary POSIX calls, so no external library support is needed, just some work to remote those operations (which is mostly done). Isn't doing #4 portably pretty tricky? There's still too much variation,

Re: [Libvir] Re: parted/LVM for ET [Storage manager initial requirements and thoughts

2007-06-14 Thread Daniel P. Berrange
On Thu, Jun 14, 2007 at 07:16:21PM +0200, Jim Meyering wrote: Daniel P. Berrange [EMAIL PROTECTED] wrote: And (4) can be done by libvirtd using ordinary POSIX calls, so no external library support is needed, just some work to remote those operations (which is mostly done). Isn't

Re: [Libvir] Re: parted/LVM for ET [Storage manager initial requirements and thoughts

2007-06-14 Thread Richard W.M. Jones
Daniel P. Berrange wrote: On Thu, Jun 14, 2007 at 07:16:21PM +0200, Jim Meyering wrote: Daniel P. Berrange [EMAIL PROTECTED] wrote: And (4) can be done by libvirtd using ordinary POSIX calls, so no external library support is needed, just some work to remote those operations (which is mostly

[Libvir] [PATCH] Spelling fix

2007-06-14 Thread Mark Johnson
Hi all, This is the first of 10 or 11 patches I'll be submitting which gets libvirt compiling/working on a Solaris dom0. Also some minor generic bug fixing.. Sorry it took me so long from the Xen Summit.. Starting with a very simple one. :-) As I test them on the cvs tree on Fedora, I'll

[Libvir] [PATCH] null pointer fix on debug build

2007-06-14 Thread Mark Johnson
this fixes a null pointer dereference in printf on a DEBUG build. Mark null-string-ptr Description: Binary data -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[Libvir] [PATCH] return 0 networks if Network driver not implemented

2007-06-14 Thread Mark Johnson
This handles net-list, etc. a little more gracefully for Xen. Mark nonet Description: Binary data -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[Libvir] [PATCH] setmem checks

2007-06-14 Thread Mark Johnson
This one may be a little contentious... This patch does a couple of things... It won't let you set memory if the value is greater that maxmem. It also will lower memory if max memory is set to less than memory. I think it's a good argument that this checking should be in the hypervisor control

[Libvir] [PATCH] setvcpus message

2007-06-14 Thread Mark Johnson
This patch is probably not correct. I wasn't sure how to handle I18N in libvirt. Had a request to add an error message for setvcpus domain 0. This patch prints an error message for that case. Mark setvcpu-fixes Description: Binary data -- Libvir-list mailing list Libvir-list@redhat.com

[Libvir] [PATCH] hypervisor version

2007-06-14 Thread Mark Johnson
This is another patch which may not be popular? Xen's extra version does not fit in libvirt's release field (since it's part of an int). Instead of printing out the wrong value, just display major.minor in virsh. Mark version-fix Description: Binary data -- Libvir-list mailing list

[Libvir] [PATCH] vcpuinfo message

2007-06-14 Thread Mark Johnson
Another requested error message. This prints out a message if the vcpuinfo failed because the domain was shutdown. same comment as previous patch about I18N. Mark getvcpu-fix Description: Binary data -- Libvir-list mailing list Libvir-list@redhat.com

[Libvir] [PATCH] header file changes for Solaris

2007-06-14 Thread Mark Johnson
This patch has the includes need to build on Solaris. I've been using ifdef linux ifndef linux to distinguish between solaris and linux at this point. I'm not sure what the preference is... MRJ solaris-headers Description: Binary data -- Libvir-list mailing list Libvir-list@redhat.com

Re: [Libvir] [PATCH] null pointer fix on debug build

2007-06-14 Thread Daniel P. Berrange
On Thu, Jun 14, 2007 at 04:11:54PM -0400, Mark Johnson wrote: this fixes a null pointer dereference in printf on a DEBUG build. +1, ACK Dan -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/

Re: [Libvir] [PATCH] return 0 networks if Network driver not implemented

2007-06-14 Thread Daniel P. Berrange
On Thu, Jun 14, 2007 at 04:23:38PM -0400, Mark Johnson wrote: This handles net-list, etc. a little more gracefully for Xen. I'm not so sure about this one. a. Xen does have support for net-list which is currently done via the (badly named) libvirt_qemud daemon. Though the network stuff

Re: [Libvir] [PATCH] setmem checks

2007-06-14 Thread Daniel P. Berrange
On Thu, Jun 14, 2007 at 04:45:49PM -0400, Mark Johnson wrote: This one may be a little contentious... This patch does a couple of things... It won't let you set memory if the value is greater that maxmem. It also will lower memory if max memory is set to less than memory. Yeah, that's a

Re: [Libvir] [PATCH] setvcpus message

2007-06-14 Thread Daniel P. Berrange
On Thu, Jun 14, 2007 at 04:55:14PM -0400, Mark Johnson wrote: This patch is probably not correct. I wasn't sure how to handle I18N in libvirt. What you've done there is correct. The build process extracts any strings marked with _(...) and puts them into the .pot files. We push these out to

Re: [Libvir] [PATCH] Spelling fix

2007-06-14 Thread Daniel Veillard
On Thu, Jun 14, 2007 at 04:07:36PM -0400, Mark Johnson wrote: Hi all, This is the first of 10 or 11 patches I'll be submitting which gets libvirt compiling/working on a Solaris dom0. Also some minor generic bug fixing.. Thanks, it's too late for me to go through them, but I will look

Re: [Libvir] [PATCH] hypervisor version

2007-06-14 Thread Daniel P. Berrange
On Thu, Jun 14, 2007 at 05:06:16PM -0400, Mark Johnson wrote: This is another patch which may not be popular? Xen's extra version does not fit in libvirt's release field (since it's part of an int). Instead of printing out the wrong value, just display major.minor in virsh. Hmm, so with

Re: [Libvir] [PATCH] vcpuinfo message

2007-06-14 Thread Daniel P. Berrange
On Thu, Jun 14, 2007 at 05:12:15PM -0400, Mark Johnson wrote: Another requested error message. This prints out a message if the vcpuinfo failed because the domain was shutdown. same comment as previous patch about I18N. Looks fine. Regards, Dan. -- |=- Red Hat, Engineering, Emerging

Re: [Libvir] [PATCH] return 0 networks if Network driver not implemented

2007-06-14 Thread Mark Johnson
On 6/14/07, Daniel P. Berrange [EMAIL PROTECTED] wrote: On Thu, Jun 14, 2007 at 04:23:38PM -0400, Mark Johnson wrote: This handles net-list, etc. a little more gracefully for Xen. I'm not so sure about this one. a. Xen does have support for net-list which is currently done via the (badly

Re: [Libvir] [PATCH] Solaris dom0 support

2007-06-14 Thread Daniel P. Berrange
On Thu, Jun 14, 2007 at 06:01:56PM -0400, Mark Johnson wrote: This is a little bigger of a patch. It has a couple of things in it. First, in xen_internal.c and xs_internal.c have general dom0 support for Solaris. Again, using #ifdef/ifndef __linux__ to separate the logic. I'm getting a

Re: [Libvir] [PATCH] header file changes for Solaris

2007-06-14 Thread Mark Johnson
On 6/14/07, Daniel P. Berrange [EMAIL PROTECTED] wrote: On Thu, Jun 14, 2007 at 05:26:39PM -0400, Mark Johnson wrote: This patch has the includes need to build on Solaris. I've been using ifdef linux ifndef linux to distinguish between solaris and linux at this point. Looks ok aside from

Re: [Libvir] [PATCH] header file changes for Solaris

2007-06-14 Thread Daniel P. Berrange
On Thu, Jun 14, 2007 at 07:05:49PM -0400, Mark Johnson wrote: On 6/14/07, Daniel P. Berrange [EMAIL PROTECTED] wrote: On Thu, Jun 14, 2007 at 05:26:39PM -0400, Mark Johnson wrote: This patch has the includes need to build on Solaris. I've been using ifdef linux ifndef linux to distinguish

Re: [Libvir] [PATCH] Solaris dom0 support

2007-06-14 Thread John Levon
On Fri, Jun 15, 2007 at 12:05:33AM +0100, Daniel P. Berrange wrote: I'm curious as to what the changes for bootloader / kernel are for ? Surely you always have either a bootloader, or a kenrel present in the SEXPR ? So I'm not sure why its neccessary to disable the check No, this is not true,

Re: [Libvir] [PATCH] Solaris dom0 support

2007-06-14 Thread Mark Johnson
On 6/14/07, Daniel P. Berrange [EMAIL PROTECTED] wrote: On Thu, Jun 14, 2007 at 06:01:56PM -0400, Mark Johnson wrote: This is a little bigger of a patch. It has a couple of things in it. First, in xen_internal.c and xs_internal.c have general dom0 support for Solaris. Again, using

Re: [Libvir] [PATCH] _N() has a conflict in Solaris

2007-06-14 Thread Mark Johnson
On 6/14/07, Daniel P. Berrange [EMAIL PROTECTED] wrote: On Thu, Jun 14, 2007 at 05:37:56PM -0400, Mark Johnson wrote: There is a conflict with _N() in Solaris. Hmm, not entirely sure what I was thinking of when I chose _N anyway, it looks like N_ is the more common standard. Would using N_

Re: [Libvir] [PATCH] Solaris dom0 support

2007-06-14 Thread Daniel P. Berrange
On Fri, Jun 15, 2007 at 12:21:09AM +0100, John Levon wrote: On Fri, Jun 15, 2007 at 12:05:33AM +0100, Daniel P. Berrange wrote: I'm curious as to what the changes for bootloader / kernel are for ? Surely you always have either a bootloader, or a kenrel present in the SEXPR ? So I'm not

Re: [Libvir] Re: parted/LVM for ET [Storage manager initial requirements and thoughts

2007-06-14 Thread Daniel P. Berrange
On Thu, Jun 14, 2007 at 08:07:09PM +0200, Jim Meyering wrote: Daniel P. Berrange [EMAIL PROTECTED] wrote: ... http://cvs.sv.gnu.org/viewcvs/gnulib/lib/fsusage.c?root=gnulibview=markup Unfortunately we can't use that. The license is GPL, while libvirt needs to be LGPL :-( Ugh. That,

Re: [Libvir] [PATCH] Do check the UUID in __virGetDomain()

2007-06-14 Thread Masayuki Sunou
Hi Dan Hmm, I strongly suspect one (or more) of the commands in this series of steps is missing a call for virDomainFree(). Every individual virsh command should be freeing all the objects it has open (aside fromthe virConnectPtr), so the cache of virDomainPtr objects ought to be empty for

Re: [Libvir] [PATCH] _N() has a conflict in Solaris

2007-06-14 Thread Mark Johnson
On 6/14/07, Mark Johnson [EMAIL PROTECTED] wrote: On 6/14/07, Daniel P. Berrange [EMAIL PROTECTED] wrote: On Thu, Jun 14, 2007 at 05:37:56PM -0400, Mark Johnson wrote: There is a conflict with _N() in Solaris. Hmm, not entirely sure what I was thinking of when I chose _N anyway, it looks

Re: [Libvir] [PATCH] Solaris dom0 support

2007-06-14 Thread Mark Johnson
On 6/14/07, Mark Johnson [EMAIL PROTECTED] wrote: I'm getting a little confused about the xen_internal.c changes for the hypercalls. This is chunk: Yeah, another funcky diff.. I'll send a different diff for this file later tonight. I'm managing the changes out of a hg mq gate. @@ -38,6

Re: [Libvir] [PATCH] Solaris dom0 support

2007-06-14 Thread John Levon
On Fri, Jun 15, 2007 at 01:02:16AM +0100, Daniel P. Berrange wrote: I'm curious as to what the changes for bootloader / kernel are for ? Surely you always have either a bootloader, or a kenrel present in the SEXPR ? So I'm not sure why its neccessary to disable the check No, this is

Re: [Libvir] [PATCH] Solaris dom0 support

2007-06-14 Thread Daniel P. Berrange
On Fri, Jun 15, 2007 at 02:26:36AM +0100, John Levon wrote: On Fri, Jun 15, 2007 at 01:02:16AM +0100, Daniel P. Berrange wrote: I'm curious as to what the changes for bootloader / kernel are for ? Surely you always have either a bootloader, or a kenrel present in the SEXPR ? So I'm

Re: [Libvir] [PATCH] Solaris dom0 support

2007-06-14 Thread John Levon
On Fri, Jun 15, 2007 at 03:20:19AM +0100, Daniel P. Berrange wrote: Well to give some form of indication as to how the guest is being booted. Perhaps rather than making up a default path, just an empty bootloader/ element would work. The semantics being launch with the default bootloader for